Don't rearm rs timer if callback is not set

[project/odhcpd.git] / src / router.c

diff --git a/src/router.c b/src/router.c
index fffdc4c..dfbcf60 100644 (file)
--- a/src/router.c
+++ b/src/router.c
@@ -130,23 +130,19 @@ static void sigusr1_refresh(_unused int signal)
                        uloop_timeout_set(&iface->timer_rs, 1000);
 }
 
                        uloop_timeout_set(&iface->timer_rs, 1000);
 }
 

-static int router_icmpv6_valid(struct sockaddr_in6 *source, uint8_t *data, size_t len)
+static bool router_icmpv6_valid(struct sockaddr_in6 *source, uint8_t *data, size_t len)

 {
        struct icmp6_hdr *hdr = (struct icmp6_hdr *)data;
 {
        struct icmp6_hdr *hdr = (struct icmp6_hdr *)data;

-       struct icmpv6_opt *opt;
-       size_t optlen = len - sizeof(*hdr);
+       struct icmpv6_opt *opt, *end = (struct icmpv6_opt*)&data[len];

 
        /* Hoplimit is already checked in odhcpd_receive_packets */
 
        /* Hoplimit is already checked in odhcpd_receive_packets */

-       if (len < sizeof(*hdr))
-               return 0;
-
-       if (hdr->icmp6_code)
-               return 0;
+       if (len < sizeof(*hdr) || hdr->icmp6_code)
+               return false;

 
        switch (hdr->icmp6_type) {
        case ND_ROUTER_ADVERT:
                if (!IN6_IS_ADDR_LINKLOCAL(&source->sin6_addr))
 
        switch (hdr->icmp6_type) {
        case ND_ROUTER_ADVERT:
                if (!IN6_IS_ADDR_LINKLOCAL(&source->sin6_addr))

-                       return 0;
+                       return false;

 
                opt = (struct icmpv6_opt *)((struct nd_router_advert *)data + 1);
                break;
 
                opt = (struct icmpv6_opt *)((struct nd_router_advert *)data + 1);
                break;


@@ -156,29 +152,17 @@ static int router_icmpv6_valid(struct sockaddr_in6 *source, uint8_t *data, size_
                break;
 
        default:
                break;
 
        default:

-               return 0;
+               return false;

        }
 
        }
 

-       while (optlen > 0) {
-               size_t l = opt->len << 3;
-
-               if (optlen < sizeof(*opt))
-                       return 0;
-
-               if (l > optlen || l == 0)
-                       return 0;
-
-               if (opt->type == ND_OPT_SOURCE_LINKADDR && IN6_IS_ADDR_UNSPECIFIED(&source->sin6_addr) &&
-                       hdr->icmp6_type == ND_ROUTER_SOLICIT) {
-                       return 0;
-               }
+       icmpv6_for_each_option(opt, opt, end)
+               if (opt->type == ND_OPT_SOURCE_LINKADDR &&
+                               IN6_IS_ADDR_UNSPECIFIED(&source->sin6_addr) &&
+                               hdr->icmp6_type == ND_ROUTER_SOLICIT)
+                       return false;

 
 

-               opt = (struct icmpv6_opt *)(((uint8_t *)opt) + l);
-
-               optlen -= l;
-       }
-
-       return 1;
+       // Check all options parsed successfully
+       return opt == end;

 }
 
 // Event handler for incoming ICMPv6 packets
 }
 
 // Event handler for incoming ICMPv6 packets


@@ -186,7 +170,7 @@ static void handle_icmpv6(void *addr, void *data, size_t len,
                struct interface *iface)
 {
        struct icmp6_hdr *hdr = data;
                struct interface *iface)
 {
        struct icmp6_hdr *hdr = data;

-       
+

        if (!router_icmpv6_valid(addr, data, len))
                return;
 
        if (!router_icmpv6_valid(addr, data, len))
                return;
 


@@ -361,11 +345,6 @@ static void send_router_advert(struct uloop_timeout *event)
                adv.h.nd_ra_router_lifetime = 0;
        }
 
                adv.h.nd_ra_router_lifetime = 0;
        }
 

-       if (have_public && iface->deprecate_ula_if_public_avail)
-               for (size_t i = 0; i < cnt; ++i)
-                       if ((adv.prefix[i].nd_opt_pi_prefix.s6_addr[0] & 0xfe) == 0xfc)
-                               adv.prefix[i].nd_opt_pi_preferred_time = 0;
-

        // DNS Recursive DNS
        if (iface->dns_cnt > 0) {
                dns_addr = iface->dns;
        // DNS Recursive DNS
        if (iface->dns_cnt > 0) {
                dns_addr = iface->dns;


@@ -472,12 +451,14 @@ static void send_router_advert(struct uloop_timeout *event)
        odhcpd_send(router_event.uloop.fd,
                        &all_nodes, iov, ARRAY_SIZE(iov), iface);
 
        odhcpd_send(router_event.uloop.fd,
                        &all_nodes, iov, ARRAY_SIZE(iov), iface);
 

-       // Rearm timer
-       int msecs;
-       odhcpd_urandom(&msecs, sizeof(msecs));
-       msecs = (labs(msecs) % (1000 * (MaxRtrAdvInterval
-                       - MinRtrAdvInterval))) + (MinRtrAdvInterval * 1000);
-       uloop_timeout_set(&iface->timer_rs, msecs);
+       // Rearm timer if not shut down
+       if (event->cb) {
+               int msecs;
+               odhcpd_urandom(&msecs, sizeof(msecs));
+               msecs = (labs(msecs) % (1000 * (MaxRtrAdvInterval
+                               - MinRtrAdvInterval))) + (MinRtrAdvInterval * 1000);
+               uloop_timeout_set(&iface->timer_rs, msecs);
+       }

 }
 
 
 }