Merge pull request #21 from mehlis/fix-nak-by-doing-valid-reply
[project/odhcpd.git] / src / ndp.c
index 02c2dbd..44884be 100644 (file)
--- a/src/ndp.c
+++ b/src/ndp.c
@@ -17,6 +17,7 @@
 #include <signal.h>
 #include <errno.h>
 
+#include <unistd.h>
 #include <arpa/inet.h>
 #include <sys/socket.h>
 #include <net/ethernet.h>
@@ -32,9 +33,9 @@
 
 
 static void handle_solicit(void *addr, void *data, size_t len,
-               struct interface *iface);
+               struct interface *iface, void *dest);
 static void handle_rtnetlink(void *addr, void *data, size_t len,
-               struct interface *iface);
+               struct interface *iface, void *dest);
 static struct ndp_neighbor* find_neighbor(struct in6_addr *addr, bool strict);
 static void modify_neighbor(struct in6_addr *addr, struct interface *iface,
                bool add);
@@ -90,27 +91,12 @@ int init_ndp(void)
        send(rtnl_event.uloop.fd, &req2, sizeof(req2), MSG_DONTWAIT);
        odhcpd_register(&rtnl_event);
 
-
-       // Create socket for intercepting NDP
-       int sock = socket(AF_PACKET, SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK,
-                       htons(ETH_P_ALL)); // ETH_P_ALL for ingress + egress
-       if (sock < 0) {
-               syslog(LOG_ERR, "Unable to open packet socket: %s",
-                               strerror(errno));
-               return -1;
-       }
-
-       if (setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER,
-                       &bpf_prog, sizeof(bpf_prog))) {
-               syslog(LOG_ERR, "Failed to set BPF: %s", strerror(errno));
-               return -1;
-       }
-
-       ndp_event.uloop.fd = sock;
-       odhcpd_register(&ndp_event);
-
        // Open ICMPv6 socket
        ping_socket = socket(AF_INET6, SOCK_RAW | SOCK_CLOEXEC, IPPROTO_ICMPV6);
+       if (ping_socket < 0) {
+               syslog(LOG_ERR, "Unable to open raw socket: %s", strerror(errno));
+                       return -1;
+       }
 
        int val = 2;
        setsockopt(ping_socket, IPPROTO_RAW, IPV6_CHECKSUM, &val, sizeof(val));
@@ -167,6 +153,7 @@ int setup_ndp_interface(struct interface *iface, bool enable)
                        memcpy(entry, iface->static_ndp, iface->static_ndp_len);
 
                        for (entry = strtok_r(entry, " ", &saveptr); entry; entry = strtok_r(NULL, " ", &saveptr)) {
+                               char *sep;
                                struct ndp_neighbor *n = malloc(sizeof(*n));
                                if (!n) {
                                        syslog(LOG_ERR, "Malloc failed for static NDP-prefix %s", entry);
@@ -176,18 +163,59 @@ int setup_ndp_interface(struct interface *iface, bool enable)
                                n->iface = iface;
                                n->timeout = 0;
 
-                               char ipbuf[INET6_ADDRSTRLEN];
-                               if (sscanf(entry, "%45s/%hhu", ipbuf, &n->len) < 2
-                                               || n->len > 128 || inet_pton(AF_INET6, ipbuf, &n->addr) != 1) {
+                               sep = strchr(entry, '/');
+                               if (!sep) {
+                                       free(n);
                                        syslog(LOG_ERR, "Invalid static NDP-prefix %s", entry);
                                        return -1;
                                }
+                               
+                               *sep = 0;
+                               n->len = atoi(sep + 1);
+                               if (inet_pton(AF_INET6, entry, &n->addr) != 1 || n->len > 128) {
+                                       free(n);
+                                       syslog(LOG_ERR, "Invalid static NDP-prefix %s/%s", entry, sep + 1);
+                                       return -1;
+                               }
 
                                list_add(&n->head, &neighbors);
                        }
                }
        }
 
+       bool enable_packet = false;
+       struct interface *i;
+       list_for_each_entry(i, &interfaces, head) {
+               if (i == iface && !enable)
+                       continue;
+
+               if (i->ndp == RELAYD_RELAY)
+                       enable_packet = true;
+       }
+
+       if (enable_packet && ndp_event.uloop.fd < 0) {
+               // Create socket for intercepting NDP
+               int sock = socket(AF_PACKET, SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK,
+                               htons(ETH_P_ALL)); // ETH_P_ALL for ingress + egress
+               if (sock < 0) {
+                       syslog(LOG_ERR, "Unable to open packet socket: %s",
+                                       strerror(errno));
+                       return -1;
+               }
+
+               if (setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER,
+                               &bpf_prog, sizeof(bpf_prog))) {
+                       syslog(LOG_ERR, "Failed to set BPF: %s", strerror(errno));
+                       return -1;
+               }
+
+               ndp_event.uloop.fd = sock;
+               odhcpd_register(&ndp_event);
+       } else if (!enable_packet && ndp_event.uloop.fd >= 0) {
+               close(ndp_event.uloop.fd);
+               ndp_event.uloop.fd = -1;
+       }
+
        return 0;
 }
 
@@ -210,7 +238,7 @@ static ssize_t ping6(struct in6_addr *addr,
 
 // Handle solicitations
 static void handle_solicit(void *addr, void *data, size_t len,
-               struct interface *iface)
+               struct interface *iface, _unused void *dest)
 {
        struct ip6_hdr *ip6 = data;
        struct nd_neighbor_solicit *req = (struct nd_neighbor_solicit*)&ip6[1];
@@ -364,41 +392,12 @@ static void free_neighbor(struct ndp_neighbor *n)
        --neighbor_count;
 }
 
-
-static bool match_neighbor(struct ndp_neighbor *n, struct in6_addr *addr)
-{
-       if (n->len <= 32)
-               return ntohl(n->addr.s6_addr32[0]) >> (32 - n->len) ==
-                               ntohl(addr->s6_addr32[0]) >> (32 - n->len);
-
-       if (n->addr.s6_addr32[0] != addr->s6_addr32[0])
-               return false;
-
-       if (n->len <= 64)
-               return ntohl(n->addr.s6_addr32[1]) >> (64 - n->len) ==
-                               ntohl(addr->s6_addr32[1]) >> (64 - n->len);
-
-       if (n->addr.s6_addr32[1] != addr->s6_addr32[1])
-               return false;
-
-       if (n->len <= 96)
-               return ntohl(n->addr.s6_addr32[2]) >> (96 - n->len) ==
-                               ntohl(addr->s6_addr32[2]) >> (96 - n->len);
-
-       if (n->addr.s6_addr32[2] != addr->s6_addr32[2])
-               return false;
-
-       return ntohl(n->addr.s6_addr32[3]) >> (128 - n->len) ==
-                       ntohl(addr->s6_addr32[3]) >> (128 - n->len);
-}
-
-
 static struct ndp_neighbor* find_neighbor(struct in6_addr *addr, bool strict)
 {
        time_t now = time(NULL);
        struct ndp_neighbor *n, *e;
        list_for_each_entry_safe(n, e, &neighbors, head) {
-               if ((!strict && match_neighbor(n, addr)) ||
+               if ((!strict && !odhcpd_bmemcmp(&n->addr, addr, n->len)) ||
                                (n->len == 128 && IN6_ARE_ADDR_EQUAL(&n->addr, addr)))
                        return n;
 
@@ -451,7 +450,7 @@ static void modify_neighbor(struct in6_addr *addr,
 // Handler for neighbor cache entries from the kernel. This is our source
 // to learn and unlearn hosts on interfaces.
 static void handle_rtnetlink(_unused void *addr, void *data, size_t len,
-               _unused struct interface *iface)
+               _unused struct interface *iface, _unused void *dest)
 {
        for (struct nlmsghdr *nh = data; NLMSG_OK(nh, len);
                        nh = NLMSG_NEXT(nh, len)) {