ndp: don't trigger IPv6 ping when neighbor entry is invalid

[project/odhcpd.git] / src / dhcpv6-ia.c

diff --git a/src/dhcpv6-ia.c b/src/dhcpv6-ia.c
index e5a7c0b..3275da5 100644 (file)
--- a/src/dhcpv6-ia.c
+++ b/src/dhcpv6-ia.c
@@ -1,5 +1,6 @@
 /**
  * Copyright (C) 2013 Steven Barth <steven@midlink.org>
 /**
  * Copyright (C) 2013 Steven Barth <steven@midlink.org>

+ * Copyright (C) 2016 Hans Dedecker <dedeckeh@gmail.com>

  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License v2 as published by
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License v2 as published by


@@ -16,48 +17,51 @@
 #include "dhcpv6.h"
 #include "dhcpv4.h"
 #include "libubox/md5.h"
 #include "dhcpv6.h"
 #include "dhcpv4.h"
 #include "libubox/md5.h"

+#include "libubox/usock.h"

 
 #include <time.h>
 #include <errno.h>
 #include <fcntl.h>
 
 #include <time.h>
 #include <errno.h>
 #include <fcntl.h>

+#include <stdio.h>
+#include <poll.h>

 #include <alloca.h>
 #include <resolv.h>
 #include <limits.h>
 #include <stdlib.h>
 #include <alloca.h>
 #include <resolv.h>
 #include <limits.h>
 #include <stdlib.h>

+#include <string.h>

 #include <unistd.h>
 #include <unistd.h>

+#include <stdbool.h>

 #include <arpa/inet.h>
 #include <sys/timerfd.h>
 
 #include <arpa/inet.h>
 #include <sys/timerfd.h>
 

+#define ADDR_ENTRY_VALID_IA_ADDR(iface, i, m, addrs) \
+    ((iface)->managed == RELAYD_MANAGED_NO_AFLAG || (i) == (m) || \
+     (addrs)[(i)].prefix > 64)

 
 

-static void update(struct interface *iface);
+static void free_dhcpv6_assignment(struct dhcpv6_assignment *c);

 static void reconf_timer(struct uloop_timeout *event);
 static struct uloop_timeout reconf_event = {.cb = reconf_timer};
 static void reconf_timer(struct uloop_timeout *event);
 static struct uloop_timeout reconf_event = {.cb = reconf_timer};

-static int socket_fd = -1;

 static uint32_t serial = 0;
 static uint32_t serial = 0;

+static uint8_t statemd5[16];

 
 

-
-int dhcpv6_ia_init(int dhcpv6_socket)
+int dhcpv6_ia_init(void)

 {
 {

-       socket_fd = dhcpv6_socket;

        uloop_timeout_set(&reconf_event, 2000);
        return 0;
 }
 
        uloop_timeout_set(&reconf_event, 2000);
        return 0;
 }
 

-

 int setup_dhcpv6_ia_interface(struct interface *iface, bool enable)
 {
        if (!enable && iface->ia_assignments.next) {
                struct dhcpv6_assignment *c;
 int setup_dhcpv6_ia_interface(struct interface *iface, bool enable)
 {
        if (!enable && iface->ia_assignments.next) {
                struct dhcpv6_assignment *c;

+

                while (!list_empty(&iface->ia_assignments)) {
                        c = list_first_entry(&iface->ia_assignments, struct dhcpv6_assignment, head);
                while (!list_empty(&iface->ia_assignments)) {
                        c = list_first_entry(&iface->ia_assignments, struct dhcpv6_assignment, head);

-                       list_del(&c->head);
-                       free(c->hostname);
-                       free(c->classes);
-                       free(c);
+                       free_dhcpv6_assignment(c);

                }
        }
 
                }
        }
 

-       if (iface->dhcpv6 == RELAYD_SERVER) {
+       if (enable && iface->dhcpv6 == RELAYD_SERVER) {

                if (!iface->ia_assignments.next)
                        INIT_LIST_HEAD(&iface->ia_assignments);
 
                if (!iface->ia_assignments.next)
                        INIT_LIST_HEAD(&iface->ia_assignments);
 


@@ -67,25 +71,26 @@ int setup_dhcpv6_ia_interface(struct interface *iface, bool enable)
                                syslog(LOG_ERR, "Calloc failed for border on interface %s", iface->ifname);
                                return -1;
                        }
                                syslog(LOG_ERR, "Calloc failed for border on interface %s", iface->ifname);
                                return -1;
                        }

-                       
+

                        border->length = 64;
                        list_add(&border->head, &iface->ia_assignments);
                }
 
                        border->length = 64;
                        list_add(&border->head, &iface->ia_assignments);
                }
 

-               update(iface);
-
-               // Parse static entries
+               /* Parse static entries */

                struct lease *lease;
                list_for_each_entry(lease, &leases, head) {
                struct lease *lease;
                list_for_each_entry(lease, &leases, head) {

-                       // Construct entry
-                       struct dhcpv6_assignment *a = calloc(1, sizeof(*a) + lease->duid_len);
+                       /* Construct entry */
+                       size_t duid_len = lease->duid_len ? lease->duid_len : 14;
+                       struct dhcpv6_assignment *a = calloc(1, sizeof(*a) + duid_len);

                        if (!a) {
                                syslog(LOG_ERR, "Calloc failed for static lease assignment on interface %s",
                                        iface->ifname);
                                return -1;
                        }
 
                        if (!a) {
                                syslog(LOG_ERR, "Calloc failed for static lease assignment on interface %s",
                                        iface->ifname);
                                return -1;
                        }
 

-                       a->clid_len = lease->duid_len;
+                       a->leasetime = lease->dhcpv4_leasetime;
+
+                       a->clid_len = duid_len;

                        a->length = 128;
                        if (lease->hostid) {
                                a->assigned = lease->hostid;
                        a->length = 128;
                        if (lease->hostid) {
                                a->assigned = lease->hostid;


@@ -93,19 +98,24 @@ int setup_dhcpv6_ia_interface(struct interface *iface, bool enable)
                                uint32_t i4a = ntohl(lease->ipaddr.s_addr) & 0xff;
                                a->assigned = ((i4a / 100) << 8) | (((i4a % 100) / 10) << 4) | (i4a % 10);
                        }
                                uint32_t i4a = ntohl(lease->ipaddr.s_addr) & 0xff;
                                a->assigned = ((i4a / 100) << 8) | (((i4a % 100) / 10) << 4) | (i4a % 10);
                        }

+

                        odhcpd_urandom(a->key, sizeof(a->key));
                        odhcpd_urandom(a->key, sizeof(a->key));

-                       memcpy(a->clid_data, lease->duid, a->clid_len);
+                       memcpy(a->clid_data, lease->duid, lease->duid_len);

                        memcpy(a->mac, lease->mac.ether_addr_octet, sizeof(a->mac));
                        memcpy(a->mac, lease->mac.ether_addr_octet, sizeof(a->mac));

+                       /* Static assignment */
+                       a->flags |= OAF_STATIC;
+                       /* Infinite valid */
+                       a->valid_until = 0;

 
 

-                       // Assign to all interfaces
+                       /* Assign to all interfaces */

                        struct dhcpv6_assignment *c;
                        list_for_each_entry(c, &iface->ia_assignments, head) {
                                if (c->length != 128 || c->assigned > a->assigned) {
                                        list_add_tail(&a->head, &c->head);
                        struct dhcpv6_assignment *c;
                        list_for_each_entry(c, &iface->ia_assignments, head) {
                                if (c->length != 128 || c->assigned > a->assigned) {
                                        list_add_tail(&a->head, &c->head);

-                               } else if (c->assigned == a->assigned) {
-                                       // Already an assignment with that number

                                        break;
                                        break;

-                               }
+                               } else if (c->assigned == a->assigned)
+                                       /* Already an assignment with that number */
+                                       break;

                        }
 
                        if (a->head.next) {
                        }
 
                        if (a->head.next) {


@@ -113,16 +123,51 @@ int setup_dhcpv6_ia_interface(struct interface *iface, bool enable)
                                        free(a->hostname);
                                        a->hostname = strdup(lease->hostname);
                                }
                                        free(a->hostname);
                                        a->hostname = strdup(lease->hostname);
                                }

-                       } else {
-                               free(a->classes);
-                               free(a->hostname);
-                               free(a);
-                       }
+                       } else
+                               free_dhcpv6_assignment(a);

                }
        }
        return 0;
 }
 
                }
        }
        return 0;
 }
 

+static void free_dhcpv6_assignment(struct dhcpv6_assignment *c)
+{
+       if (c->managed_sock.fd.registered) {
+               ustream_free(&c->managed_sock.stream);
+               close(c->managed_sock.fd.fd);
+       }
+
+       if (c->head.next)
+               list_del(&c->head);
+
+       free(c->managed);
+       free(c->hostname);
+       free(c);
+}
+
+static inline bool valid_prefix_length(const struct dhcpv6_assignment *a, const uint8_t prefix_length)
+{
+       return (a->managed_size || a->length > prefix_length);
+}
+
+static inline bool valid_addr(const struct odhcpd_ipaddr *addr, time_t now)
+{
+       return (addr->prefix <= 96 && addr->preferred > (uint32_t)now);
+}
+
+static size_t get_preferred_addr(const struct odhcpd_ipaddr *addrs, const size_t addrlen)
+{
+       size_t i, m;
+
+       for (i = 0, m = 0; i < addrlen; ++i) {
+               if (addrs[i].preferred > addrs[m].preferred ||
+                               (addrs[i].preferred == addrs[m].preferred &&
+                               memcmp(&addrs[i].addr, &addrs[m].addr, 16) > 0))
+                       m = i;
+       }
+
+       return m;
+}

 
 static int send_reconf(struct interface *iface, struct dhcpv6_assignment *assign)
 {
 
 static int send_reconf(struct interface *iface, struct dhcpv6_assignment *assign)
 {


@@ -162,8 +207,9 @@ static int send_reconf(struct interface *iface, struct dhcpv6_assignment *assign
        struct iovec iov = {&reconf_msg, sizeof(reconf_msg) - 128 + assign->clid_len};
 
        md5_ctx_t md5;
        struct iovec iov = {&reconf_msg, sizeof(reconf_msg) - 128 + assign->clid_len};
 
        md5_ctx_t md5;

-       uint8_t secretbytes[16];
-       memcpy(secretbytes, assign->key, sizeof(secretbytes));
+       uint8_t secretbytes[64];
+       memset(secretbytes, 0, sizeof(secretbytes));
+       memcpy(secretbytes, assign->key, sizeof(assign->key));

 
        for (size_t i = 0; i < sizeof(secretbytes); ++i)
                secretbytes[i] ^= 0x36;
 
        for (size_t i = 0; i < sizeof(secretbytes); ++i)
                secretbytes[i] ^= 0x36;


@@ -183,106 +229,202 @@ static int send_reconf(struct interface *iface, struct dhcpv6_assignment *assign
        md5_hash(reconf_msg.auth.key, 16, &md5);
        md5_end(reconf_msg.auth.key, &md5);
 
        md5_hash(reconf_msg.auth.key, 16, &md5);
        md5_end(reconf_msg.auth.key, &md5);
 

-       return odhcpd_send(socket_fd, &assign->peer, &iov, 1, iface);
+       return odhcpd_send(iface->dhcpv6_event.uloop.fd, &assign->peer, &iov, 1, iface);

 }
 
 }
 

+void dhcpv6_enum_ia_addrs(struct interface *iface, struct dhcpv6_assignment *c,
+                               time_t now, dhcpv6_binding_cb_handler_t func, void *arg)
+{
+       struct odhcpd_ipaddr *addrs = (c->managed) ? c->managed : iface->ia_addr;
+       size_t addrlen = (c->managed) ? (size_t)c->managed_size : iface->ia_addr_len;
+       size_t m = get_preferred_addr(addrs, addrlen);
+
+       for (size_t i = 0; i < addrlen; ++i) {
+               struct in6_addr addr;
+               uint32_t pref, valid;
+               int prefix = c->managed ? addrs[i].prefix : c->length;
+
+               if (!valid_addr(&addrs[i], now))
+                       continue;
+
+               addr = addrs[i].addr;
+               pref = addrs[i].preferred;
+               valid = addrs[i].valid;
+               if (prefix == 128) {
+                       if (!ADDR_ENTRY_VALID_IA_ADDR(iface, i, m, addrs))
+                               continue;
+
+                       addr.s6_addr32[3] = htonl(c->assigned);
+               } else {
+                       if (!valid_prefix_length(c, addrs[i].prefix))
+                               continue;
+
+                       addr.s6_addr32[1] |= htonl(c->assigned);
+                       addr.s6_addr32[2] = addr.s6_addr32[3] = 0;
+               }
+
+               if (pref != UINT32_MAX)
+                       pref -= now;
+
+               if (valid != UINT32_MAX)
+                       valid -= now;
+
+               func(&addr, prefix, pref, valid, arg);
+       }
+}
+
+struct write_ctxt {
+       FILE *fp;
+       md5_ctx_t md5;
+       struct dhcpv6_assignment *c;
+       struct interface *iface;
+       char *buf;
+       int buf_len;
+       int buf_idx;
+};
+
+void dhcpv6_write_ia_addr(struct in6_addr *addr, int prefix, _unused uint32_t pref,
+                               _unused uint32_t valid, void *arg)
+{
+       struct write_ctxt *ctxt = (struct write_ctxt *)arg;
+       char ipbuf[INET6_ADDRSTRLEN];
+
+       inet_ntop(AF_INET6, addr, ipbuf, sizeof(ipbuf) - 1);
+
+       if (ctxt->c->length == 128 && ctxt->c->hostname) {
+               fputs(ipbuf, ctxt->fp);
+
+               char b[256];
+               if (dn_expand(ctxt->iface->search, ctxt->iface->search + ctxt->iface->search_len,
+                               ctxt->iface->search, b, sizeof(b)) > 0)
+                       fprintf(ctxt->fp, "\t%s.%s", ctxt->c->hostname, b);
+
+               fprintf(ctxt->fp, "\t%s\n", ctxt->c->hostname);
+               md5_hash(ipbuf, strlen(ipbuf), &ctxt->md5);
+               md5_hash(ctxt->c->hostname, strlen(ctxt->c->hostname), &ctxt->md5);
+       }
+
+       ctxt->buf_idx += snprintf(ctxt->buf + ctxt->buf_idx,ctxt->buf_len - ctxt->buf_idx,
+                                       "%s/%d ", ipbuf, prefix);
+}

 
 void dhcpv6_write_statefile(void)
 {
 
 void dhcpv6_write_statefile(void)
 {

+       struct write_ctxt ctxt;
+
+       md5_begin(&ctxt.md5);
+

        if (config.dhcp_statefile) {
                time_t now = odhcpd_time(), wall_time = time(NULL);
                int fd = open(config.dhcp_statefile, O_CREAT | O_WRONLY | O_CLOEXEC, 0644);
        if (config.dhcp_statefile) {
                time_t now = odhcpd_time(), wall_time = time(NULL);
                int fd = open(config.dhcp_statefile, O_CREAT | O_WRONLY | O_CLOEXEC, 0644);

+               char leasebuf[512];
+

                if (fd < 0)
                        return;
                if (fd < 0)
                        return;

+               int ret;
+               ret = lockf(fd, F_LOCK, 0);
+               if (ret < 0) {
+                       close(fd);
+                       return;
+               }
+               if (ftruncate(fd, 0) < 0) {}

 
 

-               lockf(fd, F_LOCK, 0);
-               ftruncate(fd, 0);
-
-               FILE *fp = fdopen(fd, "w");
-               if (!fp) {
+               ctxt.fp = fdopen(fd, "w");
+               if (!ctxt.fp) {

                        close(fd);
                        return;
                }
 
                        close(fd);
                        return;
                }
 

-               struct interface *iface;
-               list_for_each_entry(iface, &interfaces, head) {
-                       if (iface->dhcpv6 != RELAYD_SERVER && iface->dhcpv4 != RELAYD_SERVER)
+               ctxt.buf = leasebuf;
+               ctxt.buf_len = sizeof(leasebuf);
+
+               list_for_each_entry(ctxt.iface, &interfaces, head) {
+                       if (ctxt.iface->dhcpv6 != RELAYD_SERVER &&
+                                       ctxt.iface->dhcpv4 != RELAYD_SERVER)

                                continue;
 
                                continue;
 

-                       if (iface->dhcpv6 == RELAYD_SERVER) {
-                               struct dhcpv6_assignment *c;
-                               list_for_each_entry(c, &iface->ia_assignments, head) {
-                                       if (c->clid_len == 0)
+                       if (ctxt.iface->dhcpv6 == RELAYD_SERVER &&
+                                       ctxt.iface->ia_assignments.next) {
+                               list_for_each_entry(ctxt.c, &ctxt.iface->ia_assignments, head) {
+                                       if (!(ctxt.c->flags & OAF_BOUND) || ctxt.c->managed_size < 0)

                                                continue;
 
                                                continue;
 

-                                       char ipbuf[INET6_ADDRSTRLEN];
-                                       char leasebuf[512];

                                        char duidbuf[264];
                                        char duidbuf[264];

-                                       odhcpd_hexlify(duidbuf, c->clid_data, c->clid_len);
-
-                                       // iface DUID iaid hostname lifetime assigned length [addrs...]
-                                       int l = snprintf(leasebuf, sizeof(leasebuf), "# %s %s %x %s %u %x %u ",
-                                                       iface->ifname, duidbuf, ntohl(c->iaid),
-                                                       (c->hostname ? c->hostname : "-"),
-                                                       (unsigned)(c->valid_until > now ?
-                                                                       (c->valid_until - now + wall_time) : 0),
-                                                       c->assigned, (unsigned)c->length);
-
-                                       struct in6_addr addr;
-                                       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
-                                               if (iface->ia_addr[i].prefix > 64)
-                                                       continue;

 
 

-                                               addr = iface->ia_addr[i].addr;
-                                               if (c->length == 128)
-                                                       addr.s6_addr32[3] = htonl(c->assigned);
-                                               else
-                                                       addr.s6_addr32[1] |= htonl(c->assigned);
-                                               inet_ntop(AF_INET6, &addr, ipbuf, sizeof(ipbuf) - 1);
+                                       odhcpd_hexlify(duidbuf, ctxt.c->clid_data, ctxt.c->clid_len);

 
 

-                                               if (c->length == 128 && c->hostname && i == 0)
-                                                       fprintf(fp, "%s\t%s\n", ipbuf, c->hostname);
+                                       /* iface DUID iaid hostname lifetime assigned length [addrs...] */
+                                       ctxt.buf_idx = snprintf(ctxt.buf, ctxt.buf_len, "# %s %s %x %s %ld %x %u ",
+                                                               ctxt.iface->ifname, duidbuf, ntohl(ctxt.c->iaid),
+                                                               (ctxt.c->hostname ? ctxt.c->hostname : "-"),
+                                                               (ctxt.c->valid_until > now ?
+                                                                       (ctxt.c->valid_until - now + wall_time) :
+                                                                       (INFINITE_VALID(ctxt.c->valid_until) ? -1 : 0)),
+                                                               ctxt.c->assigned, (unsigned)ctxt.c->length);

 
 

-                                               l += snprintf(leasebuf + l, sizeof(leasebuf) - l, "%s/%hhu ", ipbuf, c->length);
-                                       }
-                                       leasebuf[l - 1] = '\n';
-                                       fwrite(leasebuf, 1, l, fp);
+                                       if (INFINITE_VALID(ctxt.c->valid_until) || ctxt.c->valid_until > now)
+                                               dhcpv6_enum_ia_addrs(ctxt.iface, ctxt.c, now,
+                                                                       dhcpv6_write_ia_addr, &ctxt);
+
+                                       ctxt.buf[ctxt.buf_idx - 1] = '\n';
+                                       fwrite(ctxt.buf, 1, ctxt.buf_idx, ctxt.fp);

                                }
                        }
 
                                }
                        }
 

-                       if (iface->dhcpv4 == RELAYD_SERVER) {
+                       if (ctxt.iface->dhcpv4 == RELAYD_SERVER &&
+                                       ctxt.iface->dhcpv4_assignments.next) {

                                struct dhcpv4_assignment *c;
                                struct dhcpv4_assignment *c;

-                               list_for_each_entry(c, &iface->dhcpv4_assignments, head) {
+                               list_for_each_entry(c, &ctxt.iface->dhcpv4_assignments, head) {
+                                       if (!(c->flags & OAF_BOUND))
+                                               continue;
+

                                        char ipbuf[INET6_ADDRSTRLEN];
                                        char ipbuf[INET6_ADDRSTRLEN];

-                                       char leasebuf[512];

                                        char duidbuf[16];
                                        odhcpd_hexlify(duidbuf, c->hwaddr, sizeof(c->hwaddr));
 
                                        char duidbuf[16];
                                        odhcpd_hexlify(duidbuf, c->hwaddr, sizeof(c->hwaddr));
 

-                                       // iface DUID iaid hostname lifetime assigned length [addrs...]
-                                       int l = snprintf(leasebuf, sizeof(leasebuf), "# %s %s ipv4 %s %u %x 32 ",
-                                                       iface->ifname, duidbuf,
-                                                       (c->hostname ? c->hostname : "-"),
-                                                       (unsigned)(c->valid_until > now ?
-                                                                       (c->valid_until - now + wall_time) : 0),
-                                                       c->addr);
+                                       /* iface DUID iaid hostname lifetime assigned length [addrs...] */
+                                       ctxt.buf_idx = snprintf(ctxt.buf, ctxt.buf_len, "# %s %s ipv4 %s %ld %x 32 ",
+                                                               ctxt.iface->ifname, duidbuf,
+                                                               (c->hostname ? c->hostname : "-"),
+                                                               (c->valid_until > now ?
+                                                                       (c->valid_until - now + wall_time) :
+                                                                       (INFINITE_VALID(c->valid_until) ? -1 : 0)),
+                                                               c->addr);

 
                                        struct in_addr addr = {htonl(c->addr)};
                                        inet_ntop(AF_INET, &addr, ipbuf, sizeof(ipbuf) - 1);
 
 
                                        struct in_addr addr = {htonl(c->addr)};
                                        inet_ntop(AF_INET, &addr, ipbuf, sizeof(ipbuf) - 1);
 

-                                       if (c->hostname[0])
-                                               fprintf(fp, "%s\t%s\n", ipbuf, c->hostname);
+                                       if (c->hostname) {
+                                               fputs(ipbuf, ctxt.fp);
+
+                                               char b[256];
+                                               if (dn_expand(ctxt.iface->search,
+                                                               ctxt.iface->search + ctxt.iface->search_len,
+                                                               ctxt.iface->search, b, sizeof(b)) > 0)
+                                                       fprintf(ctxt.fp, "\t%s.%s", c->hostname, b);

 
 

-                                       l += snprintf(leasebuf + l, sizeof(leasebuf) - l, "%s/32 ", ipbuf);
-                                       leasebuf[l - 1] = '\n';
-                                       fwrite(leasebuf, 1, l, fp);
+                                               fprintf(ctxt.fp, "\t%s\n", c->hostname);
+                                               md5_hash(ipbuf, strlen(ipbuf), &ctxt.md5);
+                                               md5_hash(c->hostname, strlen(c->hostname), &ctxt.md5);
+                                       }
+
+                                       ctxt.buf_idx += snprintf(ctxt.buf + ctxt.buf_idx,
+                                                                       ctxt.buf_len - ctxt.buf_idx,
+                                                                       "%s/32 ", ipbuf);
+                                       ctxt.buf[ctxt.buf_idx - 1] = '\n';
+                                       fwrite(ctxt.buf, 1, ctxt.buf_idx, ctxt.fp);

                                }
                        }
                }
 
                                }
                        }
                }
 

-               fclose(fp);
+               fclose(ctxt.fp);

        }
 
        }
 

-       if (config.dhcp_cb) {
+       uint8_t newmd5[16];
+       md5_end(newmd5, &ctxt.md5);
+
+       if (config.dhcp_cb && memcmp(newmd5, statemd5, sizeof(newmd5))) {
+               memcpy(statemd5, newmd5, sizeof(statemd5));

                char *argv[2] = {config.dhcp_cb, NULL};
                if (!vfork()) {
                        execv(argv[0], argv);
                char *argv[2] = {config.dhcp_cb, NULL};
                if (!vfork()) {
                        execv(argv[0], argv);


@@ -294,33 +436,155 @@ void dhcpv6_write_statefile(void)
 
 static void apply_lease(struct interface *iface, struct dhcpv6_assignment *a, bool add)
 {
 
 static void apply_lease(struct interface *iface, struct dhcpv6_assignment *a, bool add)
 {

-       if (a->length > 64)
+       if (a->length > 64 || a->managed_size < 0)

                return;
 
                return;
 

-       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
-               struct in6_addr prefix = iface->ia_addr[i].addr;
+       struct odhcpd_ipaddr *addrs = (a->managed) ? a->managed : iface->ia_addr;
+       size_t addrlen = (a->managed) ? (size_t)a->managed_size : iface->ia_addr_len;
+
+       for (size_t i = 0; i < addrlen; ++i) {
+               struct in6_addr prefix = addrs[i].addr;

                prefix.s6_addr32[1] |= htonl(a->assigned);
                prefix.s6_addr32[1] |= htonl(a->assigned);

-               odhcpd_setup_route(&prefix, a->length, iface, &a->peer.sin6_addr, add);
+               prefix.s6_addr32[2] = prefix.s6_addr32[3] = 0;
+               odhcpd_setup_route(&prefix, (a->managed_size) ? addrs[i].prefix : a->length,
+                               iface, &a->peer.sin6_addr, 1024, add);

        }
 }
 
        }
 }
 

+/* More data was received from TCP connection */
+static void managed_handle_pd_data(struct ustream *s, _unused int bytes_new)
+{
+       struct dhcpv6_assignment *c = container_of(s, struct dhcpv6_assignment, managed_sock);
+       time_t now = odhcpd_time();
+       bool first = c->managed_size < 0;
+
+       for (;;) {
+               int pending;
+               char *data = ustream_get_read_buf(s, &pending);
+               char *end = memmem(data, pending, "\n\n", 2);
+
+               if (!end)
+                       break;
+
+               end += 2;
+               end[-1] = 0;
+
+               c->managed_size = 0;
+               if (c->accept_reconf)
+                       c->reconf_cnt = 1;
+
+               char *saveptr;
+               for (char *line = strtok_r(data, "\n", &saveptr); line; line = strtok_r(NULL, "\n", &saveptr)) {
+                       c->managed = realloc(c->managed, (c->managed_size + 1) * sizeof(*c->managed));
+                       struct odhcpd_ipaddr *n = &c->managed[c->managed_size];
+
+                       char *saveptr2, *x = strtok_r(line, "/", &saveptr2);
+                       if (!x || inet_pton(AF_INET6, x, &n->addr) < 1)
+                               continue;
+
+                       x = strtok_r(NULL, ",", &saveptr2);
+                       if (sscanf(x, "%hhu", &n->prefix) < 1)
+                               continue;
+
+                       x = strtok_r(NULL, ",", &saveptr2);
+                       if (sscanf(x, "%u", &n->preferred) < 1)
+                               continue;
+
+                       x = strtok_r(NULL, ",", &saveptr2);
+                       if (sscanf(x, "%u", &n->valid) < 1)
+                               continue;
+
+                       if (n->preferred > n->valid)
+                               continue;
+
+                       if (UINT32_MAX - now < n->preferred)
+                               n->preferred = UINT32_MAX;
+                       else
+                               n->preferred += now;
+
+                       if (UINT32_MAX - now < n->valid)
+                               n->valid = UINT32_MAX;
+                       else
+                               n->valid += now;
+
+                       n->dprefix = 0;
+
+                       ++c->managed_size;
+               }
+
+               ustream_consume(s, end - data);
+       }
+
+       if (first && c->managed_size == 0)
+               free_dhcpv6_assignment(c);
+       else if (first && !(c->flags & OAF_STATIC))
+               c->valid_until = now + 150;
+}
+
+
+/* TCP transmission has ended, either because of success or timeout or other error */
+static void managed_handle_pd_done(struct ustream *s)
+{
+       struct dhcpv6_assignment *c = container_of(s, struct dhcpv6_assignment, managed_sock);
+
+       if (!(c->flags & OAF_STATIC))
+               c->valid_until = odhcpd_time() + 15;
+
+       c->managed_size = 0;
+
+       if (c->accept_reconf)
+               c->reconf_cnt = 1;
+}

 
 static bool assign_pd(struct interface *iface, struct dhcpv6_assignment *assign)
 {
        struct dhcpv6_assignment *c;
 
 static bool assign_pd(struct interface *iface, struct dhcpv6_assignment *assign)
 {
        struct dhcpv6_assignment *c;

-       if (iface->ia_addr_len < 1)
+
+       if (iface->dhcpv6_pd_manager[0]) {
+               int fd = usock(USOCK_UNIX | USOCK_TCP, iface->dhcpv6_pd_manager, NULL);
+               if (fd >= 0) {
+                       char iaidbuf[298];
+                       odhcpd_hexlify(iaidbuf, assign->clid_data, assign->clid_len);
+
+                       assign->managed_sock.stream.notify_read = managed_handle_pd_data;
+                       assign->managed_sock.stream.notify_state = managed_handle_pd_done;
+                       ustream_fd_init(&assign->managed_sock, fd);
+                       ustream_printf(&assign->managed_sock.stream, "%s,%x\n::/%d,0,0\n\n",
+                                       iaidbuf, assign->iaid, assign->length);
+                       ustream_write_pending(&assign->managed_sock.stream);
+                       assign->managed_size = -1;
+
+                       if (!(assign->flags & OAF_STATIC))
+                               assign->valid_until = odhcpd_time() + 15;
+
+                       list_add(&assign->head, &iface->ia_assignments);
+
+                       /* Wait initial period of up to 250ms for immediate assignment */
+                       struct pollfd pfd = { .fd = fd, .events = POLLIN };
+                       poll(&pfd, 1, 250);
+                       managed_handle_pd_data(&assign->managed_sock.stream, 0);
+
+                       if (fcntl(fd, F_GETFL) >= 0 && assign->managed_size > 0)
+                               return true;
+               }
+
+               return false;
+       } else if (iface->ia_addr_len < 1)

                return false;
 
                return false;
 

-       // Try honoring the hint first
+       /* Try honoring the hint first */

        uint32_t current = 1, asize = (1 << (64 - assign->length)) - 1;
        if (assign->assigned) {
                list_for_each_entry(c, &iface->ia_assignments, head) {
        uint32_t current = 1, asize = (1 << (64 - assign->length)) - 1;
        if (assign->assigned) {
                list_for_each_entry(c, &iface->ia_assignments, head) {

-                       if (c->length == 128)
+                       if (c->length == 128 || c->length == 0)

                                continue;
 
                        if (assign->assigned >= current && assign->assigned + asize < c->assigned) {
                                list_add_tail(&assign->head, &c->head);
                                continue;
 
                        if (assign->assigned >= current && assign->assigned + asize < c->assigned) {
                                list_add_tail(&assign->head, &c->head);

-                               apply_lease(iface, assign, true);
+
+                               if (assign->flags & OAF_BOUND)
+                                       apply_lease(iface, assign, true);
+

                                return true;
                        }
 
                                return true;
                        }
 


@@ -329,17 +593,20 @@ static bool assign_pd(struct interface *iface, struct dhcpv6_assignment *assign)
                }
        }
 
                }
        }
 

-       // Fallback to a variable assignment
+       /* Fallback to a variable assignment */

        current = 1;
        list_for_each_entry(c, &iface->ia_assignments, head) {
        current = 1;
        list_for_each_entry(c, &iface->ia_assignments, head) {

-               if (c->length == 128)
+               if (c->length == 128 || c->length == 0)

                        continue;
 
                current = (current + asize) & (~asize);
                if (current + asize < c->assigned) {
                        assign->assigned = current;
                        list_add_tail(&assign->head, &c->head);
                        continue;
 
                current = (current + asize) & (~asize);
                if (current + asize < c->assigned) {
                        assign->assigned = current;
                        list_add_tail(&assign->head, &c->head);

-                       apply_lease(iface, assign, true);
+
+                       if (assign->flags & OAF_BOUND)
+                               apply_lease(iface, assign, true);
+

                        return true;
                }
 
                        return true;
                }
 


@@ -350,151 +617,107 @@ static bool assign_pd(struct interface *iface, struct dhcpv6_assignment *assign)
        return false;
 }
 
        return false;
 }
 

-

 static bool assign_na(struct interface *iface, struct dhcpv6_assignment *assign)
 {
 static bool assign_na(struct interface *iface, struct dhcpv6_assignment *assign)
 {

-       bool match = false;
-       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
-               if (!iface->ia_addr[i].has_class) {
-                       match = true;
-                       continue;
-               } else if (assign->classes_cnt) {
-                       for (size_t j = 0; j < assign->classes_cnt; ++j)
-                               if (assign->classes[j] == iface->ia_addr[i].class)
-                                       match = true;
-               } else if (assign->all_class) {
-                       match = true;
-               }
-       }
-
-       if (!match)
-               return false;
-
-       // Seed RNG with checksum of DUID
+       /* Seed RNG with checksum of DUID */

        uint32_t seed = 0;
        for (size_t i = 0; i < assign->clid_len; ++i)
                seed += assign->clid_data[i];
        srand(seed);
 
        uint32_t seed = 0;
        for (size_t i = 0; i < assign->clid_len; ++i)
                seed += assign->clid_data[i];
        srand(seed);
 

-       // Try to assign up to 100x
+       /* Try to assign up to 100x */

        for (size_t i = 0; i < 100; ++i) {
                uint32_t try;
                do try = ((uint32_t)rand()) % 0x0fff; while (try < 0x100);
 
                struct dhcpv6_assignment *c;
                list_for_each_entry(c, &iface->ia_assignments, head) {
        for (size_t i = 0; i < 100; ++i) {
                uint32_t try;
                do try = ((uint32_t)rand()) % 0x0fff; while (try < 0x100);
 
                struct dhcpv6_assignment *c;
                list_for_each_entry(c, &iface->ia_assignments, head) {

+                       if (c->length == 0)
+                               continue;
+

                        if (c->assigned > try || c->length != 128) {
                                assign->assigned = try;
                                list_add_tail(&assign->head, &c->head);
                                return true;
                        if (c->assigned > try || c->length != 128) {
                                assign->assigned = try;
                                list_add_tail(&assign->head, &c->head);
                                return true;

-                       } else if (c->assigned == try) {
+                       } else if (c->assigned == try)

                                break;
                                break;

-                       }

                }
        }
 
        return false;
 }
 
                }
        }
 
        return false;
 }
 

-
-static int prefixcmp(const void *va, const void *vb)
+void dhcpv6_ia_preupdate(struct interface *iface)

 {
 {

-       const struct odhcpd_ipaddr *a = va, *b = vb;
-       uint32_t a_pref = ((a->addr.s6_addr[0] & 0xfe) != 0xfc) ? a->preferred : 1;
-       uint32_t b_pref = ((b->addr.s6_addr[0] & 0xfe) != 0xfc) ? b->preferred : 1;
-       return (a_pref < b_pref) ? 1 : (a_pref > b_pref) ? -1 : 0;
-}
+       if (iface->dhcpv6 != RELAYD_SERVER)
+               return;

 
 

+       struct dhcpv6_assignment *c, *border = list_last_entry(
+                       &iface->ia_assignments, struct dhcpv6_assignment, head);

 
 

-static void update(struct interface *iface)
-{
-       struct odhcpd_ipaddr addr[8];
-       memset(addr, 0, sizeof(addr));
-       int len = odhcpd_get_interface_addresses(iface->ifindex, addr, 8);
+       list_for_each_entry(c, &iface->ia_assignments, head)
+               if (c != border && !iface->managed && (c->flags & OAF_BOUND))
+                       apply_lease(iface, c, false);
+}

 
 

-       if (len < 0)
+void dhcpv6_ia_postupdate(struct interface *iface, time_t now)
+{
+       if (iface->dhcpv6 != RELAYD_SERVER)

                return;
 
                return;
 

-       qsort(addr, len, sizeof(*addr), prefixcmp);
-
-       time_t now = odhcpd_time();

        int minprefix = -1;
        int minprefix = -1;

-
-       for (int i = 0; i < len; ++i) {
-               if (addr[i].prefix > minprefix)
-                       minprefix = addr[i].prefix;
-
-               addr[i].addr.s6_addr32[2] = 0;
-               addr[i].addr.s6_addr32[3] = 0;
-
-               if (addr[i].preferred < UINT32_MAX - now)
-                       addr[i].preferred += now;
-
-               if (addr[i].valid < UINT32_MAX - now)
-                       addr[i].valid += now;
+       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
+               if (iface->ia_addr[i].preferred > (uint32_t)now &&
+                               iface->ia_addr[i].prefix < 64 &&
+                               iface->ia_addr[i].prefix > minprefix)
+                       minprefix = iface->ia_addr[i].prefix;

        }
 
        }
 

-       struct dhcpv6_assignment *border = list_last_entry(&iface->ia_assignments, struct dhcpv6_assignment, head);
-       border->assigned = 1 << (64 - minprefix);
-
-       bool change = len != (int)iface->ia_addr_len;
-       for (int i = 0; !change && i < len; ++i)
-               if (addr[i].addr.s6_addr32[0] != iface->ia_addr[i].addr.s6_addr32[0] ||
-                               addr[i].addr.s6_addr32[1] != iface->ia_addr[i].addr.s6_addr32[1] ||
-                               (addr[i].preferred > 0) != (iface->ia_addr[i].preferred > 0) ||
-                               (addr[i].valid > (uint32_t)now + 7200) !=
-                                               (iface->ia_addr[i].valid > (uint32_t)now + 7200))
-                       change = true;
+       struct dhcpv6_assignment *border = list_last_entry(
+                       &iface->ia_assignments, struct dhcpv6_assignment, head);

 
 

-       if (change) {
-               struct dhcpv6_assignment *c;
-               list_for_each_entry(c, &iface->ia_assignments, head)
-                       if (c != border)
-                               apply_lease(iface, c, false);
-       }
+       if (minprefix > 32 && minprefix <= 64)
+               border->assigned = 1U << (64 - minprefix);
+       else
+               border->assigned = 0;

 
 

-       memcpy(iface->ia_addr, addr, len * sizeof(*addr));
-       iface->ia_addr_len = len;
-
-       if (change) { // Addresses / prefixes have changed
-               struct list_head reassign = LIST_HEAD_INIT(reassign);
-               struct dhcpv6_assignment *c, *d;
-               list_for_each_entry_safe(c, d, &iface->ia_assignments, head) {
-                       if (c->clid_len == 0 || c->valid_until < now)
-                               continue;
+       struct list_head reassign = LIST_HEAD_INIT(reassign);
+       struct dhcpv6_assignment *c, *d;
+       list_for_each_entry_safe(c, d, &iface->ia_assignments, head) {
+               if (c->clid_len == 0 || (!INFINITE_VALID(c->valid_until) && c->valid_until < now) ||
+                               c->managed_size)
+                       continue;

 
 

-                       if (c->length < 128 && c->assigned >= border->assigned && c != border)
-                               list_move(&c->head, &reassign);
-                       else if (c != border)
-                               apply_lease(iface, c, true);
-
-                       if (c->accept_reconf && c->reconf_cnt == 0) {
-                               c->reconf_cnt = 1;
-                               c->reconf_sent = now;
-                               send_reconf(iface, c);
-
-                               // Leave all other assignments of that client alone
-                               struct dhcpv6_assignment *a;
-                               list_for_each_entry(a, &iface->ia_assignments, head)
-                                       if (a != c && a->clid_len == c->clid_len &&
-                                                       !memcmp(a->clid_data, c->clid_data, a->clid_len))
-                                               c->reconf_cnt = INT_MAX;
-                       }
+               if (c->length < 128 && c->assigned >= border->assigned && c != border)
+                       list_move(&c->head, &reassign);
+               else if (c != border && (c->flags & OAF_BOUND))
+                       apply_lease(iface, c, true);
+
+               if (c->accept_reconf && c->reconf_cnt == 0) {
+                       c->reconf_cnt = 1;
+                       c->reconf_sent = now;
+                       send_reconf(iface, c);
+
+                       /* Leave all other assignments of that client alone */
+                       struct dhcpv6_assignment *a;
+                       list_for_each_entry(a, &iface->ia_assignments, head)
+                               if (a != c && a->clid_len == c->clid_len &&
+                                               !memcmp(a->clid_data, c->clid_data, a->clid_len))
+                                       c->reconf_cnt = INT_MAX;

                }
                }

+       }

 
 

-               while (!list_empty(&reassign)) {
-                       c = list_first_entry(&reassign, struct dhcpv6_assignment, head);
-                       list_del(&c->head);
-                       if (!assign_pd(iface, c)) {
-                               c->assigned = 0;
-                               list_add(&c->head, &iface->ia_assignments);
-                       }
+       while (!list_empty(&reassign)) {
+               c = list_first_entry(&reassign, struct dhcpv6_assignment, head);
+               list_del(&c->head);
+               if (!assign_pd(iface, c)) {
+                       c->assigned = 0;
+                       list_add(&c->head, &iface->ia_assignments);

                }
                }

-
-               dhcpv6_write_statefile();

        }
        }

-}

 
 

+       dhcpv6_write_statefile();
+}

 
 static void reconf_timer(struct uloop_timeout *event)
 {
 
 static void reconf_timer(struct uloop_timeout *event)
 {


@@ -506,14 +729,11 @@ static void reconf_timer(struct uloop_timeout *event)
 
                struct dhcpv6_assignment *a, *n;
                list_for_each_entry_safe(a, n, &iface->ia_assignments, head) {
 
                struct dhcpv6_assignment *a, *n;
                list_for_each_entry_safe(a, n, &iface->ia_assignments, head) {

-                       if (a->valid_until < now) {
+                       if (!INFINITE_VALID(a->valid_until) && a->valid_until < now) {

                                if ((a->length < 128 && a->clid_len > 0) ||
                                if ((a->length < 128 && a->clid_len > 0) ||

-                                               (a->length == 128 && a->clid_len == 0)) {
-                                       list_del(&a->head);
-                                       free(a->classes);
-                                       free(a->hostname);
-                                       free(a);
-                               }
+                                               (a->length == 128 && a->clid_len == 0))
+                                       free_dhcpv6_assignment(a);
+

                        } else if (a->reconf_cnt > 0 && a->reconf_cnt < 8 &&
                                        now > a->reconf_sent + (1 << a->reconf_cnt)) {
                                ++a->reconf_cnt;
                        } else if (a->reconf_cnt > 0 && a->reconf_cnt < 8 &&
                                        now > a->reconf_sent + (1 << a->reconf_cnt)) {
                                ++a->reconf_cnt;


@@ -521,17 +741,10 @@ static void reconf_timer(struct uloop_timeout *event)
                                send_reconf(iface, a);
                        }
                }
                                send_reconf(iface, a);
                        }
                }

-
-               if (iface->ia_reconf) {
-                       update(iface);
-                       iface->ia_reconf = false;
-               }

        }
        }

-

        uloop_timeout_set(event, 2000);
 }
 
        uloop_timeout_set(event, 2000);
 }
 

-

 static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
                const struct dhcpv6_ia_hdr *ia, struct dhcpv6_assignment *a,
                struct interface *iface, bool request)
 static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
                const struct dhcpv6_ia_hdr *ia, struct dhcpv6_assignment *a,
                struct interface *iface, bool request)


@@ -555,46 +768,31 @@ static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
                datalen += sizeof(stat);
        } else {
                if (a) {
                datalen += sizeof(stat);
        } else {
                if (a) {

-                       uint32_t pref = 3600;
-                       uint32_t valid = 3600;
-
-                       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
-                               bool match = true;
-                               if (iface->ia_addr[i].has_class) {
-                                       match = false;
-                                       if (a->classes_cnt) {
-                                               for (size_t j = 0; j < a->classes_cnt; ++j)
-                                                       if (a->classes[j] == iface->ia_addr[i].class)
-                                                               match = true;
-                                       } else if (a->all_class) {
-                                               match = true;
-                                       }
-                               }
+                       uint32_t leasetime;
+                       if (a->leasetime)
+                               leasetime = a->leasetime;
+                       else
+                               leasetime = iface->dhcpv4_leasetime;

 
 

-                               if (!match)
-                                       continue;
+                       uint32_t pref = leasetime;
+                       uint32_t valid = leasetime;

 
 

-                               uint32_t prefix_pref = iface->ia_addr[i].preferred - now;
-                               uint32_t prefix_valid = iface->ia_addr[i].valid - now;
+                       struct odhcpd_ipaddr *addrs = (a->managed) ? a->managed : iface->ia_addr;
+                       size_t addrlen = (a->managed) ? (size_t)a->managed_size : iface->ia_addr_len;
+                       size_t m = get_preferred_addr(addrs, addrlen);

 
 

-                               if (iface->ia_addr[i].prefix > 64 ||
-                                               iface->ia_addr[i].preferred <= (uint32_t)now)
-                                       continue;
+                       for (size_t i = 0; i < addrlen; ++i) {
+                               uint32_t prefix_pref = addrs[i].preferred;
+                               uint32_t prefix_valid = addrs[i].valid;

 
 

-                               if (prefix_pref > 86400)
-                                       prefix_pref = 86400;
+                               if (!valid_addr(&addrs[i], now))
+                                       continue;

 
 

-                               if (prefix_valid > 86400)
-                                       prefix_valid = 86400;
+                               if (prefix_pref != UINT32_MAX)
+                                       prefix_pref -= now;

 
 

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                               struct {
-                                       uint16_t code;
-                                       uint16_t length;
-                                       uint16_t class;
-                               } pclass = {htons(DHCPV6_OPT_PREFIX_CLASS),
-                                       htons(2), htons(iface->ia_addr[i].class)};
-#endif
+                               if (prefix_valid != UINT32_MAX)
+                                       prefix_valid -= now;

 
                                if (a->length < 128) {
                                        struct dhcpv6_ia_prefix p = {
 
                                if (a->length < 128) {
                                        struct dhcpv6_ia_prefix p = {


@@ -602,56 +800,42 @@ static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
                                                .len = htons(sizeof(p) - 4),
                                                .preferred = htonl(prefix_pref),
                                                .valid = htonl(prefix_valid),
                                                .len = htons(sizeof(p) - 4),
                                                .preferred = htonl(prefix_pref),
                                                .valid = htonl(prefix_valid),

-                                               .prefix = a->length,
-                                               .addr = iface->ia_addr[i].addr
+                                               .prefix = (a->managed_size) ? addrs[i].prefix : a->length,
+                                               .addr = addrs[i].addr

                                        };
                                        p.addr.s6_addr32[1] |= htonl(a->assigned);
                                        };
                                        p.addr.s6_addr32[1] |= htonl(a->assigned);

-                                       size_t entrlen = sizeof(p) - 4;
+                                       p.addr.s6_addr32[2] = p.addr.s6_addr32[3] = 0;

 
 

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                                       if (iface->ia_addr[i].has_class) {
-                                               entrlen += sizeof(pclass);
-                                               p.len = htons(entrlen);
-                                       }
-#endif
+                                       size_t entrlen = sizeof(p) - 4;

 
 

-                                       if (datalen + entrlen + 4 > buflen || a->assigned == 0)
+                                       if (datalen + entrlen + 4 > buflen ||
+                                                       (a->assigned == 0 && a->managed_size == 0) ||
+                                                       !valid_prefix_length(a, addrs[i].prefix))

                                                continue;
 
                                        memcpy(buf + datalen, &p, sizeof(p));
                                                continue;
 
                                        memcpy(buf + datalen, &p, sizeof(p));

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                                       memcpy(buf + datalen + sizeof(p), &pclass, sizeof(pclass));
-#endif

                                        datalen += entrlen + 4;
                                } else {
                                        struct dhcpv6_ia_addr n = {
                                                .type = htons(DHCPV6_OPT_IA_ADDR),
                                                .len = htons(sizeof(n) - 4),
                                        datalen += entrlen + 4;
                                } else {
                                        struct dhcpv6_ia_addr n = {
                                                .type = htons(DHCPV6_OPT_IA_ADDR),
                                                .len = htons(sizeof(n) - 4),

-                                               .addr = iface->ia_addr[i].addr,
+                                               .addr = addrs[i].addr,

                                                .preferred = htonl(prefix_pref),
                                                .valid = htonl(prefix_valid)
                                        };
                                        n.addr.s6_addr32[3] = htonl(a->assigned);
                                        size_t entrlen = sizeof(n) - 4;
 
                                                .preferred = htonl(prefix_pref),
                                                .valid = htonl(prefix_valid)
                                        };
                                        n.addr.s6_addr32[3] = htonl(a->assigned);
                                        size_t entrlen = sizeof(n) - 4;
 

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                                       if (iface->ia_addr[i].has_class) {
-                                               entrlen += sizeof(pclass);
-                                               n.len = htons(entrlen);
-                                       }
-#endif
-
-                                       if (datalen + entrlen + 4 > buflen || a->assigned == 0)
+                                       if (!ADDR_ENTRY_VALID_IA_ADDR(iface, i, m, addrs) ||
+                                                       a->assigned == 0 ||
+                                                       datalen + entrlen + 4 > buflen)

                                                continue;
 
                                        memcpy(buf + datalen, &n, sizeof(n));
                                                continue;
 
                                        memcpy(buf + datalen, &n, sizeof(n));

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                                       memcpy(buf + datalen + sizeof(n), &pclass, sizeof(pclass));
-#endif

                                        datalen += entrlen + 4;
                                }
 
                                        datalen += entrlen + 4;
                                }
 

-                               // Calculate T1 / T2 based on non-deprecated addresses
+                               /* Calculate T1 / T2 based on non-deprecated addresses */

                                if (prefix_pref > 0) {
                                        if (prefix_pref < pref)
                                                pref = prefix_pref;
                                if (prefix_pref > 0) {
                                        if (prefix_pref < pref)
                                                pref = prefix_pref;


@@ -661,9 +845,12 @@ static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
                                }
                        }
 
                                }
                        }
 

-                       a->valid_until = valid + now;
-                       out.t1 = htonl(pref * 5 / 10);
-                       out.t2 = htonl(pref * 8 / 10);
+                       if (!INFINITE_VALID(a->valid_until))
+                               /* UINT32_MAX is considered as infinite leasetime */
+                               a->valid_until = (valid == UINT32_MAX) ? 0 : valid + now;
+
+                       out.t1 = htonl((pref == UINT32_MAX) ? pref : pref * 5 / 10);
+                       out.t2 = htonl((pref == UINT32_MAX) ? pref : pref * 8 / 10);

 
                        if (!out.t1)
                                out.t1 = htonl(1);
 
                        if (!out.t1)
                                out.t1 = htonl(1);


@@ -684,22 +871,25 @@ static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
 
                                bool found = false;
                                if (a) {
 
                                bool found = false;
                                if (a) {

-                                       for (size_t i = 0; i < iface->ia_addr_len; ++i) {
-                                               if (iface->ia_addr[i].prefix > 64 ||
-                                                               iface->ia_addr[i].preferred <= (uint32_t)now)
+                                       struct odhcpd_ipaddr *addrs = (a->managed) ? a->managed : iface->ia_addr;
+                                       size_t addrlen = (a->managed) ? (size_t)a->managed_size : iface->ia_addr_len;
+
+                                       for (size_t i = 0; i < addrlen; ++i) {
+                                               if (!valid_addr(&addrs[i], now))

                                                        continue;
 
                                                        continue;
 

-                                               struct in6_addr addr = iface->ia_addr[i].addr;
+                                               struct in6_addr addr = addrs[i].addr;

                                                if (ia->type == htons(DHCPV6_OPT_IA_PD)) {
                                                        addr.s6_addr32[1] |= htonl(a->assigned);
                                                if (ia->type == htons(DHCPV6_OPT_IA_PD)) {
                                                        addr.s6_addr32[1] |= htonl(a->assigned);

+                                                       addr.s6_addr32[2] = addr.s6_addr32[3] = 0;

 
 

-                                                       if (IN6_ARE_ADDR_EQUAL(&p->addr, &addr) &&
-                                                                       p->prefix == a->length)
+                                                       if (!memcmp(&p->addr, &addr, sizeof(addr)) &&
+                                                                       p->prefix == ((a->managed) ? addrs[i].prefix : a->length))

                                                                found = true;
                                                } else {
                                                        addr.s6_addr32[3] = htonl(a->assigned);
 
                                                                found = true;
                                                } else {
                                                        addr.s6_addr32[3] = htonl(a->assigned);
 

-                                                       if (IN6_ARE_ADDR_EQUAL(&n->addr, &addr))
+                                                       if (!memcmp(&n->addr, &addr, sizeof(addr)))

                                                                found = true;
                                                }
                                        }
                                                                found = true;
                                                }
                                        }


@@ -746,8 +936,89 @@ static size_t append_reply(uint8_t *buf, size_t buflen, uint16_t status,
        return datalen;
 }
 
        return datalen;
 }
 

+struct log_ctxt {
+       char *buf;
+       int buf_len;
+       int buf_idx;
+};
+
+static void dhcpv6_log_ia_addr(struct in6_addr *addr, int prefix, _unused uint32_t pref,
+                               _unused uint32_t valid, void *arg)
+{
+       struct log_ctxt *ctxt = (struct log_ctxt *)arg;
+       char addrbuf[INET6_ADDRSTRLEN];
+
+       inet_ntop(AF_INET6, addr, addrbuf, sizeof(addrbuf));
+       ctxt->buf_idx += snprintf(ctxt->buf + ctxt->buf_idx, ctxt->buf_len - ctxt->buf_idx,
+                                       "%s/%d ", addrbuf, prefix);
+}
+
+static void dhcpv6_log(uint8_t msgtype, struct interface *iface, time_t now,
+               const char *duidbuf, bool is_pd, struct dhcpv6_assignment *a, int code)
+{
+       const char *type = "UNKNOWN";
+       const char *status = "UNKNOWN";

 
 

-size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
+       if (msgtype == DHCPV6_MSG_RENEW)
+               return;
+
+       switch (msgtype) {
+       case DHCPV6_MSG_SOLICIT:
+               type = "SOLICIT";
+               break;
+       case DHCPV6_MSG_REQUEST:
+               type = "REQUEST";
+               break;
+       case DHCPV6_MSG_CONFIRM:
+               type = "CONFIRM";
+               break;
+       case DHCPV6_MSG_RENEW:
+               type = "RENEW";
+               break;
+       case DHCPV6_MSG_REBIND:
+               type = "REBIND";
+               break;
+       case DHCPV6_MSG_RELEASE:
+               type = "RELEASE";
+               break;
+       case DHCPV6_MSG_DECLINE:
+               type = "DECLINE";
+               break;
+       }
+
+       switch (code) {
+       case DHCPV6_STATUS_OK:
+               status = "ok";
+               break;
+       case DHCPV6_STATUS_NOADDRSAVAIL:
+               status = "no addresses available";
+               break;
+       case DHCPV6_STATUS_NOBINDING:
+               status = "no binding";
+               break;
+       case DHCPV6_STATUS_NOTONLINK:
+               status = "not on-link";
+               break;
+       case DHCPV6_STATUS_NOPREFIXAVAIL:
+               status = "no prefix available";
+               break;
+       }
+
+       char leasebuf[256] = "";
+
+       if (a) {
+               struct log_ctxt ctxt = {.buf = leasebuf,
+                                       .buf_len = sizeof(leasebuf),
+                                       .buf_idx = 0 };
+
+               dhcpv6_enum_ia_addrs(iface, a, now, dhcpv6_log_ia_addr, &ctxt);
+       }
+
+       syslog(LOG_WARNING, "DHCPV6 %s %s from %s on %s: %s %s", type, (is_pd) ? "IA_PD" : "IA_NA",
+                       duidbuf, iface->ifname, status, leasebuf);
+}
+
+ssize_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,

                const struct sockaddr_in6 *addr, const void *data, const uint8_t *end)
 {
        time_t now = odhcpd_time();
                const struct sockaddr_in6 *addr, const void *data, const uint8_t *end)
 {
        time_t now = odhcpd_time();


@@ -755,13 +1026,14 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
        const struct dhcpv6_client_header *hdr = data;
        uint8_t *start = (uint8_t*)&hdr[1], *odata;
        uint16_t otype, olen;
        const struct dhcpv6_client_header *hdr = data;
        uint8_t *start = (uint8_t*)&hdr[1], *odata;
        uint16_t otype, olen;

-
-       // Find and parse client-id and hostname
+       /* Find and parse client-id and hostname */

        bool accept_reconf = false;
        uint8_t *clid_data = NULL, clid_len = 0, mac[6] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
        char hostname[256];
        size_t hostname_len = 0;
        bool accept_reconf = false;
        uint8_t *clid_data = NULL, clid_len = 0, mac[6] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
        char hostname[256];
        size_t hostname_len = 0;

-       bool class_oro = false;
+       bool notonlink = false;
+       char duidbuf[261];
+

        dhcpv6_for_each_option(start, end, otype, olen, odata) {
                if (otype == DHCPV6_OPT_CLIENTID) {
                        clid_data = odata;
        dhcpv6_for_each_option(start, end, otype, olen, odata) {
                if (otype == DHCPV6_OPT_CLIENTID) {
                        clid_data = odata;


@@ -771,6 +1043,9 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                memcpy(mac, &odata[8], sizeof(mac));
                        else if (olen == 10 && odata[0] == 0 && odata[1] == 3)
                                memcpy(mac, &odata[4], sizeof(mac));
                                memcpy(mac, &odata[8], sizeof(mac));
                        else if (olen == 10 && odata[0] == 0 && odata[1] == 3)
                                memcpy(mac, &odata[4], sizeof(mac));

+
+                       if (olen <= 130)
+                               odhcpd_hexlify(duidbuf, odata, olen);

                } else if (otype == DHCPV6_OPT_FQDN && olen >= 2 && olen <= 255) {
                        uint8_t fqdn_buf[256];
                        memcpy(fqdn_buf, odata, olen);
                } else if (otype == DHCPV6_OPT_FQDN && olen >= 2 && olen <= 255) {
                        uint8_t fqdn_buf[256];
                        memcpy(fqdn_buf, odata, olen);


@@ -778,29 +1053,18 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
 
                        if (dn_expand(&fqdn_buf[1], &fqdn_buf[olen], &fqdn_buf[1], hostname, sizeof(hostname)) > 0)
                                hostname_len = strcspn(hostname, ".");
 
                        if (dn_expand(&fqdn_buf[1], &fqdn_buf[olen], &fqdn_buf[1], hostname, sizeof(hostname)) > 0)
                                hostname_len = strcspn(hostname, ".");

-               } else if (otype == DHCPV6_OPT_ORO) {
-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                       for (size_t i = 0; i + 1 < olen; i += 2) {
-                               if (odata[i] == (DHCPV6_OPT_PREFIX_CLASS >> 8) &&
-                                               odata[i + 1] == (DHCPV6_OPT_PREFIX_CLASS & 0xff))
-                                       class_oro = true;
-                       }
-#endif
-               } else if (otype == DHCPV6_OPT_RECONF_ACCEPT) {
+               } else if (otype == DHCPV6_OPT_RECONF_ACCEPT)

                        accept_reconf = true;
                        accept_reconf = true;

-               }

        }
 
        if (!clid_data || !clid_len || clid_len > 130)
                goto out;
 
        }
 
        if (!clid_data || !clid_len || clid_len > 130)
                goto out;
 

-       update(iface);
-       bool update_state = false;
-

        struct dhcpv6_assignment *first = NULL;
        dhcpv6_for_each_option(start, end, otype, olen, odata) {
                bool is_pd = (otype == DHCPV6_OPT_IA_PD);
                bool is_na = (otype == DHCPV6_OPT_IA_NA);
        struct dhcpv6_assignment *first = NULL;
        dhcpv6_for_each_option(start, end, otype, olen, odata) {
                bool is_pd = (otype == DHCPV6_OPT_IA_PD);
                bool is_na = (otype == DHCPV6_OPT_IA_NA);

+               bool ia_addr_present = false;

                if (!is_pd && !is_na)
                        continue;
 
                if (!is_pd && !is_na)
                        continue;
 


@@ -809,11 +1073,7 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                uint8_t reqlen = (is_pd) ? 62 : 128;
                uint32_t reqhint = 0;
 
                uint8_t reqlen = (is_pd) ? 62 : 128;
                uint32_t reqhint = 0;
 

-               const uint8_t classes_max = 32;
-               uint8_t classes_cnt = 0;
-               uint16_t classes[classes_max];
-
-               // Parse request hint for IA-PD
+               /* Parse request hint for IA-PD */

                if (is_pd) {
                        uint8_t *sdata;
                        uint16_t stype, slen;
                if (is_pd) {
                        uint8_t *sdata;
                        uint16_t stype, slen;


@@ -828,20 +1088,6 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                        if (reqlen > 32 && reqlen <= 64)
                                                reqhint &= (1U << (64 - reqlen)) - 1;
                                }
                                        if (reqlen > 32 && reqlen <= 64)
                                                reqhint &= (1U << (64 - reqlen)) - 1;
                                }

-
-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                               uint8_t *xdata;
-                               uint16_t xtype, xlen;
-                               dhcpv6_for_each_option(&p[1], sdata + slen, xtype, xlen, xdata) {
-                                       if (xtype != DHCPV6_OPT_PREFIX_CLASS || xlen != 2)
-                                               continue;
-
-                                       if (classes_cnt >= classes_max)
-                                               continue;
-
-                                       classes[classes_cnt++] = (uint16_t)xdata[0] << 8 | (uint16_t)xdata[1];
-                               }
-#endif

                        }
 
                        if (reqlen > 64)
                        }
 
                        if (reqlen > 64)


@@ -853,56 +1099,46 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                if (stype != DHCPV6_OPT_IA_ADDR || slen < sizeof(struct dhcpv6_ia_addr) - 4)
                                        continue;
 
                                if (stype != DHCPV6_OPT_IA_ADDR || slen < sizeof(struct dhcpv6_ia_addr) - 4)
                                        continue;
 

-#ifdef DHCPV6_OPT_PREFIX_CLASS
-                               uint8_t *xdata;
-                               uint16_t xtype, xlen;
-                               struct dhcpv6_ia_addr *p = (struct dhcpv6_ia_addr*)&sdata[-4];
-                               dhcpv6_for_each_option(&p[1], sdata + slen, xtype, xlen, xdata) {
-                                       if (xtype != DHCPV6_OPT_PREFIX_CLASS || xlen != 2)
-                                               continue;
-
-                                       if (classes_cnt >= classes_max)
-                                               continue;
-
-                                       classes[classes_cnt++] = (uint16_t)xdata[0] << 8 | (uint16_t)xdata[1];
-                               }
-#endif
+                               ia_addr_present = true;

                        }
                }
 
                        }
                }
 

-               // Find assignment
+               /* Find assignment */

                struct dhcpv6_assignment *c, *a = NULL;
                list_for_each_entry(c, &iface->ia_assignments, head) {
                        if (((c->clid_len == clid_len && !memcmp(c->clid_data, clid_data, clid_len)) ||
                                        (c->clid_len >= clid_len && !c->clid_data[0] && !c->clid_data[1]
                struct dhcpv6_assignment *c, *a = NULL;
                list_for_each_entry(c, &iface->ia_assignments, head) {
                        if (((c->clid_len == clid_len && !memcmp(c->clid_data, clid_data, clid_len)) ||
                                        (c->clid_len >= clid_len && !c->clid_data[0] && !c->clid_data[1]

-                                               && !memcmp(c->mac, mac, sizeof(mac)))) &&
-                                       (c->iaid == ia->iaid || c->valid_until < now) &&
+                                               && !memcmp(c->mac, mac, sizeof(mac)))) &&
+                                       (c->iaid == ia->iaid || INFINITE_VALID(c->valid_until) || now < c->valid_until) &&

                                        ((is_pd && c->length <= 64) || (is_na && c->length == 128))) {
                                a = c;
 
                                        ((is_pd && c->length <= 64) || (is_na && c->length == 128))) {
                                a = c;
 

-                               // Reset state
-                               apply_lease(iface, a, false);
+                               /* Reset state */
+                               if (a->flags & OAF_BOUND)
+                                       apply_lease(iface, a, false);
+

                                memcpy(a->clid_data, clid_data, clid_len);
                                a->clid_len = clid_len;
                                a->iaid = ia->iaid;
                                a->peer = *addr;
                                a->reconf_cnt = 0;
                                a->reconf_sent = 0;
                                memcpy(a->clid_data, clid_data, clid_len);
                                a->clid_len = clid_len;
                                a->iaid = ia->iaid;
                                a->peer = *addr;
                                a->reconf_cnt = 0;
                                a->reconf_sent = 0;

-                               a->all_class = class_oro;
-                               a->classes_cnt = classes_cnt;
-                               a->classes = realloc(a->classes, classes_cnt * sizeof(uint16_t));
-                               if (a->classes)
-                                       memcpy(a->classes, classes, classes_cnt * sizeof(uint16_t));

                                break;
                        }
                }
 
                                break;
                        }
                }
 

-               // Generic message handling
+               /* Generic message handling */

                uint16_t status = DHCPV6_STATUS_OK;
                uint16_t status = DHCPV6_STATUS_OK;

-               if (hdr->msg_type == DHCPV6_MSG_SOLICIT || hdr->msg_type == DHCPV6_MSG_REQUEST) {
+               if (a && a->managed_size < 0)
+                       return -1;
+
+               if (hdr->msg_type == DHCPV6_MSG_SOLICIT ||
+                               hdr->msg_type == DHCPV6_MSG_REQUEST ||
+                               (hdr->msg_type == DHCPV6_MSG_REBIND && !a)) {

                        bool assigned = !!a;
 
                        bool assigned = !!a;
 

-                       if (!a && !iface->no_dynamic_dhcp) { // Create new binding
+                       if (!a && !iface->no_dynamic_dhcp) {
+                               /* Create new binding */

                                a = calloc(1, sizeof(*a) + clid_len);
                                if (a) {
                                        a->clid_len = clid_len;
                                a = calloc(1, sizeof(*a) + clid_len);
                                if (a) {
                                        a->clid_len = clid_len;


@@ -910,13 +1146,9 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                        a->length = reqlen;
                                        a->peer = *addr;
                                        a->assigned = reqhint;
                                        a->length = reqlen;
                                        a->peer = *addr;
                                        a->assigned = reqhint;

-                                       a->all_class = class_oro;
-                                       a->classes_cnt = classes_cnt;
-                                       if (classes_cnt) {
-                                               a->classes = malloc(classes_cnt * sizeof(uint16_t));
-                                               if (a->classes)
-                                                       memcpy(a->classes, classes, classes_cnt * sizeof(uint16_t));
-                                       }
+                                       /* Set valid time to current time indicating  */
+                                       /* assignment is not having infinite lifetime */
+                                       a->valid_until = now;

 
                                        if (first)
                                                memcpy(a->key, first->key, sizeof(a->key));
 
                                        if (first)
                                                memcpy(a->key, first->key, sizeof(a->key));


@@ -925,15 +1157,20 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                        memcpy(a->clid_data, clid_data, clid_len);
 
                                        if (is_pd)
                                        memcpy(a->clid_data, clid_data, clid_len);
 
                                        if (is_pd)

-                                               while (!(assigned = assign_pd(iface, a)) && ++a->length <= 64);
+                                               while (!(assigned = assign_pd(iface, a)) &&
+                                                               !a->managed_size && ++a->length <= 64);

                                        else
                                                assigned = assign_na(iface, a);
                                        else
                                                assigned = assign_na(iface, a);

+
+                                       if (a->managed_size && !assigned)
+                                               return -1;

                                }
                        }
 
                                }
                        }
 

-                       if (!assigned || iface->ia_addr_len == 0) { // Set error status
+                       if (!assigned || iface->ia_addr_len == 0)
+                               /* Set error status */

                                status = (is_pd) ? DHCPV6_STATUS_NOPREFIXAVAIL : DHCPV6_STATUS_NOADDRSAVAIL;
                                status = (is_pd) ? DHCPV6_STATUS_NOPREFIXAVAIL : DHCPV6_STATUS_NOADDRSAVAIL;

-                       } else if (assigned && !first) { //
+                       else if (assigned && !first && hdr->msg_type != DHCPV6_MSG_REBIND) {

                                size_t handshake_len = 4;
                                buf[0] = 0;
                                buf[1] = DHCPV6_OPT_RECONF_ACCEPT;
                                size_t handshake_len = 4;
                                buf[0] = 0;
                                buf[1] = DHCPV6_OPT_RECONF_ACCEPT;


@@ -961,12 +1198,18 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                first = a;
                        }
 
                                first = a;
                        }
 

-                       ia_response_len = append_reply(buf, buflen, status, ia, a, iface, true);
+                       ia_response_len = append_reply(buf, buflen, status, ia, a, iface,
+                                                       hdr->msg_type == DHCPV6_MSG_REBIND ? false : true);

 
 

-                       // Was only a solicitation: mark binding for removal
+                       /* Was only a solicitation: mark binding for removal */

                        if (assigned && hdr->msg_type == DHCPV6_MSG_SOLICIT) {
                        if (assigned && hdr->msg_type == DHCPV6_MSG_SOLICIT) {

-                               a->valid_until = 0;
-                       } else if (assigned && hdr->msg_type == DHCPV6_MSG_REQUEST) {
+                               a->flags &= ~OAF_BOUND;
+
+                               if (!(a->flags & OAF_STATIC))
+                                       a->valid_until = now;
+                       } else if (assigned &&
+                                       (hdr->msg_type == DHCPV6_MSG_REQUEST ||
+                                        hdr->msg_type == DHCPV6_MSG_REBIND)) {

                                if (hostname_len > 0) {
                                        a->hostname = realloc(a->hostname, hostname_len + 1);
                                        if (a->hostname) {
                                if (hostname_len > 0) {
                                        a->hostname = realloc(a->hostname, hostname_len + 1);
                                        if (a->hostname) {


@@ -975,12 +1218,12 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                                        }
                                }
                                a->accept_reconf = accept_reconf;
                                        }
                                }
                                a->accept_reconf = accept_reconf;

+                               a->flags |= OAF_BOUND;

                                apply_lease(iface, a, true);
                                apply_lease(iface, a, true);

-                               update_state = true;
-                       } else if (!assigned && a) { // Cleanup failed assignment
-                               free(a->classes);
-                               free(a->hostname);
-                               free(a);
+                       } else if (!assigned && a && a->managed_size == 0) {
+                               /* Cleanup failed assignment */
+                               free_dhcpv6_assignment(a);
+                               a = NULL;

                        }
                } else if (hdr->msg_type == DHCPV6_MSG_RENEW ||
                                hdr->msg_type == DHCPV6_MSG_RELEASE ||
                        }
                } else if (hdr->msg_type == DHCPV6_MSG_RENEW ||
                                hdr->msg_type == DHCPV6_MSG_RELEASE ||


@@ -992,40 +1235,51 @@ size_t dhcpv6_handle_ia(uint8_t *buf, size_t buflen, struct interface *iface,
                        } else if (hdr->msg_type == DHCPV6_MSG_RENEW ||
                                        hdr->msg_type == DHCPV6_MSG_REBIND) {
                                ia_response_len = append_reply(buf, buflen, status, ia, a, iface, false);
                        } else if (hdr->msg_type == DHCPV6_MSG_RENEW ||
                                        hdr->msg_type == DHCPV6_MSG_REBIND) {
                                ia_response_len = append_reply(buf, buflen, status, ia, a, iface, false);

-                               if (a)
+                               if (a) {
+                                       a->flags |= OAF_BOUND;

                                        apply_lease(iface, a, true);
                                        apply_lease(iface, a, true);

+                               }

                        } else if (hdr->msg_type == DHCPV6_MSG_RELEASE) {
                        } else if (hdr->msg_type == DHCPV6_MSG_RELEASE) {

-                               a->valid_until = 0;
-                               apply_lease(iface, a, false);
-                               update_state = true;
+                               if (!(a->flags & OAF_STATIC))
+                                       a->valid_until = now - 1;
+
+                               if (a->flags & OAF_BOUND) {
+                                       apply_lease(iface, a, false);
+                                       a->flags &= ~OAF_BOUND;
+                               }

                        } else if (hdr->msg_type == DHCPV6_MSG_DECLINE && a->length == 128) {
                        } else if (hdr->msg_type == DHCPV6_MSG_DECLINE && a->length == 128) {

-                               a->clid_len = 0;
-                               a->valid_until = now + 3600; // Block address for 1h
-                               update_state = true;
+                               a->flags &= ~OAF_BOUND;
+
+                               if (!(a->flags & OAF_STATIC)) {
+                                       a->clid_len = 0;
+                                       a->valid_until = now + 3600; /* Block address for 1h */
+                               }

                        }
                        }

-               } else if (hdr->msg_type == DHCPV6_MSG_CONFIRM) {
-                       // Always send NOTONLINK for CONFIRM so that clients restart connection
+               } else if (hdr->msg_type == DHCPV6_MSG_CONFIRM && ia_addr_present) {
+                       /* Send NOTONLINK for CONFIRM with addr present so that clients restart connection */

                        status = DHCPV6_STATUS_NOTONLINK;
                        ia_response_len = append_reply(buf, buflen, status, ia, a, iface, true);
                        status = DHCPV6_STATUS_NOTONLINK;
                        ia_response_len = append_reply(buf, buflen, status, ia, a, iface, true);

+                       notonlink = true;

                }
 
                buf += ia_response_len;
                buflen -= ia_response_len;
                response_len += ia_response_len;
                }
 
                buf += ia_response_len;
                buflen -= ia_response_len;
                response_len += ia_response_len;

+               dhcpv6_log(hdr->msg_type, iface, now, duidbuf, is_pd, a, status);

        }
 
        }
 

-       if (hdr->msg_type == DHCPV6_MSG_RELEASE && response_len + 6 < buflen) {
+       if ((hdr->msg_type == DHCPV6_MSG_RELEASE || hdr->msg_type == DHCPV6_MSG_DECLINE || notonlink) &&
+                       response_len + 6 < buflen) {

                buf[0] = 0;
                buf[1] = DHCPV6_OPT_STATUS;
                buf[2] = 0;
                buf[3] = 2;
                buf[4] = 0;
                buf[0] = 0;
                buf[1] = DHCPV6_OPT_STATUS;
                buf[2] = 0;
                buf[3] = 2;
                buf[4] = 0;

-               buf[5] = DHCPV6_STATUS_OK;
+               buf[5] = (notonlink) ? DHCPV6_STATUS_NOTONLINK : DHCPV6_STATUS_OK;

                response_len += 6;
        }
 
                response_len += 6;
        }
 

-       if (update_state)
-               dhcpv6_write_statefile();
+       dhcpv6_write_statefile();

 
 out:
        return response_len;
 
 out:
        return response_len;