Fix illegal memory access

[project/odhcpd.git] / src / config.c

diff --git a/src/config.c b/src/config.c
index e455965..5d29173 100644 (file)
--- a/src/config.c
+++ b/src/config.c
@@ -254,10 +254,10 @@ err:
 }
 
 
-int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite)
+int config_parse_interface(void *data, size_t len, const char *name, bool overwrite)
 {
        struct blob_attr *tb[IFACE_ATTR_MAX], *c;
-       blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, blob_data(b), blob_len(b));
+       blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, data, len);
 
        if (tb[IFACE_ATTR_INTERFACE])
                name = blobmsg_get_string(tb[IFACE_ATTR_INTERFACE]);
@@ -270,7 +270,7 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
                iface = calloc(1, sizeof(*iface));
                strncpy(iface->name, name, sizeof(iface->name) - 1);
                list_add(&iface->head, &interfaces);
-       } else {
+       } else if (overwrite) {
                clean_interface(iface);
        }
 
@@ -284,10 +284,12 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
        else if ((c = tb[IFACE_ATTR_NETWORKID]))
                ifname = blobmsg_get_string(c);
 
-       if (!ifname)
+       if (!iface->ifname[0] && !ifname)
                return -1;
 
-       strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+       if (ifname)
+               strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+
        iface->inuse = true;
 
        if (overwrite)
@@ -481,7 +483,7 @@ static int set_interface(struct uci_section *s)
 {
        blob_buf_init(&b, 0);
        uci_to_blob(&b, s, &interface_attr_list);
-       return config_parse_interface(b.head, s->e.name, true);
+       return config_parse_interface(blob_data(b.head), blob_len(b.head), s->e.name, true);
 }
 
 
@@ -499,6 +501,10 @@ void odhcpd_run(void)
        signal(SIGHUP, set_stop);
        signal(SIGINT, set_stop);
 
+#ifdef WITH_UBUS
+       init_ubus();
+#endif
+
        do {
                do_reload = uloop_cancelled = false;
 
@@ -532,7 +538,7 @@ void odhcpd_run(void)
 #endif
 
                // Evaluate hybrid mode for master
-               struct interface *master = NULL, *i;
+               struct interface *master = NULL, *i, *n;
                list_for_each_entry(i, &interfaces, head) {
                        if (!i->master)
                                continue;
@@ -557,8 +563,8 @@ void odhcpd_run(void)
                }
 
 
-               list_for_each_entry(i, &interfaces, head) {
-                       if (i->inuse && !i->ignore) {
+               list_for_each_entry_safe(i, n, &interfaces, head) {
+                       if (i->inuse) {
                                // Resolve hybrid mode
                                if (i->dhcpv6 == RELAYD_HYBRID)
                                        i->dhcpv6 = (master && master->dhcpv6 == RELAYD_RELAY) ?