project/netifd.git
6 years agointerface: call proto teardown before marking the interface as down
Felix Fietkau [Sun, 31 Aug 2014 13:06:42 +0000 (15:06 +0200)]
interface: call proto teardown before marking the interface as down

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: do not try to bring up an unavailable interface
Felix Fietkau [Sun, 31 Aug 2014 13:03:20 +0000 (15:03 +0200)]
interface: do not try to bring up an unavailable interface

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: cancel the remove timer on cleanup
Felix Fietkau [Sun, 31 Aug 2014 12:57:34 +0000 (14:57 +0200)]
interface: cancel the remove timer on cleanup

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: also set proto_task_killed for SIGKILL
Felix Fietkau [Sun, 31 Aug 2014 12:22:52 +0000 (14:22 +0200)]
proto-shell: also set proto_task_killed for SIGKILL

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: set proto_task_killed for SIGTERM only
Ulrich Weber [Tue, 10 Jun 2014 10:51:06 +0000 (10:51 +0000)]
proto-shell: set proto_task_killed for SIGTERM only

otherwise teardown will not kill the process
if the interface was renewed before, which
set proto_task_killed

Signed-off-by: Ulrich Weber <uw@ocedo.com>
6 years agohandler: explicitly include json.h
Felix Fietkau [Wed, 13 Aug 2014 21:07:24 +0000 (23:07 +0200)]
handler: explicitly include json.h

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoipv6: assign prefixes with length <64 with /64 on-link routes
Steven Barth [Wed, 13 Aug 2014 14:35:28 +0000 (16:35 +0200)]
ipv6: assign prefixes with length <64 with /64 on-link routes

on-link routes for prefixes bigger than /64 make no sense and
might confuse some users

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agonetifd: More fine grained handling of unwanted proto shell actions
Hans Dedecker [Thu, 7 Aug 2014 08:44:31 +0000 (08:44 +0000)]
netifd: More fine grained handling of unwanted proto shell actions

In commit e1ec2d2b9e7f7692a4ff88a0361bbcdbe34f0d99 (proto-shell: extend race condition avoidance), changes were made to prevent notifications from the proto handler during the proto shell states teardown and abort.
These changes unfortunately also prevent netifd from being notified of a number of proto handler events like notify_error, blok_restart and kill during the teardown state.
This introduces issues when the protocol is ppp, the authfail UCI parameter is set and authentication fails; the interface autostart parameter cannot be set to disabled while the ppp daemon keeps running as these proto handler notifications are dropped in the teardown state.
The attached patch blocks the notifications in the individual notification handlers which should not get notifications during teardown/abort state and allows notify_error/blok_restart/kill notifications during these states.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agoDisable new-style tunnel creation for older kernels
Steven Barth [Wed, 6 Aug 2014 11:23:12 +0000 (13:23 +0200)]
Disable new-style tunnel creation for older kernels

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agonetifd: Accept notify errors in proto_shell teardown or abort state
Hans Dedecker [Tue, 5 Aug 2014 08:22:27 +0000 (08:22 +0000)]
netifd: Accept notify errors in proto_shell teardown or abort state

In commit e1ec2d2b9e7f7692a4ff88a0361bbcdbe34f0d99 (proto-shell: extend race condition avoidance), changes were made to prevent notifications from the proto handler during teardown.
According to the comments, this was done to avoid the shell proto state being reset to S_IDLE and the interface hanging in IFS_TEARDOWN state.
These changes unfortunately also prevent netifd from being notified of the errors (proto_shell_notify_error) that actually caused the teardown.
This is for instance an issue when the protocol is ppp and e.g.  PAP/CHAP authentication fails.
Since proto_shell_notify_error does not touch the proto state, it seems like a good idea to at least allow these notifications in teardown state.
The attached patch accomplishes this.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Signed-off-by: Joeri Barbarien <joeri.barbarien@gmail.com>
6 years agonetifd: fix incorrect number of bytes memset in clear_if_addr
Hans Dedecker [Tue, 5 Aug 2014 08:22:26 +0000 (08:22 +0000)]
netifd: fix incorrect number of bytes memset in clear_if_addr

Fix clear_if_addr for IPv6 addresses as an incorrect number of bytes were memset due to wrong sizeof argument

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: GRE tunnel support
Hans Dedecker [Wed, 30 Jul 2014 10:56:31 +0000 (10:56 +0000)]
netifd: GRE tunnel support

Adds support for gre, gretap, grev6 and grev6tap tunnels

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Allow to add link devices which can be marked as non external
Hans Dedecker [Wed, 30 Jul 2014 10:56:30 +0000 (10:56 +0000)]
netifd: Allow to add link devices which can be marked as non external

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Set device down based on being a non external device in device_release
Hans Dedecker [Wed, 30 Jul 2014 10:56:29 +0000 (10:56 +0000)]
netifd: Set device down based on being a non external device in device_release

Line up the device state manipulation by checking the external device parameter consistent and not the hotplug device parameter

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agoadd_dynamic: remove redundant code
Steven Barth [Tue, 29 Jul 2014 16:43:45 +0000 (18:43 +0200)]
add_dynamic: remove redundant code

device_config is unneeded since add_dynamic is used to create aliases
checking of setup state is unneeded because of race condition fixes

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoproto-shell: extend race condition avoidance
Steven Barth [Tue, 29 Jul 2014 16:41:51 +0000 (18:41 +0200)]
proto-shell: extend race condition avoidance

Disallow all notifications from the proto handler during teardown to
avoid the shell proto state being reset to S_IDLE and the interface
hanging in IFS_TEARDOWN state.

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoubus: add del_dynamic as complement to add_dynamic
Steven Barth [Mon, 28 Jul 2014 19:48:26 +0000 (21:48 +0200)]
ubus: add del_dynamic as complement to add_dynamic

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agointerface: enable force_link by default for proto=static
Felix Fietkau [Sun, 27 Jul 2014 11:21:22 +0000 (13:21 +0200)]
interface: enable force_link by default for proto=static

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: fix renew_pending handling
Felix Fietkau [Sat, 26 Jul 2014 14:35:49 +0000 (16:35 +0200)]
proto-shell: fix renew_pending handling

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: fix setup/renew race condition
Felix Fietkau [Sat, 26 Jul 2014 01:46:39 +0000 (03:46 +0200)]
proto-shell: fix setup/renew race condition

If a renew event arrives before the setup event has been processed, the
renew event needs to be deferred, otherwise interfaces can get stuck

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoOnly add dynamic interfaces if the underlying interface is ready
Steven Barth [Thu, 24 Jul 2014 22:01:50 +0000 (00:01 +0200)]
Only add dynamic interfaces if the underlying interface is ready

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoproto-shell: don't accept up-notifications in teardown state
Steven Barth [Thu, 24 Jul 2014 19:18:00 +0000 (21:18 +0200)]
proto-shell: don't accept up-notifications in teardown state

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agointerface: fix restart after reload with external devices
Felix Fietkau [Thu, 24 Jul 2014 09:12:48 +0000 (11:12 +0200)]
interface: fix restart after reload with external devices

When an interface goes down, the main_dev is reset to NULL.
Track an externally added device separately to be able to bring it back
up.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agobridge: enable multicast querier functionality by default
Felix Fietkau [Thu, 24 Jul 2014 08:54:14 +0000 (10:54 +0200)]
bridge: enable multicast querier functionality by default

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoSet DEVICE for legacy ifupdate event as well
Steven Barth [Wed, 23 Jul 2014 16:06:47 +0000 (18:06 +0200)]
Set DEVICE for legacy ifupdate event as well

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoMake dynamic interfaces always autostart
Steven Barth [Wed, 23 Jul 2014 16:04:47 +0000 (18:04 +0200)]
Make dynamic interfaces always autostart

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoscripts: set type for the "key" attribute
Felix Fietkau [Fri, 18 Jul 2014 11:37:08 +0000 (13:37 +0200)]
scripts: set type for the "key" attribute

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agobridge: enable IGMP snooping by default
Felix Fietkau [Thu, 17 Jul 2014 14:56:14 +0000 (16:56 +0200)]
bridge: enable IGMP snooping by default

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: clean up l3 device reference on remove/reload
Felix Fietkau [Sun, 29 Jun 2014 21:27:29 +0000 (23:27 +0200)]
interface: clean up l3 device reference on remove/reload

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agobridge: enable multicast_to_unicast on all wireless bridge ports
Felix Fietkau [Sun, 29 Jun 2014 18:31:26 +0000 (20:31 +0200)]
bridge: enable multicast_to_unicast on all wireless bridge ports

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agodevice: fall back to simple interface status check if not provided by the device...
Felix Fietkau [Thu, 26 Jun 2014 10:17:46 +0000 (12:17 +0200)]
device: fall back to simple interface status check if not provided by the device type

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: fix indentation
Felix Fietkau [Thu, 26 Jun 2014 10:09:21 +0000 (12:09 +0200)]
interface: fix indentation

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: add debug msg for calling handlers
Felix Fietkau [Thu, 26 Jun 2014 10:07:24 +0000 (12:07 +0200)]
proto-shell: add debug msg for calling handlers

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agosystem-dummy: set present flags on all devices
Felix Fietkau [Thu, 26 Jun 2014 10:04:15 +0000 (12:04 +0200)]
system-dummy: set present flags on all devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: don't store table id in route if the default table is used
Steven Barth [Fri, 20 Jun 2014 17:50:13 +0000 (19:50 +0200)]
interface: don't store table id in route if the default table is used

Use system_is_default_rt_table() to test whether the resolved routing table
is the default one, in this case do not apply the table attribute to the
route object.

This is needed for backwards compatibility - only routes using a non-default
table shall report it in the ifstatus output.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
6 years agosystem: fix treatment of RT_TABLE_MAIN
Steven Barth [Fri, 20 Jun 2014 17:48:32 +0000 (19:48 +0200)]
system: fix treatment of RT_TABLE_MAIN

Do not treat RT_TABLE_MAIN as RT_TABLE_UNSPEC in system_resolve_rt_table() in
order to allow ip rules with lookup main to work as expected.

Provide a new function system_is_default_rt_table() to allow calling code to
specifically test for RT_TABLE_MAIN, this is going to be needed for the
backwards compatible handling of the table attribute in route objects.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
6 years agolinux: unify functions to delete links
Steven Barth [Wed, 18 Jun 2014 11:28:39 +0000 (13:28 +0200)]
linux: unify functions to delete links

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agonetifd: Route type support
Hans Dedecker [Wed, 18 Jun 2014 05:55:48 +0000 (05:55 +0000)]
netifd: Route type support

Patch adds route type support in netifd by means of the route parameter type.
By default the route type was unicast; the parameter adss support for local/broadcast/multicast/unicast routes which will be put into the appropriate routing table.
If route type parameter is unset the route type will be unicast as before.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Check device_claim return code in all cases
Hans Dedecker [Wed, 18 Jun 2014 05:55:47 +0000 (05:55 +0000)]
netifd: Check device_claim return code in all cases

Fixes observed issue a tunnel interface is reported as up although device_claim failed

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Fix ipip6 tunnel memleak in case of tunnel creation failure
Hans Dedecker [Wed, 18 Jun 2014 05:55:46 +0000 (05:55 +0000)]
netifd: Fix ipip6 tunnel memleak in case of tunnel creation failure

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Fix macvlan delete via netlink
Hans Dedecker [Wed, 18 Jun 2014 07:41:14 +0000 (07:41 +0000)]
netifd: Fix macvlan delete via netlink

Fix macvlan delete via netlink as netlink attribute IFLA_IFNAME data size was incorrect (size reject by the kernel) and NLM_F_REQUEST flag was missing.
In addition some minor improvements (attribute IFLA_INFO_KIND can be left out as RTM_DELLINK does not require the attribute)

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Fix vlan delete via netlink
Hans Dedecker [Wed, 18 Jun 2014 05:55:44 +0000 (05:55 +0000)]
netifd: Fix vlan delete via netlink

Fix vlan delete via netlink as netlink attribute IFLA_IFNAME data size was incorrect.
In addition some minor improvements.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agoReorder alfabetically device type matching as they are growing in number
Gioacchino Mazzurco [Tue, 10 Jun 2014 17:29:14 +0000 (19:29 +0200)]
Reorder alfabetically device type matching as they are growing in number

Signed-off-by: Gioacchino Mazzurco <gmazzurco89@gmail.com>
6 years agoAdd vlan 802.1q/802.1ad support as netifd devices
Gioacchino Mazzurco [Tue, 10 Jun 2014 17:29:13 +0000 (19:29 +0200)]
Add vlan 802.1q/802.1ad support as netifd devices

At moment netifd supports just 802.1q vlan, you can configure them using a concise but "hacky"
syntax using an interface config section, with this patch netifd acquire the capability
of configuring 802.1ad and 802.1q vlan using config device sections, so you can define a vlan device
plus interface with something like this:

config device 'test'
        option type '8021ad'
        option name 'test'
        option ifname 'eth0'
        option vid '1000'

config interface 'testif'
        option ifname 'test'
        option proto 'none'
        option auto '1'

old syntax for 802.1q keeps working so no retrocompatibility problems,
to keep retrocompatibility means also that user must not use name/ifname like eth0.2
for devices declared with the new style because this would trigger the "old style"
when interface config section is parsed

Signed-off-by: Gioacchino Mazzurco <gmazzurco89@gmail.com>
6 years agoAdd qtcreator and kdevelop4 project files to .gitignore
Gioacchino Mazzurco [Tue, 10 Jun 2014 17:29:12 +0000 (19:29 +0200)]
Add qtcreator and kdevelop4 project files to .gitignore

Signed-off-by: Gioacchino Mazzurco <gmazzurco89@gmail.com>
6 years agonetifd: process reload calls immediately instead of going through a timer
Felix Fietkau [Wed, 11 Jun 2014 10:18:46 +0000 (12:18 +0200)]
netifd: process reload calls immediately instead of going through a timer

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoAdd support for onlink-flags for IPv4 routes
Steven Barth [Tue, 10 Jun 2014 15:59:16 +0000 (17:59 +0200)]
Add support for onlink-flags for IPv4 routes

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoadd a interface. prefix to ubus_notify calls
John Crispin [Wed, 4 Jun 2014 17:57:16 +0000 (18:57 +0100)]
add a interface. prefix to ubus_notify calls

Signed-off-by: John Crispin <blogic@openwrt.org>
6 years agomacvlan: fix missing reference to device_attr_list
Gioacchino Mazzurco [Wed, 28 May 2014 20:44:21 +0000 (22:44 +0200)]
macvlan: fix missing reference to device_attr_list

At moment macvlan devices ignore options inherited as device like mtu.

Thanks to suggestions provided by Felix i have done this patch that fix this
iussue by adding the missing reference to device_attr_list in
macvlan_attr_list

Signed-off-by: Gioacchino Mazzurco <gmazzurco89@gmail.com>
6 years agoRewrite ipip6-tunnel setup to use netlink and add support for FMRs
Steven Barth [Wed, 21 May 2014 19:25:50 +0000 (21:25 +0200)]
Rewrite ipip6-tunnel setup to use netlink and add support for FMRs

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agoFix a spurious segfault when tearing down interfaces
Steven Barth [Wed, 21 May 2014 19:24:41 +0000 (21:24 +0200)]
Fix a spurious segfault when tearing down interfaces

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agowireless: fix cancelling setup
Felix Fietkau [Thu, 15 May 2014 19:08:18 +0000 (21:08 +0200)]
wireless: fix cancelling setup

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agosystem-linux: always set the ifindex for hotplug devices on init
Felix Fietkau [Sat, 10 May 2014 18:03:22 +0000 (20:03 +0200)]
system-linux: always set the ifindex for hotplug devices on init

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: Fix node version set after free
Hans Dedecker [Wed, 7 May 2014 09:19:09 +0000 (09:19 +0000)]
netifd: Fix node version set after free

Fixes an issue where a bridge member will be removed from the bridge
upon an interface ifup as the bridge node version -1 is overwritten
by vlist_add while the new created bridge member pointer is freed in
bridge_member_update

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Check interface state only when main device is set during interface_change_config
Hans Dedecker [Wed, 7 May 2014 09:19:08 +0000 (09:19 +0000)]
netifd: Check interface state only when main device is set during interface_change_config

Fixes a regression issue introduced by commit d2a33f3f0fe704e4396fa2ada08401cb955ba7cb for device less protocol handlers.
An active interface using a deviceless protocol handler will be be teared down when the interface config is checked upon
an update as the interface link and enabled parameters are unset as no underlying device is present (eg tunnel interfaces)

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Effectively apply configured route mtu
Hans Dedecker [Wed, 7 May 2014 09:19:07 +0000 (09:19 +0000)]
netifd: Effectively apply configured route mtu

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Remove useless route table parameter check in update_proto_route
Hans Dedecker [Wed, 7 May 2014 09:19:06 +0000 (09:19 +0000)]
netifd: Remove useless route table parameter check in update_proto_route

Not necessary since route table parameter is used as key element in route_cmp

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Don't assume routes are always applied in all cases
Hans Dedecker [Wed, 7 May 2014 09:19:05 +0000 (09:19 +0000)]
netifd: Don't assume routes are always applied in all cases

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Apply interface metric on configured interface gateway parameters
Hans Dedecker [Wed, 7 May 2014 09:19:04 +0000 (09:19 +0000)]
netifd: Apply interface metric on configured interface gateway parameters

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agodevice: prevent interface up/down calls for external devices
Felix Fietkau [Tue, 6 May 2014 18:02:00 +0000 (20:02 +0200)]
device: prevent interface up/down calls for external devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: clear iface->available before changing main_dev
Felix Fietkau [Fri, 2 May 2014 17:04:42 +0000 (19:04 +0200)]
interface: clear iface->available before changing main_dev

Fixes bogus interface restart loop on interface_remove_link

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: use interface_set_main_dev() from interface_remove_link
Felix Fietkau [Fri, 2 May 2014 17:07:18 +0000 (19:07 +0200)]
interface: use interface_set_main_dev() from interface_remove_link

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: do not set l3_dev along with main_dev anymore
Felix Fietkau [Fri, 2 May 2014 17:03:48 +0000 (19:03 +0200)]
interface: do not set l3_dev along with main_dev anymore

Made unnecessary by recent fixes to l3_dev handling

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface-ip: fix misuse of IN6_IS_ADDR_LINKLOCAL on a netifd specific union
Felix Fietkau [Tue, 29 Apr 2014 13:24:48 +0000 (15:24 +0200)]
interface-ip: fix misuse of IN6_IS_ADDR_LINKLOCAL on a netifd specific union

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: fix a use-after-free issue on wireless config update
Felix Fietkau [Tue, 29 Apr 2014 13:16:21 +0000 (15:16 +0200)]
netifd: fix a use-after-free issue on wireless config update

After vlist_add() the device could have been freed

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: Add interface config support to enable/disable IPv6 in the kernel per device
Hans Dedecker [Mon, 7 Apr 2014 11:30:52 +0000 (13:30 +0200)]
netifd: Add interface config support to enable/disable IPv6 in the kernel per device

Main use case is being able to disable IPv6 on (a) WAN interface(s) when only IPv4 connectivity is offered or 6rd is used.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agointerface-event: make eventnames static and const
Felix Fietkau [Wed, 23 Apr 2014 09:44:09 +0000 (11:44 +0200)]
interface-event: make eventnames static and const

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: Rework hotplug event queueing in case of congestion
Hans Dedecker [Mon, 7 Apr 2014 11:30:51 +0000 (13:30 +0200)]
netifd: Rework hotplug event queueing in case of congestion

In case of event congestion (e.g. when several interfaces become active in a short notice) :
-hotplug events will be handled on a first come first served basis (before it was lifo)
-drop a new ifupdate event in favour of an already queued ifup event (before the ifup event was overwritten by the ifupdate event resulting in some hotplug scripts "missing" the ifup event)

Additonal the event flow has been documented

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Signed-off-by: Joeri Barbarien <joeri.barbarien@gmail.com>
6 years agonetifd: Check rt_table parameter when comparing routes
Hans Dedecker [Mon, 7 Apr 2014 11:30:50 +0000 (13:30 +0200)]
netifd: Check rt_table parameter when comparing routes

Allows to add identical routes in different routing tables

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Set prefix assignment enabled if the prefix adress can be installed
Hans Dedecker [Thu, 24 Apr 2014 07:51:16 +0000 (07:51 +0000)]
netifd: Set prefix assignment enabled if the prefix adress can be installed

No need to install policy routes if the prefix address cannot be installed; clean up of the policy routes
and the prefix address only needs to happen when the prefix assignment was active.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Mark interface as dynamic after it has been added in the interface list
Hans Dedecker [Thu, 24 Apr 2014 07:51:15 +0000 (07:51 +0000)]
netifd: Mark interface as dynamic after it has been added in the interface list

Adding an interface in the interface list in case of a config update will override the node version of the old interface and thus overriding the dynamic interface marker.
In case of config update interface_set_dynamic is done on an invalid interface pointer as the new interface pointer has been freed.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: fix IPv6 Link-local DNS server
Ulrich Weber [Wed, 23 Apr 2014 12:33:04 +0000 (12:33 +0000)]
netifd: fix IPv6 Link-local DNS server

interface name must be added to Link-local IPv6
DNS servers, otherwise they are unusable.

Signed-off-by: Ulrich Weber <uw@ocedo.com>
6 years agoconfig: add support for disabling interfaces
Felix Fietkau [Mon, 21 Apr 2014 17:11:34 +0000 (19:11 +0200)]
config: add support for disabling interfaces

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoubus: check the l3_dev pointer before dereferencing it
Felix Fietkau [Sat, 19 Apr 2014 09:58:16 +0000 (11:58 +0200)]
ubus: check the l3_dev pointer before dereferencing it

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: ensure that l3_dev gets set whenever the proto handler marks the interface...
Felix Fietkau [Sat, 19 Apr 2014 09:57:50 +0000 (11:57 +0200)]
interface: ensure that l3_dev gets set whenever the proto handler marks the interface as up

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: add support for a parameter to force setup without a carrier on the underl...
Felix Fietkau [Fri, 11 Apr 2014 13:41:15 +0000 (15:41 +0200)]
interface: add support for a parameter to force setup without a carrier on the underlying device

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-static: ensure that the l3 device is properly set
Felix Fietkau [Thu, 10 Apr 2014 15:21:21 +0000 (17:21 +0200)]
proto-static: ensure that the l3 device is properly set

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: fix a regression with handling multiple proto updates for the same interface
Felix Fietkau [Thu, 10 Apr 2014 11:30:54 +0000 (13:30 +0200)]
proto-shell: fix a regression with handling multiple proto updates for the same interface

Preserve the device when keep == true

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoproto-shell: ensure that l3_dev is always set
Felix Fietkau [Mon, 7 Apr 2014 11:09:09 +0000 (13:09 +0200)]
proto-shell: ensure that l3_dev is always set

A link-down event clears l3_dev, so even if the proto handler does not
provide a new ifname, it still needs to be set explicitly

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agointerface: always delete l3 dev on proto down
Felix Fietkau [Sat, 5 Apr 2014 17:58:01 +0000 (19:58 +0200)]
interface: always delete l3 dev on proto down

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agosystem-dummy: indicate link on present devices
Felix Fietkau [Sat, 5 Apr 2014 17:57:37 +0000 (19:57 +0200)]
system-dummy: indicate link on present devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoconfig: ignore config parser errors
Felix Fietkau [Mon, 31 Mar 2014 20:23:35 +0000 (22:23 +0200)]
config: ignore config parser errors

This helps with keeping routers reachable when there are typos in the
network config.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoubus: use list_empty() instead of the compat wrapper
Felix Fietkau [Fri, 21 Mar 2014 15:08:32 +0000 (16:08 +0100)]
ubus: use list_empty() instead of the compat wrapper

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: Reload proto on topology change
Helmut Schaa [Thu, 20 Mar 2014 15:26:23 +0000 (16:26 +0100)]
netifd: Reload proto on topology change

Introduce a new device event "topology change" that gets signaled
by bridges on adding/removing members.

On "topology changes" the proto handlers are requested to "renew"
which is most useful for DHCP.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
6 years agoubus: fix displaying interface data items
Felix Fietkau [Thu, 20 Mar 2014 20:02:02 +0000 (21:02 +0100)]
ubus: fix displaying interface data items

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: Check interface autostart parameter when handling interface state changes
Hans Dedecker [Thu, 20 Mar 2014 07:59:04 +0000 (08:59 +0100)]
netifd: Check interface autostart parameter when handling interface state changes

Fixes an issue when 2 interfaces make use of the same ifname (device) and one of the interfaces has autostart disabled; bringing up the other interface would also start the interface for which autostart is disabled (link_state and enabled will both be true for the autostart disabled interface and thus a setup will be launched)

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agouci: Allow setting the UCI config path on the command line
Matthias Schiffer [Tue, 4 Mar 2014 17:37:03 +0000 (18:37 +0100)]
uci: Allow setting the UCI config path on the command line

Add a -c switch which allows setting an alternative UCI path instead of using
the libuci default.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
6 years agoRevert "ubus events: don't incorrectly announce an interface as being up"
Felix Fietkau [Tue, 11 Mar 2014 09:24:28 +0000 (10:24 +0100)]
Revert "ubus events: don't incorrectly announce an interface as being up"

Made obsolete by b114b86c70766f67f503077ad1de013c17fbf366

This reverts commit 4d1a597f65bbb49aa843112812d5ca929478c706.

6 years agonetifd: Set interface state in teardown state before launching an interface event
Hans Dedecker [Mon, 10 Mar 2014 15:27:53 +0000 (16:27 +0100)]
netifd: Set interface state in teardown state before launching an interface event

Interface state needs to be set in teardown state before launching an interface event otherwise the up state will be reported as true in the ubus interface notify message

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Assign interface metric to route metric when route is created
Hans Dedecker [Mon, 10 Mar 2014 15:27:52 +0000 (16:27 +0100)]
netifd: Assign interface metric to route metric when route is created

Interface metric needs to be assigned to the route metric parameter at route creation time. Otherwise if the interface metric is different from 0 route_cmp will wrongly conclude the routes are different.
In this case the route will be added/deleted and could end up with the route missing in the kernel depending on the add/delete order.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Fix bridge MTU setting when a bridge member is added
Hans Dedecker [Mon, 10 Mar 2014 15:27:51 +0000 (16:27 +0100)]
netifd: Fix bridge MTU setting when a bridge member is added

Reapply bridge mtu setting as adding a bridge member will override the bridge mtu in the kernel

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agoproto-shell: defer init until after command line option processing
Felix Fietkau [Fri, 7 Mar 2014 18:12:16 +0000 (19:12 +0100)]
proto-shell: defer init until after command line option processing

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agonetifd: fix bridge reloading issue
Emanuel Taube [Fri, 7 Mar 2014 09:22:12 +0000 (10:22 +0100)]
netifd: fix bridge reloading issue

Check in the right order to decide if the bridge have to be set up.
Additionally we are consistent with setting it down.

Signed-off-by: Emanuel Taube <emanuel.taube@gmail.com>
6 years agowireless: defer init until after command line option processing
Felix Fietkau [Fri, 7 Mar 2014 17:49:43 +0000 (18:49 +0100)]
wireless: defer init until after command line option processing

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agoubus events: don't incorrectly announce an interface as being up
Steven Barth [Wed, 5 Mar 2014 17:30:59 +0000 (18:30 +0100)]
ubus events: don't incorrectly announce an interface as being up

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agonetifd: Link layer state awareness support on interface level
Hans Dedecker [Tue, 11 Feb 2014 08:30:51 +0000 (08:30 +0000)]
netifd: Link layer state awareness support on interface level

The link layer state is monitored for a given interface; an interface will be setup
when both enabled and link layer active. Likewise an interface will be teared down
when either disabled or link layer down.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
6 years agonetifd: Link layer state awareness support on device level
Hans Dedecker [Tue, 11 Feb 2014 08:30:20 +0000 (08:30 +0000)]
netifd: Link layer state awareness support on device level

Device layer is informed by netlink events regarding the link layer status. Link
layer status change results in a DEV_EVENT_LINK_UP/DEV_EVENT_LINK_DOWN broadcast
event for a given device.

Depends on uloop error callback patch.

Solves issue reported in https://dev.openwrt.org/ticket/14590

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Acked-by: Karl Vogel <karl.vogel@gmail.com>
6 years agoDon't always assume routes & addresses are applied
Steven Barth [Wed, 26 Feb 2014 13:21:48 +0000 (14:21 +0100)]
Don't always assume routes & addresses are applied

Actually check netlink return values and remember failure.

Signed-off-by: Steven Barth <steven@midlink.org>
6 years agowireless: fix device config reload regression
Felix Fietkau [Sun, 23 Feb 2014 08:09:21 +0000 (09:09 +0100)]
wireless: fix device config reload regression

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
6 years agowireless: add a "get_validate" methode to ubus
John Crispin [Mon, 17 Feb 2014 12:12:26 +0000 (12:12 +0000)]
wireless: add a "get_validate" methode to ubus

Signed-off-by: John Crispin <blogic@openwrt.org>