X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=vlan.c;h=354e12f661d662bcf1d37200239d2caeb6b255b2;hp=f70420a257f71b77d5b6e95b1051a2a9a01b300a;hb=3eea8576d48d9b20cc1c6b46f54c7345a39d13aa;hpb=6f34c02e517689faa5b04809b448891228a44355 diff --git a/vlan.c b/vlan.c index f70420a..354e12f 100644 --- a/vlan.c +++ b/vlan.c @@ -50,7 +50,7 @@ static int vlan_set_device_state(struct device *dev, bool up) } ret = device_claim(&vldev->dep); - if (ret) + if (ret < 0) return ret; system_vlan_add(vldev->dep.dev, vldev->id); @@ -70,19 +70,28 @@ static void vlan_dev_set_name(struct vlan_device *vldev, struct device *dev) static void vlan_dev_cb(struct device_user *dep, enum device_event ev) { struct vlan_device *vldev; + bool new_state = false; vldev = container_of(dep, struct vlan_device, dep); switch(ev) { case DEV_EVENT_ADD: - device_set_present(&vldev->dev, true); - break; + new_state = true; case DEV_EVENT_REMOVE: - device_set_present(&vldev->dev, false); + device_set_present(&vldev->dev, new_state); + break; + case DEV_EVENT_LINK_UP: + new_state = true; + case DEV_EVENT_LINK_DOWN: + device_set_link(&vldev->dev, new_state); break; case DEV_EVENT_UPDATE_IFNAME: vlan_dev_set_name(vldev, dep->dev); device_broadcast_event(&vldev->dev, ev); break; + case DEV_EVENT_TOPO_CHANGE: + /* Propagate topo changes */ + device_broadcast_event(&vldev->dev, DEV_EVENT_TOPO_CHANGE); + break; default: break; } @@ -93,6 +102,7 @@ static struct device *get_vlan_device(struct device *dev, int id, bool create) static const struct device_type vlan_type = { .name = "VLAN", .config_params = &device_attr_list, + .keep_link_status = true, .free = free_vlan_if, }; struct vlan_device *vldev; @@ -113,6 +123,8 @@ static struct device *get_vlan_device(struct device *dev, int id, bool create) if (!create) return NULL; + D(DEVICE, "Create vlan device '%s.%d'\n", dev->ifname, id); + vldev = calloc(1, sizeof(*vldev)); vldev->id = id;