X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=ubus.c;h=aeb864fdabd24610c2f5a8c18351147c1fc1b69d;hp=9bd5d8c268817e6a042b9f8ae27755c8529180cf;hb=ede9739fe90f5da09f14481d10a4f11c000072de;hpb=c397d2788ffd27904ab89e437432b481c6e7e806

diff --git a/ubus.c b/ubus.c
index 9bd5d8c..aeb864f 100644
--- a/ubus.c
+++ b/ubus.c
@@ -140,7 +140,6 @@ netifd_add_dynamic(struct ubus_context *ctx, struct ubus_object *obj,
 	if (!iface)
 		return UBUS_STATUS_UNKNOWN_ERROR;
 
-	interface_set_dynamic(iface);
 	iface->device_config = true;
 
 	config = blob_memdup(msg);
@@ -148,6 +147,7 @@ netifd_add_dynamic(struct ubus_context *ctx, struct ubus_object *obj,
 		goto error;
 
 	interface_add(iface, config);
+	interface_set_dynamic(iface);
 
 	// need to look up the interface name again, in case of config update,
 	iface = vlist_find(&interfaces, name, iface, node);
@@ -497,7 +497,7 @@ interface_ip_dump_route_list(struct interface_ip_settings *ip, bool enabled)
 
 		buf = blobmsg_alloc_string_buffer(&b, "source", buflen);
 		inet_ntop(af, &route->source, buf, buflen);
-		snprintf(buf + strlen(buf), 4, "/%u", route->sourcemask);
+		snprintf(buf + strlen(buf), buflen - strlen(buf), "/%u", route->sourcemask);
 		blobmsg_add_string_buffer(&b);
 
 		blobmsg_close_table(&b, r);
@@ -650,7 +650,8 @@ netifd_dump_status(struct interface *iface)
 	if (iface->state == IFS_UP) {
 		time_t cur = system_get_rtime();
 		blobmsg_add_u32(&b, "uptime", cur - iface->start_time);
-		blobmsg_add_string(&b, "l3_device", iface->l3_dev.dev->ifname);
+		if (iface->l3_dev.dev)
+			blobmsg_add_string(&b, "l3_device", iface->l3_dev.dev->ifname);
 	}
 
 	if (iface->proto_handler)
@@ -662,6 +663,21 @@ netifd_dump_status(struct interface *iface)
 		blobmsg_add_string(&b, "device", dev->ifname);
 
 	if (iface->state == IFS_UP) {
+		if (iface->updated) {
+			a = blobmsg_open_array(&b, "updated");
+
+			if (iface->updated & IUF_ADDRESS)
+				blobmsg_add_string(&b, NULL, "addresses");
+			if (iface->updated & IUF_ROUTE)
+				blobmsg_add_string(&b, NULL, "routes");
+			if (iface->updated & IUF_PREFIX)
+				blobmsg_add_string(&b, NULL, "prefixes");
+			if (iface->updated & IUF_DATA)
+				blobmsg_add_string(&b, NULL, "data");
+
+			blobmsg_close_array(&b, a);
+		}
+
 		if (iface->ip4table)
 			blobmsg_add_u32(&b, "ip4table", iface->ip4table);
 		if (iface->ip6table)
@@ -722,11 +738,11 @@ netifd_dump_status(struct interface *iface)
 
 	a = blobmsg_open_table(&b, "data");
 	avl_for_each_element(&iface->data, data, node)
-		blob_put(&b, blob_id(data->data), blob_data(data->data), blob_len(data->data));
+		blobmsg_add_blob(&b, data->data);
 
 	blobmsg_close_table(&b, a);
 
-	if (!list_is_empty(&iface->errors))
+	if (!list_empty(&iface->errors))
 		netifd_add_interface_errors(&b, iface);
 }
 
@@ -1049,6 +1065,29 @@ netifd_handle_wdev_status(struct ubus_context *ctx, struct ubus_object *obj,
 }
 
 static int
+netifd_handle_wdev_get_validate(struct ubus_context *ctx, struct ubus_object *obj,
+			  struct ubus_request_data *req, const char *method,
+			  struct blob_attr *msg)
+{
+	struct wireless_device *wdev;
+	int ret;
+
+	wdev = get_wdev(msg, &ret);
+	if (ret == UBUS_STATUS_NOT_FOUND)
+		return ret;
+
+	blob_buf_init(&b, 0);
+	if (wdev) {
+		wireless_device_get_validate(wdev, &b);
+	} else {
+		vlist_for_each_element(&wireless_devices, wdev, node)
+			wireless_device_get_validate(wdev, &b);
+	}
+	ubus_send_reply(ctx, req, b.head);
+	return 0;
+}
+
+static int
 netifd_handle_wdev_notify(struct ubus_context *ctx, struct ubus_object *obj,
 			  struct ubus_request_data *req, const char *method,
 			  struct blob_attr *msg)
@@ -1068,6 +1107,7 @@ static struct ubus_method wireless_object_methods[] = {
 	{ .name = "down", .handler = netifd_handle_wdev_down },
 	{ .name = "status", .handler = netifd_handle_wdev_status },
 	{ .name = "notify", .handler = netifd_handle_wdev_notify },
+	{ .name = "get_validate", .handler = netifd_handle_wdev_get_validate },
 };
 
 static struct ubus_object_type wireless_object_type =