X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=ubus.c;h=3ea71bf8e40946c29f450110eca0cc5ede3ca577;hp=be9e63221077786867c263587c1f62e7d1d4a515;hb=30e9a048af138b39ee0d53451da43eddd6f48fda;hpb=6653b861748719ab58e21a81e01d59d4d8afe10c diff --git a/ubus.c b/ubus.c index be9e632..3ea71bf 100644 --- a/ubus.c +++ b/ubus.c @@ -595,8 +595,10 @@ netifd_iface_handle_device(struct ubus_context *ctx, struct ubus_object *obj, device_lock(); dev = device_get(blobmsg_data(tb[DEV_NAME]), add ? 2 : 0); - if (add && !dev) - return UBUS_STATUS_NOT_FOUND; + if (add && !dev) { + ret = UBUS_STATUS_NOT_FOUND; + goto out; + } if (add) { device_set_present(dev, true); @@ -609,6 +611,7 @@ netifd_iface_handle_device(struct ubus_context *ctx, struct ubus_object *obj, ret = interface_remove_link(iface, dev); } +out: device_unlock(); return ret;