X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=ubus.c;h=014a34eac3420dbd891a6b0335778c5ce6add128;hp=a9b0057769cec817cee370042a84f2443b7c3044;hb=36dba9c4a9aee236928459d3d38fd08e5924259b;hpb=ccca61c97d460d73f29750abdf38cea20ac440f3

diff --git a/ubus.c b/ubus.c
index a9b0057..014a34e 100644
--- a/ubus.c
+++ b/ubus.c
@@ -269,11 +269,10 @@ netifd_iface_handle_device(struct ubus_context *ctx, struct ubus_object *obj,
 			   struct ubus_request_data *req, const char *method,
 			   struct blob_attr *msg)
 {
-	struct interface *iface;
-	struct device *dev, *main_dev = NULL;
 	struct blob_attr *tb[__DEV_MAX];
+	struct interface *iface;
+	struct device *dev;
 	bool add = !strncmp(method, "add", 3);
-	const char *devname;
 	int ret;
 
 	iface = container_of(obj, struct interface, ubus);
@@ -283,53 +282,18 @@ netifd_iface_handle_device(struct ubus_context *ctx, struct ubus_object *obj,
 	if (!tb[DEV_NAME])
 		return UBUS_STATUS_INVALID_ARGUMENT;
 
-	devname = blobmsg_data(tb[DEV_NAME]);
-	dev = iface->main_dev.dev;
-	if (iface->hotplug_dev && dev && !add) {
-		if (strcmp(dev->ifname, devname) != 0)
-			return UBUS_STATUS_INVALID_ARGUMENT;
-	}
-
-	if (iface->hotplug_dev) {
-		if (iface->main_dev.dev) {
-			interface_set_available(iface, false);
-			device_remove_user(&iface->main_dev);
-		}
-	} else
-		main_dev = iface->main_dev.dev;
+	device_lock();
 
-	dev = device_get(blobmsg_data(tb[DEV_NAME]), add);
-	if (!dev)
+	dev = device_get(blobmsg_data(tb[DEV_NAME]), add ? 2 : 0);
+	if (add && !dev)
 		return UBUS_STATUS_NOT_FOUND;
 
-	if (!main_dev) {
-		if (add) {
-			device_add_user(&iface->main_dev, dev);
-			iface->hotplug_dev = true;
-		}
-		ret = 0;
-		goto out;
-	}
-
-	if (!main_dev->hotplug_ops) {
-		ret = UBUS_STATUS_NOT_SUPPORTED;
-		goto out;
-	}
-
-	if (main_dev != dev) {
-		if (add)
-			ret = main_dev->hotplug_ops->add(main_dev, dev);
-		else
-			ret = main_dev->hotplug_ops->del(main_dev, dev);
-		if (ret)
-			ret = UBUS_STATUS_UNKNOWN_ERROR;
-	} else {
-		ret = UBUS_STATUS_INVALID_ARGUMENT;
-	}
-
-out:
 	if (add)
-		device_free_unused(dev);
+		return interface_add_link(iface, dev);
+	else
+		return interface_remove_link(iface, dev);
+
+	device_unlock();
 
 	return ret;
 }
@@ -375,10 +339,32 @@ netifd_iface_remove(struct ubus_context *ctx, struct ubus_object *obj,
 	return 0;
 }
 
+static int
+netifd_handle_iface_prepare(struct ubus_context *ctx, struct ubus_object *obj,
+			    struct ubus_request_data *req, const char *method,
+			    struct blob_attr *msg)
+{
+	struct interface *iface;
+	struct device *dev;
+	const struct device_hotplug_ops *ops;
+
+	iface = container_of(obj, struct interface, ubus);
+	dev = iface->main_dev.dev;
+	if (!dev)
+		return 0;
+
+	ops = dev->hotplug_ops;
+	if (!ops)
+		return 0;
+
+	return ops->prepare(dev);
+}
+
 static struct ubus_method iface_object_methods[] = {
 	{ .name = "up", .handler = netifd_handle_up },
 	{ .name = "down", .handler = netifd_handle_down },
 	{ .name = "status", .handler = netifd_handle_status },
+	{ .name = "prepare", .handler = netifd_handle_iface_prepare },
 	UBUS_METHOD("add_device", netifd_iface_handle_device, dev_policy ),
 	UBUS_METHOD("remove_device", netifd_iface_handle_device, dev_policy ),
 	{ .name = "notify_proto", .handler = netifd_iface_notify_proto },