X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=system-linux.c;h=34d7cae30d4592ff5fbc1e3bb98029565211ba7e;hp=bb834a2d6614a8f4f278c01683379da0ea619b90;hb=1466967ffa3e408b709d5e84932616787b2853ac;hpb=ca3f00d45e72c4b28b2ce39afc9543fa2f225020

diff --git a/system-linux.c b/system-linux.c
index bb834a2..34d7cae 100644
--- a/system-linux.c
+++ b/system-linux.c
@@ -9,11 +9,13 @@
 #include <linux/sockios.h>
 #include <linux/if_vlan.h>
 #include <linux/if_bridge.h>
+#include <linux/ethtool.h>
 
 #include <unistd.h>
 #include <string.h>
 #include <fcntl.h>
 #include <glob.h>
+#include <time.h>
 
 #include <netlink/msg.h>
 #include <netlink/attr.h>
@@ -24,67 +26,120 @@
 #include "device.h"
 #include "system.h"
 
+struct event_socket {
+	struct uloop_fd uloop;
+	struct nl_sock *sock;
+	struct nl_cb *cb;
+};
+
 static int sock_ioctl = -1;
 static struct nl_sock *sock_rtnl = NULL;
-static struct nl_sock *sock_rtnl_event = NULL;
 
-static void handler_rtnl_event(struct uloop_fd *u, unsigned int events);
 static int cb_rtnl_event(struct nl_msg *msg, void *arg);
-static struct uloop_fd rtnl_event = {.cb = handler_rtnl_event};
-static struct nl_cb *nl_cb_rtnl_event;
+static void handle_hotplug_event(struct uloop_fd *u, unsigned int events);
+
+static void
+handler_nl_event(struct uloop_fd *u, unsigned int events)
+{
+	struct event_socket *ev = container_of(u, struct event_socket, uloop);
+	nl_recvmsgs(ev->sock, ev->cb);
+}
+
+static struct nl_sock *
+create_socket(int protocol, int groups)
+{
+	struct nl_sock *sock;
+
+	sock = nl_socket_alloc();
+	if (!sock)
+		return NULL;
+
+	if (groups)
+		nl_join_groups(sock, groups);
+
+	if (nl_connect(sock, protocol))
+		return NULL;
+
+	return sock;
+}
+
+static bool
+create_raw_event_socket(struct event_socket *ev, int protocol, int groups,
+			uloop_fd_handler cb)
+{
+	ev->sock = create_socket(protocol, groups);
+	if (!ev->sock)
+		return false;
+
+	ev->uloop.fd = nl_socket_get_fd(ev->sock);
+	ev->uloop.cb = cb;
+	uloop_fd_add(&ev->uloop, ULOOP_READ | ULOOP_EDGE_TRIGGER);
+	return true;
+}
+
+static bool
+create_event_socket(struct event_socket *ev, int protocol,
+		    int (*cb)(struct nl_msg *msg, void *arg))
+{
+	// Prepare socket for link events
+	ev->cb = nl_cb_alloc(NL_CB_DEFAULT);
+	if (!ev->cb)
+		return false;
+
+	nl_cb_set(ev->cb, NL_CB_VALID, NL_CB_CUSTOM, cb, NULL);
+
+	return create_raw_event_socket(ev, protocol, 0, handler_nl_event);
+}
 
 int system_init(void)
 {
+	static struct event_socket rtnl_event;
+	static struct event_socket hotplug_event;
+
 	sock_ioctl = socket(AF_LOCAL, SOCK_DGRAM, 0);
 	fcntl(sock_ioctl, F_SETFD, fcntl(sock_ioctl, F_GETFD) | FD_CLOEXEC);
 
 	// Prepare socket for routing / address control
-	sock_rtnl = nl_socket_alloc();
+	sock_rtnl = create_socket(NETLINK_ROUTE, 0);
 	if (!sock_rtnl)
 		return -1;
 
-	if (nl_connect(sock_rtnl, NETLINK_ROUTE))
-		goto error_free_sock;
+	if (!create_event_socket(&rtnl_event, NETLINK_ROUTE, cb_rtnl_event))
+		return -1;
 
-	// Prepare socket for link events
-	nl_cb_rtnl_event = nl_cb_alloc(NL_CB_DEFAULT);
-	if (!nl_cb_rtnl_event)
-		goto error_free_sock;
+	if (!create_raw_event_socket(&hotplug_event, NETLINK_KOBJECT_UEVENT, 1,
+				     handle_hotplug_event))
+		return -1;
 
-	nl_cb_set(nl_cb_rtnl_event, NL_CB_VALID, NL_CB_CUSTOM,
-		  cb_rtnl_event, NULL);
+	// Receive network link events form kernel
+	nl_socket_add_membership(rtnl_event.sock, RTNLGRP_LINK);
 
-	sock_rtnl_event = nl_socket_alloc();
-	if (!sock_rtnl_event)
-		goto error_free_cb;
+	return 0;
+}
 
-	if (nl_connect(sock_rtnl_event, NETLINK_ROUTE))
-		goto error_free_event;
+static void system_set_sysctl(const char *path, const char *val)
+{
+	int fd;
 
-	// Receive network link events form kernel
-	nl_socket_add_membership(sock_rtnl_event, RTNLGRP_LINK);
+	fd = open(path, O_WRONLY);
+	if (fd < 0)
+		return;
 
-	rtnl_event.fd = nl_socket_get_fd(sock_rtnl_event);
-	uloop_fd_add(&rtnl_event, ULOOP_READ | ULOOP_EDGE_TRIGGER);
+	write(fd, val, strlen(val));
+	close(fd);
+}
 
-	return 0;
+static void system_set_dev_sysctl(const char *path, const char *device, const char *val)
+{
+	static char buf[256];
 
-error_free_event:
-	nl_socket_free(sock_rtnl_event);
-	sock_rtnl_event = NULL;
-error_free_cb:
-	nl_cb_put(nl_cb_rtnl_event);
-	nl_cb_rtnl_event = NULL;
-error_free_sock:
-	nl_socket_free(sock_rtnl);
-	sock_rtnl = NULL;
-	return -1;
+	snprintf(buf, sizeof(buf), path, val);
+	system_set_sysctl(buf, val);
 }
 
-// If socket is ready for reading parse netlink events
-static void handler_rtnl_event(struct uloop_fd *u, unsigned int events)
+static void system_set_disable_ipv6(struct device *dev, const char *val)
 {
-	nl_recvmsgs(sock_rtnl_event, nl_cb_rtnl_event);
+	system_set_dev_sysctl("/proc/sys/net/ipv6/conf/%s/disable_ipv6", dev->ifname, val);
 }
 
 // Evaluate netlink messages
@@ -106,12 +161,78 @@ static int cb_rtnl_event(struct nl_msg *msg, void *arg)
 		goto out;
 
 	dev->ifindex = ifi->ifi_index;
-	device_set_present(dev, (nh->nlmsg_type == RTM_NEWLINK));
+	/* TODO: parse link status */
 
 out:
 	return 0;
 }
 
+static void
+handle_hotplug_msg(char *data, int size)
+{
+	const char *subsystem = NULL, *interface = NULL;
+	char *cur, *end, *sep;
+	struct device *dev;
+	int skip;
+	bool add;
+
+	if (!strncmp(data, "add@", 4))
+		add = true;
+	else if (!strncmp(data, "remove@", 7))
+		add = false;
+	else
+		return;
+
+	skip = strlen(data) + 1;
+	end = data + size;
+
+	for (cur = data + skip; cur < end; cur += skip) {
+		skip = strlen(cur) + 1;
+
+		sep = strchr(cur, '=');
+		if (!sep)
+			continue;
+
+		*sep = 0;
+		if (!strcmp(cur, "INTERFACE"))
+			interface = sep + 1;
+		else if (!strcmp(cur, "SUBSYSTEM")) {
+			subsystem = sep + 1;
+			if (strcmp(subsystem, "net") != 0)
+				return;
+		}
+		if (subsystem && interface)
+			goto found;
+	}
+	return;
+
+found:
+	dev = device_get(interface, false);
+	if (!dev)
+		return;
+
+	if (dev->type != &simple_device_type)
+		return;
+
+	device_set_present(dev, add);
+}
+
+static void
+handle_hotplug_event(struct uloop_fd *u, unsigned int events)
+{
+	struct event_socket *ev = container_of(u, struct event_socket, uloop);
+	struct sockaddr_nl nla;
+	unsigned char *buf = NULL;
+	int size;
+
+	while ((size = nl_recv(ev->sock, &nla, &buf, NULL)) > 0) {
+		if (nla.nl_pid == 0)
+			handle_hotplug_msg((char *) buf, size);
+
+		free(buf);
+	}
+}
+
 static int system_rtnl_call(struct nl_msg *msg)
 {
 	int s = -(nl_send_auto_complete(sock_rtnl, msg)
@@ -138,11 +259,13 @@ static int system_bridge_if(const char *bridge, struct device *dev, int cmd, voi
 
 int system_bridge_addif(struct device *bridge, struct device *dev)
 {
+	system_set_disable_ipv6(dev, "1");
 	return system_bridge_if(bridge->ifname, dev, SIOCBRADDIF, NULL);
 }
 
 int system_bridge_delif(struct device *bridge, struct device *dev)
 {
+	system_set_disable_ipv6(dev, "0");
 	return system_bridge_if(bridge->ifname, dev, SIOCBRDELIF, NULL);
 }
 
@@ -202,14 +325,150 @@ static int system_if_flags(const char *ifname, unsigned add, unsigned rem)
 	return ioctl(sock_ioctl, SIOCSIFFLAGS, &ifr);
 }
 
+struct clear_data {
+	struct nl_msg *msg;
+	struct device *dev;
+	int type;
+	int size;
+	int af;
+};
+
+
+static bool check_ifaddr(struct nlmsghdr *hdr, int ifindex)
+{
+	struct ifaddrmsg *ifa = NLMSG_DATA(hdr);
+
+	return ifa->ifa_index == ifindex;
+}
+
+static bool check_route(struct nlmsghdr *hdr, int ifindex)
+{
+	struct nlattr *tb[__RTA_MAX];
+
+	nlmsg_parse(hdr, sizeof(struct rtmsg), tb, __RTA_MAX - 1, NULL);
+	if (!tb[RTA_OIF])
+		return false;
+
+	return *(int *)RTA_DATA(tb[RTA_OIF]) == ifindex;
+}
+
+static int cb_clear_event(struct nl_msg *msg, void *arg)
+{
+	struct clear_data *clr = arg;
+	struct nlmsghdr *hdr = nlmsg_hdr(msg);
+	bool (*cb)(struct nlmsghdr *, int ifindex);
+	int type;
+
+	switch(clr->type) {
+	case RTM_GETADDR:
+		type = RTM_DELADDR;
+		if (hdr->nlmsg_type != RTM_NEWADDR)
+			return NL_SKIP;
+
+		cb = check_ifaddr;
+		break;
+	case RTM_GETROUTE:
+		type = RTM_DELROUTE;
+		if (hdr->nlmsg_type != RTM_NEWROUTE)
+			return NL_SKIP;
+
+		cb = check_route;
+		break;
+	default:
+		return NL_SKIP;
+	}
+
+	if (!cb(hdr, clr->dev->ifindex))
+		return NL_SKIP;
+
+	D(SYSTEM, "Remove %s from device %s\n",
+	  type == RTM_DELADDR ? "an address" : "a route",
+	  clr->dev->ifname);
+	memcpy(nlmsg_hdr(clr->msg), hdr, hdr->nlmsg_len);
+	hdr = nlmsg_hdr(clr->msg);
+	hdr->nlmsg_type = type;
+	hdr->nlmsg_flags = NLM_F_REQUEST;
+
+	if (!nl_send_auto_complete(sock_rtnl, clr->msg))
+		nl_wait_for_ack(sock_rtnl);
+
+	return NL_SKIP;
+}
+
+static int
+cb_finish_event(struct nl_msg *msg, void *arg)
+{
+	int *pending = arg;
+	*pending = 0;
+	return NL_STOP;
+}
+
+static int
+error_handler(struct sockaddr_nl *nla, struct nlmsgerr *err, void *arg)
+{
+	int *pending = arg;
+	*pending = err->error;
+	return NL_STOP;
+}
+
+static void
+system_if_clear_entries(struct device *dev, int type, int af)
+{
+	struct clear_data clr;
+	struct nl_cb *cb = nl_cb_alloc(NL_CB_DEFAULT);
+	struct rtmsg rtm = {
+		.rtm_family = af,
+		.rtm_flags = RTM_F_CLONED,
+	};
+	int flags = NLM_F_DUMP;
+	int pending = 1;
+
+	clr.af = af;
+	clr.dev = dev;
+	clr.type = type;
+	switch (type) {
+	case RTM_GETADDR:
+		clr.size = sizeof(struct rtgenmsg);
+		break;
+	case RTM_GETROUTE:
+		clr.size = sizeof(struct rtmsg);
+		break;
+	default:
+		return;
+	}
+
+	if (!cb)
+		return;
+
+	clr.msg = nlmsg_alloc_simple(type, flags);
+	if (!clr.msg)
+		goto out;
+
+	nlmsg_append(clr.msg, &rtm, clr.size, 0);
+	nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, cb_clear_event, &clr);
+	nl_cb_set(cb, NL_CB_FINISH, NL_CB_CUSTOM, cb_finish_event, &pending);
+	nl_cb_err(cb, NL_CB_CUSTOM, error_handler, &pending);
+
+	nl_send_auto_complete(sock_rtnl, clr.msg);
+	while (pending > 0)
+		nl_recvmsgs(sock_rtnl, cb);
+
+	nlmsg_free(clr.msg);
+out:
+	nl_cb_put(cb);
+}
+
 /*
  * Clear bridge (membership) state and bring down device
  */
 void system_if_clear_state(struct device *dev)
 {
-	char buf[256];
+	static char buf[256];
 	char *bridge;
 
+	if (dev->external)
+		return;
+
 	dev->ifindex = system_if_resolve(dev);
 	if (!dev->ifindex)
 		return;
@@ -227,6 +486,12 @@ void system_if_clear_state(struct device *dev)
 		D(SYSTEM, "Remove device '%s' from bridge '%s'\n", dev->ifname, bridge);
 		system_bridge_if(bridge, dev, SIOCBRDELIF, NULL);
 	}
+
+	system_if_clear_entries(dev, RTM_GETROUTE, AF_INET);
+	system_if_clear_entries(dev, RTM_GETADDR, AF_INET);
+	system_if_clear_entries(dev, RTM_GETROUTE, AF_INET6);
+	system_if_clear_entries(dev, RTM_GETADDR, AF_INET6);
+	system_set_disable_ipv6(dev, "0");
 }
 
 static inline unsigned long
@@ -250,6 +515,9 @@ int system_bridge_addbr(struct device *bridge, struct bridge_config *cfg)
 	args[1] = sec_to_jiffies(cfg->forward_delay);
 	system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
 
+	system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_snooping",
+		bridge->ifname, cfg->igmp_snoop ? "1" : "0");
+
 	if (cfg->flags & BRIDGE_OPT_AGEING_TIME) {
 		args[0] = BRCTL_SET_AGEING_TIME;
 		args[1] = sec_to_jiffies(cfg->ageing_time);
@@ -301,24 +569,211 @@ int system_vlan_del(struct device *dev)
 	return system_vlan(dev, -1);
 }
 
+static void
+system_if_get_settings(struct device *dev, struct device_settings *s)
+{
+	struct ifreq ifr;
+
+	memset(&ifr, 0, sizeof(ifr));
+	strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
+
+	if (ioctl(sock_ioctl, SIOCGIFMTU, &ifr) == 0) {
+		s->mtu = ifr.ifr_mtu;
+		s->flags |= DEV_OPT_MTU;
+	}
+
+	if (ioctl(sock_ioctl, SIOCGIFTXQLEN, &ifr) == 0) {
+		s->txqueuelen = ifr.ifr_qlen;
+		s->flags |= DEV_OPT_TXQUEUELEN;
+	}
+
+	if (ioctl(sock_ioctl, SIOCGIFHWADDR, &ifr) == 0) {
+		memcpy(s->macaddr, &ifr.ifr_hwaddr, sizeof(s->macaddr));
+		s->flags |= DEV_OPT_MACADDR;
+	}
+}
+
+static void
+system_if_apply_settings(struct device *dev, struct device_settings *s)
+{
+	struct ifreq ifr;
+
+	memset(&ifr, 0, sizeof(ifr));
+	strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
+	if (s->flags & DEV_OPT_MTU) {
+		ifr.ifr_mtu = s->mtu;
+		ioctl(sock_ioctl, SIOCSIFMTU, &ifr);
+	}
+	if (s->flags & DEV_OPT_TXQUEUELEN) {
+		ifr.ifr_qlen = s->txqueuelen;
+		ioctl(sock_ioctl, SIOCSIFTXQLEN, &ifr);
+	}
+	if (s->flags & DEV_OPT_MACADDR) {
+		memcpy(&ifr.ifr_hwaddr, s->macaddr, sizeof(s->macaddr));
+		ioctl(sock_ioctl, SIOCSIFHWADDR, &ifr);
+	}
+}
+
 int system_if_up(struct device *dev)
 {
+	system_if_get_settings(dev, &dev->orig_settings);
+	system_if_apply_settings(dev, &dev->settings);
 	dev->ifindex = system_if_resolve(dev);
 	return system_if_flags(dev->ifname, IFF_UP, 0);
 }
 
 int system_if_down(struct device *dev)
 {
-	return system_if_flags(dev->ifname, 0, IFF_UP);
+	int ret = system_if_flags(dev->ifname, 0, IFF_UP);
+	system_if_apply_settings(dev, &dev->orig_settings);
+	return ret;
 }
 
 int system_if_check(struct device *dev)
 {
-	device_set_present(dev, (system_if_resolve(dev) >= 0));
+	device_set_present(dev, (system_if_resolve(dev) > 0));
 	return 0;
 }
 
-int system_if_dump_stats(struct device *dev, struct blob_buf *b)
+struct device *
+system_if_get_parent(struct device *dev)
+{
+	char buf[64], *devname;
+	int ifindex, iflink, len;
+	FILE *f;
+
+	snprintf(buf, sizeof(buf), "/sys/class/net/%s/iflink", dev->ifname);
+	f = fopen(buf, "r");
+	if (!f)
+		return NULL;
+
+	len = fread(buf, 1, sizeof(buf) - 1, f);
+	fclose(f);
+
+	if (len <= 0)
+		return NULL;
+
+	buf[len] = 0;
+	iflink = strtoul(buf, NULL, 0);
+	ifindex = system_if_resolve(dev);
+	if (!iflink || iflink == ifindex)
+		return NULL;
+
+	devname = if_indextoname(iflink, buf);
+	if (!devname)
+		return NULL;
+
+	return device_get(devname, true);
+}
+
+static bool
+read_string_file(int dir_fd, const char *file, char *buf, int len)
+{
+	bool ret = false;
+	char *c;
+	int fd;
+
+	fd = openat(dir_fd, file, O_RDONLY);
+	if (fd < 0)
+		return false;
+
+retry:
+	len = read(fd, buf, len - 1);
+	if (len < 0) {
+		if (errno == EINTR)
+			goto retry;
+	} else if (len > 0) {
+			buf[len] = 0;
+
+			c = strchr(buf, '\n');
+			if (c)
+				*c = 0;
+
+			ret = true;
+	}
+
+	close(fd);
+
+	return ret;
+}
+
+static bool
+read_int_file(int dir_fd, const char *file, int *val)
+{
+	char buf[64];
+	bool ret = false;
+
+	ret = read_string_file(dir_fd, file, buf, sizeof(buf));
+	if (ret)
+		*val = strtoul(buf, NULL, 0);
+
+	return ret;
+}
+
+/* Assume advertised flags == supported flags */
+static const struct {
+	uint32_t mask;
+	const char *name;
+} ethtool_link_modes[] = {
+	{ ADVERTISED_10baseT_Half, "10H" },
+	{ ADVERTISED_10baseT_Full, "10F" },
+	{ ADVERTISED_100baseT_Half, "100H" },
+	{ ADVERTISED_100baseT_Full, "100F" },
+	{ ADVERTISED_1000baseT_Half, "1000H" },
+	{ ADVERTISED_1000baseT_Full, "1000F" },
+};
+
+static void system_add_link_modes(struct blob_buf *b, __u32 mask)
+{
+	int i;
+	for (i = 0; i < ARRAY_SIZE(ethtool_link_modes); i++) {
+		if (mask & ethtool_link_modes[i].mask)
+			blobmsg_add_string(b, NULL, ethtool_link_modes[i].name);
+	}
+}
+
+int
+system_if_dump_info(struct device *dev, struct blob_buf *b)
+{
+	struct ethtool_cmd ecmd;
+	struct ifreq ifr;
+	char buf[64], *s;
+	void *c;
+	int dir_fd, val = 0;
+
+	snprintf(buf, sizeof(buf), "/sys/class/net/%s", dev->ifname);
+	dir_fd = open(buf, O_DIRECTORY);
+
+	if (read_int_file(dir_fd, "carrier", &val))
+		blobmsg_add_u8(b, "link", !!val);
+
+	memset(&ecmd, 0, sizeof(ecmd));
+	memset(&ifr, 0, sizeof(ifr));
+	strcpy(ifr.ifr_name, dev->ifname);
+	ifr.ifr_data = (caddr_t) &ecmd;
+	ecmd.cmd = ETHTOOL_GSET;
+
+	if (ioctl(sock_ioctl, SIOCETHTOOL, &ifr) == 0) {
+		c = blobmsg_open_array(b, "link-advertising");
+		system_add_link_modes(b, ecmd.advertising);
+		blobmsg_close_array(b, c);
+
+		c = blobmsg_open_array(b, "link-supported");
+		system_add_link_modes(b, ecmd.supported);
+		blobmsg_close_array(b, c);
+
+		s = blobmsg_alloc_string_buffer(b, "speed", 8);
+		snprintf(s, 8, "%d%c", ethtool_cmd_speed(&ecmd),
+			ecmd.duplex == DUPLEX_HALF ? 'H' : 'F');
+		blobmsg_add_string_buffer(b);
+	}
+
+	close(dir_fd);
+	return 0;
+}
+
+int
+system_if_dump_stats(struct device *dev, struct blob_buf *b)
 {
 	const char *const counters[] = {
 		"collisions",     "rx_frame_errors",   "tx_compressed",
@@ -332,30 +787,16 @@ int system_if_dump_stats(struct device *dev, struct blob_buf *b)
 	};
 	char buf[64];
 	int stats_dir;
-	int i, fd, len;
+	int i, val = 0;
 
 	snprintf(buf, sizeof(buf), "/sys/class/net/%s/statistics", dev->ifname);
 	stats_dir = open(buf, O_DIRECTORY);
 	if (stats_dir < 0)
 		return -1;
 
-	for (i = 0; i < ARRAY_SIZE(counters); i++) {
-		fd = openat(stats_dir, counters[i], O_RDONLY);
-		if (fd < 0)
-			continue;
-
-retry:
-		len = read(fd, buf, sizeof(buf));
-		if (len < 0) {
-			if (errno == EINTR)
-				goto retry;
-			continue;
-		}
-
-		buf[len] = 0;
-		blobmsg_add_u32(b, counters[i], strtoul(buf, NULL, 0));
-		close(fd);
-	}
+	for (i = 0; i < ARRAY_SIZE(counters); i++)
+		if (read_int_file(stats_dir, counters[i], &val))
+			blobmsg_add_u32(b, counters[i], val);
 
 	close(stats_dir);
 	return 0;
@@ -370,7 +811,17 @@ static int system_addr(struct device *dev, struct device_addr *addr, int cmd)
 		.ifa_index = dev->ifindex,
 	};
 
-	struct nl_msg *msg = nlmsg_alloc_simple(cmd, 0);
+	struct nl_msg *msg;
+
+	dev = addr->device;
+	if (dev) {
+		if (!dev->ifindex)
+			return -1;
+
+		ifa.ifa_index = dev->ifindex;
+	}
+
+	msg = nlmsg_alloc_simple(cmd, 0);
 	if (!msg)
 		return -1;
 
@@ -394,6 +845,7 @@ static int system_rt(struct device *dev, struct device_route *route, int cmd)
 	int alen = ((route->flags & DEVADDR_FAMILY) == DEVADDR_INET4) ? 4 : 16;
 	bool have_gw;
 	unsigned int flags = 0;
+	int ifindex = dev->ifindex;
 
 	if (alen == 4)
 		have_gw = !!route->nexthop.in.s_addr;
@@ -414,11 +866,20 @@ static int system_rt(struct device *dev, struct device_route *route, int cmd)
 		.rtm_scope = scope,
 		.rtm_type = (cmd == RTM_DELROUTE) ? 0: RTN_UNICAST,
 	};
+	struct nl_msg *msg;
 
 	if (cmd == RTM_NEWROUTE)
 		flags |= NLM_F_CREATE | NLM_F_REPLACE;
 
-	struct nl_msg *msg = nlmsg_alloc_simple(cmd, flags);
+	dev = route->device;
+	if (dev) {
+		if (!dev->ifindex)
+			return -1;
+
+		ifindex = dev->ifindex;
+	}
+
+	msg = nlmsg_alloc_simple(cmd, flags);
 	if (!msg)
 		return -1;
 
@@ -431,7 +892,7 @@ static int system_rt(struct device *dev, struct device_route *route, int cmd)
 		nla_put(msg, RTA_GATEWAY, alen, &route->nexthop);
 
 	if (route->flags & DEVADDR_DEVICE)
-		nla_put_u32(msg, RTA_OIF, dev->ifindex);
+		nla_put_u32(msg, RTA_OIF, ifindex);
 
 	return system_rtnl_call(msg);
 }