X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=proto-static.c;h=b8f341238a0144754a9c31457278491394d82999;hp=a4938f41a23e8ffcb6248658f18d7960298ba98d;hb=b314737e9a0f0df710ba5e8691882cd7d42faaf5;hpb=818abd9f2f42c36a0f91ff6d29a9a635398216e0 diff --git a/proto-static.c b/proto-static.c index a4938f4..b8f3412 100644 --- a/proto-static.c +++ b/proto-static.c @@ -17,6 +17,7 @@ enum { OPT_NETMASK, OPT_GATEWAY, OPT_IP6GW, + OPT_DNS, __OPT_MAX, }; @@ -26,11 +27,13 @@ static const struct blobmsg_policy static_attrs[__OPT_MAX] = { [OPT_NETMASK] = { .name = "netmask", .type = BLOBMSG_TYPE_STRING }, [OPT_GATEWAY] = { .name = "gateway", .type = BLOBMSG_TYPE_STRING }, [OPT_IP6GW] = { .name = "ip6gw", .type = BLOBMSG_TYPE_STRING }, + [OPT_DNS] = { .name = "dns", .type = BLOBMSG_TYPE_ARRAY }, }; static const union config_param_info static_attr_info[__OPT_MAX] = { [OPT_IPADDR] = { .type = BLOBMSG_TYPE_STRING }, [OPT_IP6ADDR] = { .type = BLOBMSG_TYPE_STRING }, + [OPT_DNS] = { .type = BLOBMSG_TYPE_STRING }, }; static const struct config_param_list static_attr_list = { @@ -43,66 +46,24 @@ struct static_proto_state { struct interface_proto_state proto; struct blob_attr *config; - struct interface *iface; }; static bool -split_netmask(char *str, unsigned int *netmask) -{ - char *delim, *err = NULL; - - delim = strchr(str, '/'); - if (delim) { - *(delim++) = 0; - - *netmask = strtoul(delim, &err, 10); - if (err && *err) - return false; - } - return true; -} - -static int -parse_ip_and_netmask(int af, const char *str, void *addr, unsigned int *netmask) -{ - char *astr = alloca(strlen(str) + 1); - - strcpy(astr, str); - if (!split_netmask(astr, netmask)) - return 0; - - if (af == AF_INET6) { - if (*netmask > 128) - return 0; - } else { - if (*netmask > 32) - return 0; - } - - return inet_pton(af, str, addr); -} - -static bool -parse_addr(struct static_proto_state *state, const char *str, bool v6, int mask) +parse_addr(struct interface *iface, const char *str, bool v6, int mask) { struct device_addr *addr; - int af = v6 ? AF_INET6 : AF_INET; - addr = calloc(1, sizeof(*addr)); - addr->flags = v6 ? DEVADDR_INET6 : DEVADDR_INET4; - addr->ctx = state; - addr->mask = mask; - if (!parse_ip_and_netmask(af, str, &addr->addr, &addr->mask)) { - interface_add_error(state->iface, "proto-static", "INVALID_ADDRESS", &str, 1); - free(addr); + addr = proto_parse_ip_addr_string(str, v6, mask); + if (!addr) { + interface_add_error(iface, "proto-static", "INVALID_ADDRESS", &str, 1); return false; } - interface_add_address(state->iface, addr); + vlist_add(&iface->proto_addr, &addr->node); return true; } static int -parse_address_option(struct static_proto_state *state, struct blob_attr *attr, bool v6, int netmask) +parse_address_option(struct interface *iface, struct blob_attr *attr, bool v6, int netmask) { struct blob_attr *cur; int n_addr = 0; @@ -110,7 +71,7 @@ parse_address_option(struct static_proto_state *state, struct blob_attr *attr, b blobmsg_for_each_attr(cur, attr, rem) { n_addr++; - if (!parse_addr(state, blobmsg_data(cur), v6, netmask)) + if (!parse_addr(iface, blobmsg_data(cur), v6, netmask)) return -1; } @@ -118,7 +79,7 @@ parse_address_option(struct static_proto_state *state, struct blob_attr *attr, b } static bool -parse_gateway_option(struct static_proto_state *state, struct blob_attr *attr, bool v6) +parse_gateway_option(struct interface *iface, struct blob_attr *attr, bool v6) { struct device_route *route; const char *str = blobmsg_data(attr); @@ -126,44 +87,41 @@ parse_gateway_option(struct static_proto_state *state, struct blob_attr *attr, b route = calloc(1, sizeof(*route)); if (!inet_pton(af, str, &route->nexthop)) { - interface_add_error(state->iface, "proto-static", + interface_add_error(iface, "proto-static", "INVALID_GATEWAY", &str, 1); free(route); return false; } route->mask = 0; route->flags = DEVADDR_DEVICE | (v6 ? DEVADDR_INET6 : DEVADDR_INET4); - interface_add_route(state->iface, route); + vlist_add(&iface->proto_route, &route->node); return true; } -static bool -static_proto_setup(struct static_proto_state *state) +static int +proto_apply_static_settings(struct interface *iface, struct blob_attr *attr) { struct blob_attr *tb[__OPT_MAX]; - struct in_addr ina; const char *error; - int netmask = 32; + unsigned int netmask = 32; int n_v4 = 0, n_v6 = 0; - blobmsg_parse(static_attrs, __OPT_MAX, tb, blob_data(state->config), - blob_len(state->config)); + blobmsg_parse(static_attrs, __OPT_MAX, tb, blob_data(attr), blob_len(attr)); if (tb[OPT_NETMASK]) { - if (!inet_aton(blobmsg_data(tb[OPT_NETMASK]), &ina)) { + netmask = parse_netmask_string(blobmsg_data(tb[OPT_NETMASK]), false); + if (netmask > 32) { error = "INVALID_NETMASK"; goto error; } - - netmask = 32 - fls(~(ntohl(ina.s_addr))); } if (tb[OPT_IPADDR]) - n_v4 = parse_address_option(state, tb[OPT_IPADDR], false, netmask); + n_v4 = parse_address_option(iface, tb[OPT_IPADDR], false, netmask); if (tb[OPT_IP6ADDR]) - n_v6 = parse_address_option(state, tb[OPT_IP6ADDR], true, netmask); + n_v6 = parse_address_option(iface, tb[OPT_IP6ADDR], true, netmask); if (!n_v4 && !n_v6) { error = "NO_ADDRESS"; @@ -174,21 +132,30 @@ static_proto_setup(struct static_proto_state *state) goto out; if (n_v4 && tb[OPT_GATEWAY]) { - if (!parse_gateway_option(state, tb[OPT_GATEWAY], false)) + if (!parse_gateway_option(iface, tb[OPT_GATEWAY], false)) goto out; } if (n_v6 && tb[OPT_IP6GW]) { - if (!parse_gateway_option(state, tb[OPT_IP6GW], true)) + if (!parse_gateway_option(iface, tb[OPT_IP6GW], true)) goto out; } - return true; + if (tb[OPT_DNS]) + interface_add_dns_server_list(iface, tb[OPT_DNS]); + + return 0; error: - interface_add_error(state->iface, "proto-static", error, NULL, 0); + interface_add_error(iface, "proto-static", error, NULL, 0); out: - return false; + return -1; +} + +static bool +static_proto_setup(struct static_proto_state *state) +{ + return proto_apply_static_settings(state->proto.iface, state->config) == 0; } static int @@ -202,12 +169,11 @@ static_handler(struct interface_proto_state *proto, switch (cmd) { case PROTO_CMD_SETUP: - if (static_proto_setup(state)) - break; + if (!static_proto_setup(state)) + return -1; - /* fall through */ + break; case PROTO_CMD_TEARDOWN: - interface_del_ctx_addr(state->iface, state); break; } return ret; @@ -233,15 +199,13 @@ static_attach(const struct proto_handler *h, struct interface *iface, if (!state) return NULL; - state->iface = iface; state->config = malloc(blob_pad_len(attr)); if (!state->config) goto error; memcpy(state->config, attr, blob_pad_len(attr)); state->proto.free = static_free; - state->proto.handler = static_handler; - state->proto.flags = PROTO_FLAG_IMMEDIATE; + state->proto.cb = static_handler; return &state->proto; @@ -252,6 +216,7 @@ error: static struct proto_handler static_proto = { .name = "static", + .flags = PROTO_FLAG_IMMEDIATE, .config_params = &static_attr_list, .attach = static_attach, };