X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=proto-shell.c;h=ef56aa808fc33e39fdf95a8bee50ecc35ec49316;hp=2a5eda0144d37f3a2327af015ab4d595265b4d66;hb=5fbd904e5b4ed87243c09c86adcfb17ae93aa4f5;hpb=c173c610044890c539584f3beb927e71ff83c198

diff --git a/proto-shell.c b/proto-shell.c
index 2a5eda0..ef56aa8 100644
--- a/proto-shell.c
+++ b/proto-shell.c
@@ -16,21 +16,18 @@
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <glob.h>
-#include <unistd.h>
-#include <fcntl.h>
 #include <signal.h>
 
 #include <arpa/inet.h>
 #include <netinet/in.h>
 
-#include <libubox/blobmsg_json.h>
 
 #include "netifd.h"
 #include "interface.h"
 #include "interface-ip.h"
 #include "proto.h"
 #include "system.h"
+#include "handler.h"
 
 static int proto_fd = -1;
 
@@ -44,10 +41,11 @@ enum proto_shell_sm {
 struct proto_shell_handler {
 	struct list_head list;
 	struct proto_handler proto;
-	struct config_param_list config;
 	char *config_buf;
+	char *script_name;
 	bool init_available;
-	char script_name[];
+
+	struct uci_blob_param_list config;
 };
 
 struct proto_shell_dependency {
@@ -58,6 +56,9 @@ struct proto_shell_dependency {
 
 	union if_addr host;
 	bool v6;
+	bool any;
+
+	char interface[];
 };
 
 struct proto_shell_state {
@@ -67,11 +68,21 @@ struct proto_shell_state {
 
 	struct uloop_timeout teardown_timeout;
 
+	/*
+	 * Teardown and setup interface again if it is still not up (IFS_UP)
+	 * after checkup_interval seconds since previous attempt.  This check
+	 * will be disabled when the config option "checkup_interval" is
+	 * missing or has a negative value
+	 */
+	int checkup_interval;
+	struct uloop_timeout checkup_timeout;
+
 	struct netifd_process script_task;
 	struct netifd_process proto_task;
 
 	enum proto_shell_sm sm;
 	bool proto_task_killed;
+	bool renew_pending;
 
 	int last_error;
 
@@ -105,12 +116,21 @@ proto_shell_if_down_cb(struct interface_user *dep, struct interface *iface,
 static void
 proto_shell_update_host_dep(struct proto_shell_dependency *dep)
 {
-	struct interface *iface;
+	struct interface *iface = NULL;
 
 	if (dep->dep.iface)
 		goto out;
 
-	iface = interface_ip_add_target_route(&dep->host, dep->v6);
+	if (dep->interface[0]) {
+		iface = vlist_find(&interfaces, dep->interface, iface, node);
+
+		if (!iface || iface->state != IFS_UP)
+			goto out;
+	}
+
+	if (!dep->any)
+		iface = interface_ip_add_target_route(&dep->host, dep->v6, iface);
+
 	if (!iface)
 		goto out;
 
@@ -153,33 +173,66 @@ proto_shell_handler(struct interface_proto_state *proto,
 	proc = &state->script_task;
 
 	if (cmd == PROTO_CMD_SETUP) {
-		action = "setup";
-		state->last_error = -1;
-		proto_shell_clear_host_dep(state);
-	} else {
-		if (state->sm == S_TEARDOWN)
+		switch (state->sm) {
+		case S_IDLE:
+			action = "setup";
+			state->last_error = -1;
+			proto_shell_clear_host_dep(state);
+			state->sm = S_SETUP;
+			break;
+
+		case S_SETUP_ABORT:
+		case S_TEARDOWN:
+		case S_SETUP:
+			return 0;
+
+		default:
+			return -1;
+		}
+	} else if (cmd == PROTO_CMD_RENEW) {
+		if (!(handler->proto.flags & PROTO_FLAG_RENEW_AVAILABLE))
 			return 0;
 
 		if (state->script_task.uloop.pending) {
-			if (state->sm != S_SETUP_ABORT) {
+			state->renew_pending = true;
+			return 0;
+		}
+
+		state->renew_pending = false;
+		action = "renew";
+	} else {
+		switch (state->sm) {
+		case S_SETUP:
+			if (state->script_task.uloop.pending) {
 				uloop_timeout_set(&state->teardown_timeout, 1000);
 				kill(state->script_task.uloop.pid, SIGTERM);
 				if (state->proto_task.uloop.pending)
 					kill(state->proto_task.uloop.pid, SIGTERM);
+				state->renew_pending = false;
 				state->sm = S_SETUP_ABORT;
+				return 0;
+			}
+		/* fall through if no script task is running */
+		case S_IDLE:
+			action = "teardown";
+			state->renew_pending = false;
+			state->sm = S_TEARDOWN;
+			if (state->last_error >= 0) {
+				snprintf(error_buf, sizeof(error_buf), "ERROR=%d", state->last_error);
+				envp[j++] = error_buf;
 			}
+			uloop_timeout_set(&state->teardown_timeout, 5000);
+			break;
+
+		case S_TEARDOWN:
 			return 0;
-		}
 
-		action = "teardown";
-		state->sm = S_TEARDOWN;
-		if (state->last_error >= 0) {
-			snprintf(error_buf, sizeof(error_buf), "ERROR=%d", state->last_error);
-			envp[j++] = error_buf;
+		default:
+			return -1;
 		}
-		uloop_timeout_set(&state->teardown_timeout, 5000);
 	}
 
+	D(INTERFACE, "run %s for interface '%s'\n", action, proto->iface->name);
 	config = blobmsg_format_json(state->config, true);
 	if (!config)
 		return -1;
@@ -206,7 +259,7 @@ proto_shell_if_up_cb(struct interface_user *dep, struct interface *iface,
 {
 	struct proto_shell_dependency *pdep;
 
-	if (ev != IFEV_UP)
+	if (ev != IFEV_UP && ev != IFEV_UPDATE)
 		return;
 
 	pdep = container_of(dep, struct proto_shell_dependency, dep);
@@ -220,7 +273,7 @@ proto_shell_if_down_cb(struct interface_user *dep, struct interface *iface,
 	struct proto_shell_dependency *pdep;
 	struct proto_shell_state *state;
 
-	if (ev == IFEV_UP)
+	if (ev == IFEV_UP || ev == IFEV_UPDATE)
 		return;
 
 	pdep = container_of(dep, struct proto_shell_dependency, dep);
@@ -248,6 +301,23 @@ proto_shell_task_finish(struct proto_shell_state *state,
 		if (task == &state->proto_task)
 			proto_shell_handler(&state->proto, PROTO_CMD_TEARDOWN,
 					    false);
+		else if (task == &state->script_task) {
+			if (state->renew_pending)
+				proto_shell_handler(&state->proto,
+						    PROTO_CMD_RENEW, false);
+			else if (!(state->handler->proto.flags & PROTO_FLAG_NO_TASK) &&
+				 !state->proto_task.uloop.pending &&
+				 state->sm == S_SETUP)
+				proto_shell_handler(&state->proto,
+						    PROTO_CMD_TEARDOWN,
+						    false);
+
+			/* check up status after setup attempt by this script_task */
+			if (state->sm == S_SETUP && state->checkup_interval > 0) {
+				uloop_timeout_set(&state->checkup_timeout,
+						  state->checkup_interval * 1000);
+			}
+		}
 		break;
 
 	case S_SETUP_ABORT:
@@ -255,7 +325,9 @@ proto_shell_task_finish(struct proto_shell_state *state,
 		    state->proto_task.uloop.pending)
 			break;
 
+		/* completed aborting all tasks, now idle */
 		uloop_timeout_cancel(&state->teardown_timeout);
+		uloop_timeout_cancel(&state->checkup_timeout);
 		state->sm = S_IDLE;
 		proto_shell_handler(&state->proto, PROTO_CMD_TEARDOWN, false);
 		break;
@@ -270,7 +342,9 @@ proto_shell_task_finish(struct proto_shell_state *state,
 			break;
 		}
 
+		/* completed tearing down all tasks, now idle */
 		uloop_timeout_cancel(&state->teardown_timeout);
+		uloop_timeout_cancel(&state->checkup_timeout);
 		state->sm = S_IDLE;
 		state->proto.proto_event(&state->proto, IFPEV_DOWN);
 		break;
@@ -317,6 +391,8 @@ proto_shell_free(struct interface_proto_state *proto)
 	struct proto_shell_state *state;
 
 	state = container_of(proto, struct proto_shell_state, proto);
+	uloop_timeout_cancel(&state->teardown_timeout);
+	uloop_timeout_cancel(&state->checkup_timeout);
 	proto_shell_clear_host_dep(state);
 	netifd_kill_process(&state->script_task);
 	netifd_kill_process(&state->proto_task);
@@ -419,6 +495,9 @@ proto_shell_update_link(struct proto_shell_state *state, struct blob_attr *data,
 	bool keep = false;
 	bool up;
 
+	if (state->sm == S_TEARDOWN || state->sm == S_SETUP_ABORT)
+		return UBUS_STATUS_PERMISSION_DENIED;
+
 	if (!tb[NOTIFY_LINK_UP])
 		return UBUS_STATUS_INVALID_ARGUMENT;
 
@@ -437,30 +516,31 @@ proto_shell_update_link(struct proto_shell_state *state, struct blob_attr *data,
 			dev_create = 2;
 	}
 
-	if (!tb[NOTIFY_IFNAME]) {
-		if (!iface->main_dev.dev)
-			return UBUS_STATUS_INVALID_ARGUMENT;
-	} else if (!keep || iface->state != IFS_UP) {
+	if (iface->state != IFS_UP || !iface->l3_dev.dev)
 		keep = false;
-		devname = blobmsg_data(tb[NOTIFY_IFNAME]);
-		if (tb[NOTIFY_TUNNEL]) {
-			dev = proto_shell_create_tunnel(devname,
-				tb[NOTIFY_TUNNEL]);
-			if (!dev)
-				return UBUS_STATUS_INVALID_ARGUMENT;
-		} else {
-			dev = device_get(devname, dev_create);
-			if (!dev)
-				return UBUS_STATUS_NOT_FOUND;
+
+	if (!keep) {
+		dev = iface->main_dev.dev;
+		if (tb[NOTIFY_IFNAME]) {
+			keep = false;
+			devname = blobmsg_data(tb[NOTIFY_IFNAME]);
+			if (tb[NOTIFY_TUNNEL])
+				dev = proto_shell_create_tunnel(devname, tb[NOTIFY_TUNNEL]);
+			else
+				dev = device_get(devname, dev_create);
 		}
 
+		if (!dev)
+			return UBUS_STATUS_INVALID_ARGUMENT;
+
 		interface_set_l3_dev(iface, dev);
-		device_claim(&iface->l3_dev);
+		if (device_claim(&iface->l3_dev) < 0)
+			return UBUS_STATUS_UNKNOWN_ERROR;
+
 		device_set_present(dev, true);
 	}
 
-	if (!keep)
-		interface_update_start(iface);
+	interface_update_start(iface, keep);
 
 	proto_apply_ip_settings(iface, data, addr_ext);
 
@@ -476,14 +556,15 @@ proto_shell_update_link(struct proto_shell_state *state, struct blob_attr *data,
 	if ((cur = tb[NOTIFY_DNS_SEARCH]))
 		interface_add_dns_search_list(&iface->proto_ip, cur);
 
+	if ((cur = tb[NOTIFY_DATA]))
+		proto_shell_parse_data(state->proto.iface, cur);
+
 	interface_update_complete(state->proto.iface);
 
-	if (!keep)
+	if ((state->sm != S_SETUP_ABORT) && (state->sm != S_TEARDOWN)) {
 		state->proto.proto_event(&state->proto, IFPEV_UP);
-	state->sm = S_IDLE;
-
-	if ((cur = tb[NOTIFY_DATA]))
-		proto_shell_parse_data(state->proto.iface, cur);
+		state->sm = S_IDLE;
+	}
 
 	return 0;
 }
@@ -521,6 +602,9 @@ proto_shell_run_command(struct proto_shell_state *state, struct blob_attr **tb)
 	static char *argv[64];
 	static char *env[32];
 
+	if (state->sm == S_TEARDOWN || state->sm == S_SETUP_ABORT)
+		return UBUS_STATUS_PERMISSION_DENIED;
+
 	if (!tb[NOTIFY_COMMAND])
 		goto error;
 
@@ -550,7 +634,8 @@ proto_shell_kill_command(struct proto_shell_state *state, struct blob_attr **tb)
 		signal = SIGTERM;
 
 	if (state->proto_task.uloop.pending) {
-		state->proto_task_killed = true;
+		if (signal == SIGTERM || signal == SIGKILL)
+			state->proto_task_killed = true;
 		kill(state->proto_task.uloop.pid, signal);
 	}
 
@@ -614,18 +699,30 @@ static int
 proto_shell_add_host_dependency(struct proto_shell_state *state, struct blob_attr **tb)
 {
 	struct proto_shell_dependency *dep;
-	struct blob_attr *host = tb[NOTIFY_HOST];
+	const char *ifname = tb[NOTIFY_IFNAME] ? blobmsg_data(tb[NOTIFY_IFNAME]) : "";
+	const char *host = tb[NOTIFY_HOST] ? blobmsg_data(tb[NOTIFY_HOST]) : "";
 
-	if (!host)
-		return UBUS_STATUS_INVALID_ARGUMENT;
+	if (state->sm == S_TEARDOWN || state->sm == S_SETUP_ABORT)
+		return UBUS_STATUS_PERMISSION_DENIED;
 
-	dep = calloc(1, sizeof(*dep));
-	if (!inet_pton(AF_INET, blobmsg_data(host), &dep->host)) {
-		free(dep);
-		return UBUS_STATUS_INVALID_ARGUMENT;
+	dep = calloc(1, sizeof(*dep) + strlen(ifname) + 1);
+	if (!dep)
+		return UBUS_STATUS_UNKNOWN_ERROR;
+
+	if (!host[0] && ifname[0]) {
+		dep->any = true;
+	} else if (inet_pton(AF_INET, host, &dep->host) < 1) {
+		if (inet_pton(AF_INET6, host, &dep->host) < 1) {
+			free(dep);
+			return UBUS_STATUS_INVALID_ARGUMENT;
+		} else {
+			dep->v6 = true;
+		}
 	}
 
 	dep->proto = state;
+	strcpy(dep->interface, ifname);
+
 	dep->dep.cb = proto_shell_if_up_cb;
 	interface_add_user(&dep->dep, NULL);
 	list_add(&dep->list, &state->deps);
@@ -639,6 +736,8 @@ proto_shell_add_host_dependency(struct proto_shell_state *state, struct blob_att
 static int
 proto_shell_setup_failed(struct proto_shell_state *state)
 {
+	int ret = 0;
+
 	switch (state->sm) {
 	case S_IDLE:
 		state->proto.proto_event(&state->proto, IFPEV_LINK_LOST);
@@ -646,10 +745,13 @@ proto_shell_setup_failed(struct proto_shell_state *state)
 	case S_SETUP:
 		proto_shell_handler(&state->proto, PROTO_CMD_TEARDOWN, false);
 		break;
+	case S_SETUP_ABORT:
+	case S_TEARDOWN:
 	default:
+		ret = UBUS_STATUS_PERMISSION_DENIED;
 		break;
 	}
-	return 0;
+	return ret;
 }
 
 static int
@@ -686,6 +788,45 @@ proto_shell_notify(struct interface_proto_state *proto, struct blob_attr *attr)
 	}
 }
 
+static void
+proto_shell_checkup_timeout_cb(struct uloop_timeout *timeout)
+{
+	struct proto_shell_state *state = container_of(timeout, struct
+			proto_shell_state, checkup_timeout);
+	struct interface_proto_state *proto = &state->proto;
+	struct interface *iface = proto->iface;
+
+	if (!iface->autostart)
+		return;
+
+	if (iface->state == IFS_UP)
+		return;
+
+	D(INTERFACE, "Interface '%s' is not up after %d sec\n",
+			iface->name, state->checkup_interval);
+	proto_shell_handler(proto, PROTO_CMD_TEARDOWN, false);
+}
+
+static void
+proto_shell_checkup_attach(struct proto_shell_state *state,
+		const struct blob_attr *attr)
+{
+	struct blob_attr *tb;
+	struct blobmsg_policy checkup_policy = {
+		.name = "checkup_interval",
+		.type = BLOBMSG_TYPE_INT32
+	};
+
+	blobmsg_parse(&checkup_policy, 1, &tb, blob_data(attr), blob_len(attr));
+	if (!tb) {
+		state->checkup_interval = -1;
+		state->checkup_timeout.cb = NULL;
+	} else {
+		state->checkup_interval = blobmsg_get_u32(tb);
+		state->checkup_timeout.cb = proto_shell_checkup_timeout_cb;
+	}
+}
+
 static struct interface_proto_state *
 proto_shell_attach(const struct proto_handler *h, struct interface *iface,
 		   struct blob_attr *attr)
@@ -693,6 +834,9 @@ proto_shell_attach(const struct proto_handler *h, struct interface *iface,
 	struct proto_shell_state *state;
 
 	state = calloc(1, sizeof(*state));
+	if (!state)
+		return NULL;
+
 	INIT_LIST_HEAD(&state->deps);
 
 	state->config = malloc(blob_pad_len(attr));
@@ -700,6 +844,7 @@ proto_shell_attach(const struct proto_handler *h, struct interface *iface,
 		goto error;
 
 	memcpy(state->config, attr, blob_pad_len(attr));
+	proto_shell_checkup_attach(state, state->config);
 	state->proto.free = proto_shell_free;
 	state->proto.notify = proto_shell_notify;
 	state->proto.cb = proto_shell_handler;
@@ -719,205 +864,64 @@ error:
 	return NULL;
 }
 
-static json_object *
-check_type(json_object *obj, json_type type)
-{
-	if (!obj)
-		return NULL;
-
-	if (json_object_get_type(obj) != type)
-		return NULL;
-
-	return obj;
-}
-
-static inline json_object *
-get_field(json_object *obj, const char *name, json_type type)
-{
-	return check_type(json_object_object_get(obj, name), type);
-}
-
-static char *
-proto_shell_parse_config(struct config_param_list *config, json_object *obj)
-{
-	struct blobmsg_policy *attrs;
-	char *str_buf, *str_cur;
-	int str_len = 0;
-	int i;
-
-	config->n_params = json_object_array_length(obj);
-	attrs = calloc(1, sizeof(*attrs) * config->n_params);
-	if (!attrs)
-		return NULL;
-
-	config->params = attrs;
-	for (i = 0; i < config->n_params; i++) {
-		json_object *cur, *name, *type;
-
-		cur = check_type(json_object_array_get_idx(obj, i), json_type_array);
-		if (!cur)
-			goto error;
-
-		name = check_type(json_object_array_get_idx(cur, 0), json_type_string);
-		if (!name)
-			goto error;
-
-		type = check_type(json_object_array_get_idx(cur, 1), json_type_int);
-		if (!type)
-			goto error;
-
-		attrs[i].name = json_object_get_string(name);
-		attrs[i].type = json_object_get_int(type);
-		if (attrs[i].type > BLOBMSG_TYPE_LAST)
-			goto error;
-
-		str_len += strlen(attrs[i].name) + 1;
-	}
-
-	str_buf = malloc(str_len);
-	if (!str_buf)
-		goto error;
-
-	str_cur = str_buf;
-	for (i = 0; i < config->n_params; i++) {
-		const char *name = attrs[i].name;
-
-		attrs[i].name = str_cur;
-		str_cur += sprintf(str_cur, "%s", name) + 1;
-	}
-
-	return str_buf;
-
-error:
-	free(attrs);
-	config->n_params = 0;
-	return NULL;
-}
-
 static void
-proto_shell_add_handler(const char *script, json_object *obj)
+proto_shell_add_handler(const char *script, const char *name, json_object *obj)
 {
 	struct proto_shell_handler *handler;
 	struct proto_handler *proto;
 	json_object *config, *tmp;
-	const char *name;
-	char *str;
-
-	if (!check_type(obj, json_type_object))
-		return;
+	char *proto_name, *script_name;
 
-	tmp = get_field(obj, "name", json_type_string);
-	if (!tmp)
-		return;
-
-	name = json_object_get_string(tmp);
-
-	handler = calloc(1, sizeof(*handler) +
-			 strlen(script) + 1 +
-			 strlen(name) + 1);
+	handler = calloc_a(sizeof(*handler),
+			   &proto_name, strlen(name) + 1,
+			   &script_name, strlen(script) + 1);
 	if (!handler)
 		return;
 
-	strcpy(handler->script_name, script);
-
-	str = handler->script_name + strlen(handler->script_name) + 1;
-	strcpy(str, name);
+	handler->script_name = strcpy(script_name, script);
 
 	proto = &handler->proto;
-	proto->name = str;
+	proto->name = strcpy(proto_name, name);
 	proto->config_params = &handler->config;
 	proto->attach = proto_shell_attach;
 
-	tmp = get_field(obj, "no-device", json_type_boolean);
+	tmp = json_get_field(obj, "no-device", json_type_boolean);
 	if (tmp && json_object_get_boolean(tmp))
 		handler->proto.flags |= PROTO_FLAG_NODEV;
 
-	tmp = get_field(obj, "available", json_type_boolean);
+	tmp = json_get_field(obj, "no-proto-task", json_type_boolean);
 	if (tmp && json_object_get_boolean(tmp))
-		handler->proto.flags |= PROTO_FLAG_INIT_AVAILABLE;
-
-	config = get_field(obj, "config", json_type_array);
-	if (config)
-		handler->config_buf = proto_shell_parse_config(&handler->config, config);
-
-	DPRINTF("Add handler for script %s: %s\n", script, proto->name);
-	add_proto_handler(proto);
-}
-
-static void proto_shell_add_script(const char *name)
-{
-	struct json_tokener *tok = NULL;
-	json_object *obj;
-	static char buf[512];
-	char *start, *cmd;
-	FILE *f;
-	int len;
-
-#define DUMP_SUFFIX	" '' dump"
+		handler->proto.flags |= PROTO_FLAG_NO_TASK;
 
-	cmd = alloca(strlen(name) + 1 + sizeof(DUMP_SUFFIX));
-	sprintf(cmd, "%s" DUMP_SUFFIX, name);
-
-	f = popen(cmd, "r");
-	if (!f)
-		return;
-
-	do {
-		start = fgets(buf, sizeof(buf), f);
-		if (!start)
-			continue;
+	tmp = json_get_field(obj, "available", json_type_boolean);
+	if (tmp && json_object_get_boolean(tmp))
+		handler->proto.flags |= PROTO_FLAG_INIT_AVAILABLE;
 
-		len = strlen(start);
+	tmp = json_get_field(obj, "renew-handler", json_type_boolean);
+	if (tmp && json_object_get_boolean(tmp))
+		handler->proto.flags |= PROTO_FLAG_RENEW_AVAILABLE;
 
-		if (!tok)
-			tok = json_tokener_new();
+	tmp = json_get_field(obj, "lasterror", json_type_boolean);
+	if (tmp && json_object_get_boolean(tmp))
+		handler->proto.flags |= PROTO_FLAG_LASTERROR;
 
-		obj = json_tokener_parse_ex(tok, start, len);
-		if (!is_error(obj)) {
-			proto_shell_add_handler(name, obj);
-			json_object_put(obj);
-			json_tokener_free(tok);
-			tok = NULL;
-		} else if (start[len - 1] == '\n') {
-			json_tokener_free(tok);
-			tok = NULL;
-		}
-	} while (!feof(f) && !ferror(f));
+	tmp = json_get_field(obj, "teardown-on-l3-link-down", json_type_boolean);
+	if (tmp && json_object_get_boolean(tmp))
+		handler->proto.flags |= PROTO_FLAG_TEARDOWN_ON_L3_LINK_DOWN;
 
-	if (tok)
-		json_tokener_free(tok);
+	config = json_get_field(obj, "config", json_type_array);
+	if (config)
+		handler->config_buf = netifd_handler_parse_config(&handler->config, config);
 
-	pclose(f);
+	DPRINTF("Add handler for script %s: %s\n", script, proto->name);
+	add_proto_handler(proto);
 }
 
-static void __init proto_shell_init(void)
+void proto_shell_init(void)
 {
-	glob_t g;
-	int main_fd;
-	int i;
-
-	main_fd = open(".", O_RDONLY | O_DIRECTORY);
-	if (main_fd < 0)
-		return;
-
-	if (chdir(main_path)) {
-		perror("chdir(main path)");
-		goto close_cur;
-	}
-
-	if (chdir("./proto"))
-		goto close_cur;
-
-	proto_fd = open(".", O_RDONLY | O_DIRECTORY);
+	proto_fd = netifd_open_subdir("proto");
 	if (proto_fd < 0)
-		goto close_cur;
-
-	system_fd_set_cloexec(proto_fd);
-	glob("./*.sh", 0, NULL, &g);
-	for (i = 0; i < g.gl_pathc; i++)
-		proto_shell_add_script(g.gl_pathv[i]);
+		return;
 
-close_cur:
-	fchdir(main_fd);
-	close(main_fd);
+	netifd_init_script_handlers(proto_fd, proto_shell_add_handler);
 }