X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=proto-shell.c;h=8a3ff69bedd0f16ae5b2079435b6777046df9787;hp=bac57e03176c8876ffa53d948b709a83986cf077;hb=1488a64acb77f721fc10d90b0453d95b488460e1;hpb=edb414294c06fb9d275c9f3be2282283453a46d0 diff --git a/proto-shell.c b/proto-shell.c index bac57e0..8a3ff69 100644 --- a/proto-shell.c +++ b/proto-shell.c @@ -52,12 +52,14 @@ struct proto_shell_handler { struct proto_shell_dependency { struct list_head list; - char *interface; struct proto_shell_state *proto; struct interface_user dep; union if_addr host; bool v6; + bool any; + + char interface[]; }; struct proto_shell_state { @@ -67,6 +69,15 @@ struct proto_shell_state { struct uloop_timeout teardown_timeout; + /* + * Teardown and setup interface again if it is still not up (IFS_UP) + * after checkup_interval seconds since previous attempt. This check + * will be disabled when the config option "checkup_interval" is + * missing or has a negative value + */ + int checkup_interval; + struct uloop_timeout checkup_timeout; + struct netifd_process script_task; struct netifd_process proto_task; @@ -111,10 +122,16 @@ proto_shell_update_host_dep(struct proto_shell_dependency *dep) if (dep->dep.iface) goto out; - if (dep->interface[0]) + if (dep->interface[0]) { iface = vlist_find(&interfaces, dep->interface, iface, node); - iface = interface_ip_add_target_route(&dep->host, dep->v6, iface); + if (!iface || iface->state != IFS_UP) + goto out; + } + + if (!dep->any) + iface = interface_ip_add_target_route(&dep->host, dep->v6, iface); + if (!iface) goto out; @@ -295,6 +312,12 @@ proto_shell_task_finish(struct proto_shell_state *state, proto_shell_handler(&state->proto, PROTO_CMD_TEARDOWN, false); + + /* check up status after setup attempt by this script_task */ + if (state->sm == S_SETUP && state->checkup_interval > 0) { + uloop_timeout_set(&state->checkup_timeout, + state->checkup_interval * 1000); + } } break; @@ -303,7 +326,9 @@ proto_shell_task_finish(struct proto_shell_state *state, state->proto_task.uloop.pending) break; + /* completed aborting all tasks, now idle */ uloop_timeout_cancel(&state->teardown_timeout); + uloop_timeout_cancel(&state->checkup_timeout); state->sm = S_IDLE; proto_shell_handler(&state->proto, PROTO_CMD_TEARDOWN, false); break; @@ -318,7 +343,9 @@ proto_shell_task_finish(struct proto_shell_state *state, break; } + /* completed tearing down all tasks, now idle */ uloop_timeout_cancel(&state->teardown_timeout); + uloop_timeout_cancel(&state->checkup_timeout); state->sm = S_IDLE; state->proto.proto_event(&state->proto, IFPEV_DOWN); break; @@ -366,6 +393,7 @@ proto_shell_free(struct interface_proto_state *proto) state = container_of(proto, struct proto_shell_state, proto); uloop_timeout_cancel(&state->teardown_timeout); + uloop_timeout_cancel(&state->checkup_timeout); proto_shell_clear_host_dep(state); netifd_kill_process(&state->script_task); netifd_kill_process(&state->proto_task); @@ -673,20 +701,18 @@ static int proto_shell_add_host_dependency(struct proto_shell_state *state, struct blob_attr **tb) { struct proto_shell_dependency *dep; - struct blob_attr *host = tb[NOTIFY_HOST]; - struct blob_attr *ifname_a = tb[NOTIFY_IFNAME]; - const char *ifname_str = ifname_a ? blobmsg_data(ifname_a) : ""; - char *ifname; + const char *ifname = tb[NOTIFY_IFNAME] ? blobmsg_data(tb[NOTIFY_IFNAME]) : ""; + const char *host = tb[NOTIFY_HOST] ? blobmsg_data(tb[NOTIFY_HOST]) : ""; if (state->sm == S_TEARDOWN || state->sm == S_SETUP_ABORT) return UBUS_STATUS_PERMISSION_DENIED; - if (!host) - return UBUS_STATUS_INVALID_ARGUMENT; + dep = calloc(1, sizeof(*dep) + strlen(ifname) + 1); - dep = calloc_a(sizeof(*dep), &ifname, strlen(ifname_str) + 1); - if (inet_pton(AF_INET, blobmsg_data(host), &dep->host) < 1) { - if (inet_pton(AF_INET6, blobmsg_data(host), &dep->host) < 1) { + if (!host[0] && ifname[0]) { + dep->any = true; + } else if (inet_pton(AF_INET, host, &dep->host) < 1) { + if (inet_pton(AF_INET6, host, &dep->host) < 1) { free(dep); return UBUS_STATUS_INVALID_ARGUMENT; } else { @@ -695,7 +721,7 @@ proto_shell_add_host_dependency(struct proto_shell_state *state, struct blob_att } dep->proto = state; - dep->interface = strcpy(ifname, ifname_str); + strcpy(dep->interface, ifname); dep->dep.cb = proto_shell_if_up_cb; interface_add_user(&dep->dep, NULL); @@ -762,6 +788,45 @@ proto_shell_notify(struct interface_proto_state *proto, struct blob_attr *attr) } } +static void +proto_shell_checkup_timeout_cb(struct uloop_timeout *timeout) +{ + struct proto_shell_state *state = container_of(timeout, struct + proto_shell_state, checkup_timeout); + struct interface_proto_state *proto = &state->proto; + struct interface *iface = proto->iface; + + if (!iface->autostart) + return; + + if (iface->state == IFS_UP) + return; + + D(INTERFACE, "Interface '%s' is not up after %d sec\n", + iface->name, state->checkup_interval); + proto_shell_handler(proto, PROTO_CMD_TEARDOWN, false); +} + +static void +proto_shell_checkup_attach(struct proto_shell_state *state, + const struct blob_attr *attr) +{ + struct blob_attr *tb; + struct blobmsg_policy checkup_policy = { + .name = "checkup_interval", + .type = BLOBMSG_TYPE_INT32 + }; + + blobmsg_parse(&checkup_policy, 1, &tb, blob_data(attr), blob_len(attr)); + if (!tb) { + state->checkup_interval = -1; + state->checkup_timeout.cb = NULL; + } else { + state->checkup_interval = blobmsg_get_u32(tb); + state->checkup_timeout.cb = proto_shell_checkup_timeout_cb; + } +} + static struct interface_proto_state * proto_shell_attach(const struct proto_handler *h, struct interface *iface, struct blob_attr *attr) @@ -776,6 +841,7 @@ proto_shell_attach(const struct proto_handler *h, struct interface *iface, goto error; memcpy(state->config, attr, blob_pad_len(attr)); + proto_shell_checkup_attach(state, state->config); state->proto.free = proto_shell_free; state->proto.notify = proto_shell_notify; state->proto.cb = proto_shell_handler;