X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=interface.c;h=01dabad8047edd7ef8a6a0c9b63ae7c0d9084d35;hp=0aa0b0d08c1d9d866c2130858fbd01551f1cf71e;hb=6094417533d97662f693d134ab04595a292de30c;hpb=f62eea9492a669bcf96464e85f04ae5e80190a76

diff --git a/interface.c b/interface.c
index 0aa0b0d..01dabad 100644
--- a/interface.c
+++ b/interface.c
@@ -1,14 +1,69 @@
+/*
+ * netifd - network interface daemon
+ * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
 
 #include "netifd.h"
+#include "device.h"
+#include "interface.h"
+#include "interface-ip.h"
+#include "proto.h"
 #include "ubus.h"
-
-LIST_HEAD(interfaces);
+#include "config.h"
+#include "system.h"
+
+struct vlist_tree interfaces;
+static LIST_HEAD(iface_all_users);
+
+enum {
+	IFACE_ATTR_IFNAME,
+	IFACE_ATTR_PROTO,
+	IFACE_ATTR_AUTO,
+	IFACE_ATTR_DEFAULTROUTE,
+	IFACE_ATTR_PEERDNS,
+	IFACE_ATTR_DNS,
+	IFACE_ATTR_DNS_SEARCH,
+	IFACE_ATTR_METRIC,
+	IFACE_ATTR_INTERFACE,
+	IFACE_ATTR_MAX
+};
+
+static const struct blobmsg_policy iface_attrs[IFACE_ATTR_MAX] = {
+	[IFACE_ATTR_PROTO] = { .name = "proto", .type = BLOBMSG_TYPE_STRING },
+	[IFACE_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_STRING },
+	[IFACE_ATTR_AUTO] = { .name = "auto", .type = BLOBMSG_TYPE_BOOL },
+	[IFACE_ATTR_DEFAULTROUTE] = { .name = "defaultroute", .type = BLOBMSG_TYPE_BOOL },
+	[IFACE_ATTR_PEERDNS] = { .name = "peerdns", .type = BLOBMSG_TYPE_BOOL },
+	[IFACE_ATTR_METRIC] = { .name = "metric", .type = BLOBMSG_TYPE_INT32 },
+	[IFACE_ATTR_DNS] = { .name = "dns", .type = BLOBMSG_TYPE_ARRAY },
+	[IFACE_ATTR_DNS_SEARCH] = { .name = "dns_search", .type = BLOBMSG_TYPE_ARRAY },
+	[IFACE_ATTR_INTERFACE] = { .name = "interface", .type = BLOBMSG_TYPE_STRING },
+};
+
+static const union config_param_info iface_attr_info[IFACE_ATTR_MAX] = {
+	[IFACE_ATTR_DNS] = { .type = BLOBMSG_TYPE_STRING },
+};
+
+const struct config_param_list interface_attr_list = {
+	.n_params = IFACE_ATTR_MAX,
+	.params = iface_attrs,
+	.info = iface_attr_info,
+};
 
 static void
-clear_interface_errors(struct interface *iface)
+interface_clear_errors(struct interface *iface)
 {
 	struct interface_error *error, *tmp;
 
@@ -23,7 +78,7 @@ void interface_add_error(struct interface *iface, const char *subsystem,
 {
 	struct interface_error *error;
 	int i, len = 0;
-	int *datalen;
+	int *datalen = NULL;
 	char *dest;
 
 	if (n_data) {
@@ -52,43 +107,93 @@ void interface_add_error(struct interface *iface, const char *subsystem,
 	error->data[n_data] = NULL;
 }
 
-static int
-interface_event(struct interface *iface, enum interface_event ev)
+static void
+interface_data_del(struct interface *iface, struct interface_data *data)
 {
-	if (!iface->state || !iface->state->event)
-		return 0;
+	avl_delete(&iface->data, &data->node);
+	free(data);
+}
+
+static void
+interface_data_flush(struct interface *iface)
+{
+	struct interface_data *d, *tmp;
 
-	return iface->state->event(iface->state, ev);
+	avl_for_each_element_safe(&iface->data, d, node, tmp)
+		interface_data_del(iface, d);
+}
+
+int
+interface_add_data(struct interface *iface, const struct blob_attr *data)
+{
+	struct interface_data *n, *o;
+
+	if (!blobmsg_check_attr(data, true))
+		return UBUS_STATUS_INVALID_ARGUMENT;
+
+	n = calloc(1, sizeof(*n) + blob_pad_len(data));
+	memcpy(n->data, data, blob_pad_len(data));
+	n->node.key = blobmsg_name(data);
+
+	o = avl_find_element(&iface->data, n->node.key, o, node);
+	if (o)
+		interface_data_del(iface, o);
+
+	avl_insert(&iface->data, &n->node);
+	return 0;
 }
 
 static void
-__set_interface_up(struct interface *iface)
+interface_event(struct interface *iface, enum interface_event ev)
 {
-	if (iface->up)
-		return;
+	struct interface_user *dep, *tmp;
 
-	if (claim_device(iface->main_dev.dev) < 0)
-		return;
+	list_for_each_entry_safe(dep, tmp, &iface->users, list)
+		dep->cb(dep, iface, ev);
 
-	if (interface_event(iface, IFEV_UP) < 0) {
-		release_device(iface->main_dev.dev);
-		return;
-	}
+	list_for_each_entry_safe(dep, tmp, &iface_all_users, list)
+		dep->cb(dep, iface, ev);
+}
 
-	iface->up = true;
+static void
+interface_flush_state(struct interface *iface)
+{
+	if (iface->main_dev.dev)
+		device_release(&iface->main_dev);
+	if (iface->l3_dev.dev)
+		device_release(&iface->l3_dev);
+	interface_data_flush(iface);
 }
 
 static void
-__set_interface_down(struct interface *iface)
+mark_interface_down(struct interface *iface)
 {
-	clear_interface_errors(iface);
+	enum interface_state state = iface->state;
+
+	iface->state = IFS_DOWN;
+	if (state == IFS_UP)
+		interface_event(iface, IFEV_DOWN);
+	interface_ip_set_enabled(&iface->config_ip, false);
+	interface_ip_flush(&iface->proto_ip);
+	interface_flush_state(iface);
+	system_flush_routes();
+}
 
-	if (!iface->up)
+void
+__interface_set_down(struct interface *iface, bool force)
+{
+	interface_clear_errors(iface);
+
+	if (iface->state == IFS_DOWN ||
+		iface->state == IFS_TEARDOWN)
 		return;
 
-	iface->up = false;
-	interface_event(iface, IFEV_DOWN);
-	release_device(iface->main_dev.dev);
+	if (iface->state == IFS_UP)
+		interface_event(iface, IFEV_DOWN);
+	iface->state = IFS_TEARDOWN;
+	interface_proto_event(iface->proto, PROTO_CMD_TEARDOWN, force);
+	if (force)
+		interface_flush_state(iface);
 }
 
 static void
@@ -109,112 +214,564 @@ interface_cb(struct device_user *dep, enum device_event ev)
 		return;
 	}
 
-	if (iface->active == new_state)
+	interface_set_available(iface, new_state);
+	if (!new_state && dep->dev->external)
+		interface_set_main_dev(iface, NULL);
+}
+
+void
+interface_set_available(struct interface *iface, bool new_state)
+{
+	if (iface->available == new_state)
 		return;
 
-	iface->active = new_state;
+	D(INTERFACE, "Interface '%s', available=%d\n", iface->name, new_state);
+	iface->available = new_state;
 
 	if (new_state) {
-		if (iface->autostart)
-			__set_interface_up(iface);
+		if (iface->autostart && !config_init)
+			interface_set_up(iface);
 	} else
-		__set_interface_down(iface);
+		__interface_set_down(iface, true);
 }
 
-struct interface *
-alloc_interface(const char *name)
+void
+interface_add_user(struct interface_user *dep, struct interface *iface)
 {
-	struct interface *iface;
+	if (!iface) {
+		list_add(&dep->list, &iface_all_users);
+		return;
+	}
 
-	iface = get_interface(name);
-	if (iface)
-		return iface;
+	dep->iface = iface;
+	list_add(&dep->list, &iface->users);
+	if (iface->state == IFS_UP)
+		dep->cb(dep, iface, IFEV_UP);
+}
 
-	iface = calloc(1, sizeof(*iface));
-	iface->main_dev.cb = interface_cb;
-	iface->l3_iface = &iface->main_dev;
-	strncpy(iface->name, name, sizeof(iface->name) - 1);
-	list_add(&iface->list, &interfaces);
-	INIT_LIST_HEAD(&iface->errors);
+void
+interface_remove_user(struct interface_user *dep)
+{
+	list_del_init(&dep->list);
+	dep->iface = NULL;
+}
 
-	netifd_ubus_add_interface(iface);
+static void
+interface_alias_cb(struct interface_user *dep, struct interface *iface, enum interface_event ev)
+{
+	struct interface *alias = container_of(dep, struct interface, parent_iface);
+	struct device *dev = iface->l3_dev.dev;
 
-	return iface;
+	switch (ev) {
+	case IFEV_UP:
+		if (!dev)
+			return;
+
+		interface_set_main_dev(alias, dev);
+		interface_set_available(alias, true);
+		break;
+	case IFEV_DOWN:
+		interface_set_available(alias, false);
+		interface_set_main_dev(alias, NULL);
+		break;
+	case IFEV_FREE:
+		interface_remove_user(dep);
+		break;
+	case IFEV_RELOAD:
+		break;
+	}
 }
 
-void
-free_interface(struct interface *iface)
+static void
+interface_claim_device(struct interface *iface)
+{
+	struct interface *parent;
+	struct device *dev = NULL;
+
+	if (iface->parent_iface.iface)
+		interface_remove_user(&iface->parent_iface);
+
+	if (iface->parent_ifname) {
+		parent = vlist_find(&interfaces, iface->parent_ifname, parent, node);
+		iface->parent_iface.cb = interface_alias_cb;
+		interface_add_user(&iface->parent_iface, parent);
+	} else if (iface->ifname &&
+		!(iface->proto_handler->flags & PROTO_FLAG_NODEV)) {
+		dev = device_get(iface->ifname, true);
+	}
+
+	if (dev)
+		interface_set_main_dev(iface, dev);
+
+	if (iface->proto_handler->flags & PROTO_FLAG_INIT_AVAILABLE)
+		interface_set_available(iface, true);
+}
+
+
+static void
+interface_cleanup(struct interface *iface, bool reload)
+{
+	struct interface_user *dep, *tmp;
+
+	if (iface->parent_iface.iface)
+		interface_remove_user(&iface->parent_iface);
+
+	list_for_each_entry_safe(dep, tmp, &iface->users, list)
+		interface_remove_user(dep);
+
+	interface_ip_flush(&iface->config_ip);
+	interface_flush_state(iface);
+	interface_clear_errors(iface);
+
+	if (iface->main_dev.dev && !reload)
+		interface_set_main_dev(iface, NULL);
+	interface_set_proto_state(iface, NULL);
+}
+
+static void
+interface_do_free(struct interface *iface)
 {
+	interface_event(iface, IFEV_FREE);
+	interface_cleanup(iface, false);
+	free(iface->config);
 	netifd_ubus_remove_interface(iface);
-	list_del(&iface->list);
-	if (iface->state && iface->state->free)
-		iface->state->free(iface->state);
+	avl_delete(&interfaces.avl, &iface->node.avl);
 	free(iface);
 }
 
-struct interface *
-get_interface(const char *name)
+static void
+interface_do_reload(struct interface *iface)
 {
-	struct interface *iface;
+	interface_event(iface, IFEV_RELOAD);
+	interface_cleanup(iface, true);
+	proto_init_interface(iface, iface->config);
+	interface_claim_device(iface);
+}
+
+static void
+interface_handle_config_change(struct interface *iface)
+{
+	enum interface_config_state state = iface->config_state;
+
+	iface->config_state = IFC_NORMAL;
+	switch(state) {
+	case IFC_NORMAL:
+		break;
+	case IFC_RELOAD:
+		interface_do_reload(iface);
+		break;
+	case IFC_REMOVE:
+		interface_do_free(iface);
+		return;
+	}
+	if (iface->autostart && iface->available)
+		interface_set_up(iface);
+}
+
+static void
+interface_proto_cb(struct interface_proto_state *state, enum interface_proto_event ev)
+{
+	struct interface *iface = state->iface;
+
+	switch (ev) {
+	case IFPEV_UP:
+		if (iface->state != IFS_SETUP)
+			return;
+
+		interface_ip_set_enabled(&iface->config_ip, true);
+		system_flush_routes();
+		iface->state = IFS_UP;
+		iface->start_time = system_get_rtime();
+		interface_event(iface, IFEV_UP);
+		interface_write_resolv_conf();
+		netifd_log_message(L_NOTICE, "Interface '%s' is now up\n", iface->name);
+		break;
+	case IFPEV_DOWN:
+		if (iface->state == IFS_DOWN)
+			return;
+
+		netifd_log_message(L_NOTICE, "Interface '%s' is now down\n", iface->name);
+		mark_interface_down(iface);
+		interface_handle_config_change(iface);
+		break;
+	case IFPEV_LINK_LOST:
+		if (iface->state != IFS_UP)
+			return;
+
+		netifd_log_message(L_NOTICE, "Interface '%s' has lost the connection\n", iface->name);
+		mark_interface_down(iface);
+		iface->state = IFS_SETUP;
+		break;
+	}
+}
+
+void interface_set_proto_state(struct interface *iface, struct interface_proto_state *state)
+{
+	if (iface->proto) {
+		iface->proto->free(iface->proto);
+		iface->proto = NULL;
+	}
+	iface->state = IFS_DOWN;
+	iface->proto = state;
+	if (!state)
+		return;
+
+	state->proto_event = interface_proto_cb;
+	state->iface = iface;
+}
+
+void
+interface_init(struct interface *iface, const char *name,
+	       struct blob_attr *config)
+{
+	struct blob_attr *tb[IFACE_ATTR_MAX];
+	struct blob_attr *cur;
+	const char *proto_name = NULL;
 
-	list_for_each_entry(iface, &interfaces, list) {
-		if (!strcmp(iface->name, name))
-			return iface;
+	strncpy(iface->name, name, sizeof(iface->name) - 1);
+	INIT_LIST_HEAD(&iface->errors);
+	INIT_LIST_HEAD(&iface->users);
+	INIT_LIST_HEAD(&iface->hotplug_list);
+	interface_ip_init(iface);
+	avl_init(&iface->data, avl_strcmp, false, NULL);
+	iface->config_ip.enabled = false;
+
+	iface->main_dev.cb = interface_cb;
+
+	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb,
+		      blob_data(config), blob_len(config));
+
+	if ((cur = tb[IFACE_ATTR_PROTO]))
+		proto_name = blobmsg_data(cur);
+
+	proto_attach_interface(iface, proto_name);
+
+	iface->autostart = blobmsg_get_bool_default(tb[IFACE_ATTR_AUTO], true);
+	iface->proto_ip.no_defaultroute =
+		!blobmsg_get_bool_default(tb[IFACE_ATTR_DEFAULTROUTE], true);
+	iface->proto_ip.no_dns =
+		!blobmsg_get_bool_default(tb[IFACE_ATTR_PEERDNS], true);
+
+	if ((cur = tb[IFACE_ATTR_DNS]))
+		interface_add_dns_server_list(&iface->config_ip, cur);
+
+	if ((cur = tb[IFACE_ATTR_DNS_SEARCH]))
+		interface_add_dns_search_list(&iface->config_ip, cur);
+
+	if ((cur = tb[IFACE_ATTR_METRIC]))
+		iface->metric = blobmsg_get_u32(cur);
+
+	iface->config_autostart = iface->autostart;
+}
+
+static bool __interface_add(struct interface *iface, struct blob_attr *config, bool alias)
+{
+	struct blob_attr *tb[IFACE_ATTR_MAX];
+	struct blob_attr *cur;
+
+	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb,
+		      blob_data(config), blob_len(config));
+
+	if (alias) {
+		if ((cur = tb[IFACE_ATTR_INTERFACE]))
+			iface->parent_ifname = blobmsg_data(cur);
+
+		if (!iface->parent_ifname)
+			return false;
+	} else {
+		if ((cur = tb[IFACE_ATTR_IFNAME]))
+			iface->ifname = blobmsg_data(cur);
 	}
-	return NULL;
+
+
+	iface->config = config;
+	vlist_add(&interfaces, &iface->node, iface->name);
+	return true;
 }
 
 void
-interface_remove_link(struct interface *iface, struct device *llif)
+interface_add(struct interface *iface, struct blob_attr *config)
 {
-	struct device *dev = iface->main_dev.dev;
+	__interface_add(iface, config, false);
+}
 
-	if (dev && dev->hotplug_ops) {
-		dev->hotplug_ops->del(dev, llif);
+bool
+interface_add_alias(struct interface *iface, struct blob_attr *config)
+{
+	if (iface->proto_handler->flags & PROTO_FLAG_NODEV)
+		return false;
+
+	return __interface_add(iface, config, true);
+}
+
+void
+interface_set_l3_dev(struct interface *iface, struct device *dev)
+{
+	bool enabled = iface->config_ip.enabled;
+	bool claimed = iface->l3_dev.claimed;
+
+	if (iface->l3_dev.dev == dev)
 		return;
+
+	interface_ip_set_enabled(&iface->config_ip, false);
+	interface_ip_flush(&iface->proto_ip);
+	device_add_user(&iface->l3_dev, dev);
+
+	if (dev) {
+		if (claimed)
+			device_claim(&iface->l3_dev);
+		interface_ip_set_enabled(&iface->config_ip, enabled);
 	}
+}
+
+void
+interface_set_main_dev(struct interface *iface, struct device *dev)
+{
+	bool set_l3 = (iface->main_dev.dev == iface->l3_dev.dev);
+	bool claimed = iface->l3_dev.claimed;
 
-	remove_device_user(&iface->main_dev);
+	if (iface->main_dev.dev == dev)
+		return;
+
+	if (set_l3)
+		interface_set_l3_dev(iface, dev);
+
+	device_add_user(&iface->main_dev, dev);
+	if (claimed)
+		device_claim(&iface->l3_dev);
+
+	if (!iface->l3_dev.dev)
+		interface_set_l3_dev(iface, dev);
 }
 
 int
-interface_add_link(struct interface *iface, struct device *llif)
+interface_remove_link(struct interface *iface, struct device *dev)
 {
-	struct device *dev = iface->main_dev.dev;
+	struct device *mdev = iface->main_dev.dev;
 
-	if (dev && dev->hotplug_ops)
-		return dev->hotplug_ops->add(dev, llif);
+	if (mdev && mdev->hotplug_ops)
+		return mdev->hotplug_ops->del(mdev, dev);
 
-	if (iface->main_dev.dev)
-		interface_remove_link(iface, NULL);
+	if (!iface->main_dev.hotplug)
+		return UBUS_STATUS_INVALID_ARGUMENT;
+
+	if (dev != iface->main_dev.dev)
+		return UBUS_STATUS_INVALID_ARGUMENT;
 
-	add_device_user(&iface->main_dev, llif);
+	device_remove_user(&iface->main_dev);
+	return 0;
+}
+
+int
+interface_add_link(struct interface *iface, struct device *dev)
+{
+	struct device *mdev = iface->main_dev.dev;
+
+	if (mdev == dev)
+		return 0;
 
+	if (iface->main_dev.hotplug)
+		device_remove_user(&iface->main_dev);
+
+	if (mdev) {
+		if (mdev->hotplug_ops)
+			return mdev->hotplug_ops->add(mdev, dev);
+		else
+			return UBUS_STATUS_NOT_SUPPORTED;
+	}
+
+	interface_set_main_dev(iface, dev);
+	iface->main_dev.hotplug = true;
 	return 0;
 }
 
 int
-set_interface_up(struct interface *iface)
+interface_set_up(struct interface *iface)
 {
+	int ret;
+
 	iface->autostart = true;
 
-	if (!iface->active) {
+	if (iface->state != IFS_DOWN)
+		return 0;
+
+	interface_clear_errors(iface);
+	if (!iface->available) {
 		interface_add_error(iface, "interface", "NO_DEVICE", NULL, 0);
 		return -1;
 	}
 
-	if (iface->up)
-		return -1;
+	if (iface->main_dev.dev) {
+		ret = device_claim(&iface->main_dev);
+		if (ret)
+			return ret;
+	}
+
+	iface->state = IFS_SETUP;
+	ret = interface_proto_event(iface->proto, PROTO_CMD_SETUP, false);
+	if (ret) {
+		mark_interface_down(iface);
+		return ret;
+	}
 
-	__set_interface_up(iface);
 	return 0;
 }
 
 int
-set_interface_down(struct interface *iface)
+interface_set_down(struct interface *iface)
 {
-	iface->autostart = false;
-	__set_interface_down(iface);
+	if (!iface) {
+		vlist_for_each_element(&interfaces, iface, node)
+			__interface_set_down(iface, false);
+	} else {
+		iface->autostart = false;
+		__interface_set_down(iface, false);
+	}
 
 	return 0;
 }
+
+void
+interface_start_pending(void)
+{
+	struct interface *iface;
+
+	vlist_for_each_element(&interfaces, iface, node) {
+		if (iface->available && iface->autostart)
+			interface_set_up(iface);
+	}
+}
+
+static void
+set_config_state(struct interface *iface, enum interface_config_state s)
+{
+	iface->config_state = s;
+	if (iface->state == IFS_DOWN)
+		interface_handle_config_change(iface);
+	else
+		__interface_set_down(iface, false);
+}
+
+void
+interface_update_start(struct interface *iface)
+{
+	interface_ip_update_start(&iface->proto_ip);
+}
+
+void
+interface_update_complete(struct interface *iface)
+{
+	interface_ip_update_complete(&iface->proto_ip);
+}
+
+static void
+interface_replace_dns(struct interface_ip_settings *new, struct interface_ip_settings *old)
+{
+	vlist_simple_replace(&new->dns_servers, &old->dns_servers);
+	vlist_simple_replace(&new->dns_search, &old->dns_search);
+}
+
+static void
+interface_change_config(struct interface *if_old, struct interface *if_new)
+{
+	struct blob_attr *old_config = if_old->config;
+	const char *old_ifname = if_old->ifname;
+	const char *old_parent_ifname = if_old->parent_ifname;
+	const struct proto_handler *proto = if_old->proto_handler;
+
+	interface_clear_errors(if_old);
+	if_old->config = if_new->config;
+	if (!if_old->config_autostart && if_new->config_autostart)
+		if_old->autostart = true;
+
+	if_old->config_autostart = if_new->config_autostart;
+	if_old->ifname = if_new->ifname;
+	if_old->parent_ifname = if_new->parent_ifname;
+	if_old->proto_handler = if_new->proto_handler;
+
+#define FIELD_CHANGED_STR(field)					\
+		((!!if_old->field != !!old_ ## field) ||		\
+		 (old_ ## field &&					\
+		  strcmp(old_ ## field, if_old->field) != 0))
+
+	if (FIELD_CHANGED_STR(parent_ifname)) {
+		if (if_old->parent_iface.iface)
+			interface_remove_user(&if_old->parent_iface);
+		goto reload;
+	}
+
+	if (FIELD_CHANGED_STR(ifname) || proto != if_new->proto_handler) {
+		D(INTERFACE, "Reload interface '%s' because of ifname/proto change\n",
+		  if_old->name);
+		goto reload;
+	}
+
+	if (!proto->config_params)
+		D(INTERFACE, "No config parameters for interface '%s'\n",
+		  if_old->name);
+	else if (!config_check_equal(old_config, if_new->config,
+				proto->config_params)) {
+		D(INTERFACE, "Reload interface '%s because of config changes\n",
+		  if_old->name);
+		goto reload;
+	}
+
+#define UPDATE(field) ({						\
+		bool __changed = (if_old->field != if_new->field);	\
+		if_old->field = if_new->field;				\
+		__changed;						\
+	})
+
+	if (UPDATE(metric) || UPDATE(proto_ip.no_defaultroute)) {
+		interface_ip_set_enabled(&if_old->config_ip, false);
+		interface_ip_set_enabled(&if_old->config_ip, if_new->config_ip.enabled);
+		interface_ip_set_enabled(&if_old->proto_ip, false);
+		interface_ip_set_enabled(&if_old->proto_ip, if_new->proto_ip.enabled);
+	}
+
+	UPDATE(proto_ip.no_dns);
+	interface_replace_dns(&if_old->config_ip, &if_new->config_ip);
+	interface_write_resolv_conf();
+
+#undef UPDATE
+
+	goto out;
+
+reload:
+	set_config_state(if_old, IFC_RELOAD);
+out:
+	if_new->config = NULL;
+	interface_cleanup(if_new, false);
+	free(old_config);
+	free(if_new);
+}
+
+static void
+interface_update(struct vlist_tree *tree, struct vlist_node *node_new,
+		 struct vlist_node *node_old)
+{
+	struct interface *if_old = container_of(node_old, struct interface, node);
+	struct interface *if_new = container_of(node_new, struct interface, node);
+
+	if (node_old && node_new) {
+		D(INTERFACE, "Update interface '%s'\n", if_new->name);
+		interface_change_config(if_old, if_new);
+	} else if (node_old) {
+		D(INTERFACE, "Remove interface '%s'\n", if_old->name);
+		set_config_state(if_old, IFC_REMOVE);
+	} else if (node_new) {
+		D(INTERFACE, "Create interface '%s'\n", if_new->name);
+		proto_init_interface(if_new, if_new->config);
+		interface_claim_device(if_new);
+		netifd_ubus_add_interface(if_new);
+	}
+}
+
+
+static void __init
+interface_init_list(void)
+{
+	vlist_init(&interfaces, avl_strcmp, interface_update);
+	interfaces.keep_old = true;
+	interfaces.no_delete = true;
+}