X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=interface-ip.c;h=715e49837266b7f68b247e10e46d5fc43f9c0f5d;hp=6f4201592068fc597c3c69779f73e3421fd6000a;hb=cd23fd6bf7983741b9a72bea78749278716248ec;hpb=235a02424c3ab1b59308895c4f00395dacf2557c

diff --git a/interface-ip.c b/interface-ip.c
index 6f42015..715e498 100644
--- a/interface-ip.c
+++ b/interface-ip.c
@@ -38,6 +38,8 @@ enum {
 	ROUTE_VALID,
 	ROUTE_TABLE,
 	ROUTE_SOURCE,
+	ROUTE_ONLINK,
+	ROUTE_TYPE,
 	__ROUTE_MAX
 };
 
@@ -51,6 +53,8 @@ static const struct blobmsg_policy route_attr[__ROUTE_MAX] = {
 	[ROUTE_TABLE] = { .name = "table", .type = BLOBMSG_TYPE_STRING },
 	[ROUTE_VALID] = { .name = "valid", .type = BLOBMSG_TYPE_INT32 },
 	[ROUTE_SOURCE] = { .name = "source", .type = BLOBMSG_TYPE_STRING },
+	[ROUTE_ONLINK] = { .name = "onlink", .type = BLOBMSG_TYPE_BOOL },
+	[ROUTE_TYPE] = { .name = "type", .type = BLOBMSG_TYPE_STRING }
 };
 
 const struct uci_blob_param_list route_attr_list = {
@@ -347,6 +351,9 @@ interface_ip_add_route(struct interface *iface, struct blob_attr *attr, bool v6)
 		route->sourcemask = (mask) ? atoi(mask) : ((af == AF_INET6) ? 128 : 32);
 	}
 
+	if ((cur = tb[ROUTE_ONLINK]) != NULL && blobmsg_get_bool(cur))
+		route->flags |= DEVROUTE_ONLINK;
+
 	if (is_proto_route) {
 		route->table = (v6) ? iface->ip6table : iface->ip4table;
 		route->flags |= DEVROUTE_SRCTABLE;
@@ -369,6 +376,14 @@ interface_ip_add_route(struct interface *iface, struct blob_attr *attr, bool v6)
 			route->valid_until = valid_until;
 	}
 
+	if ((cur = tb[ROUTE_TYPE]) != NULL) {
+		if (!system_resolve_rt_type(blobmsg_data(cur), &route->type)) {
+			DPRINTF("Failed to resolve routing type: %s\n", (char *) blobmsg_data(cur));
+			goto error;
+		}
+		route->flags |= DEVROUTE_TYPE;
+	}
+
 	vlist_add(&ip->route, &route->node, route);
 	return;
 
@@ -400,6 +415,9 @@ route_cmp(const void *k1, const void *k2, void *ptr)
 	if (r1->sourcemask != r2->sourcemask)
 		return r1->sourcemask - r2->sourcemask;
 
+	if (r1->table != r2->table)
+		return r1->table - r2->table;
+
 	int maskcmp = memcmp(&r1->source, &r2->source, sizeof(r1->source));
 	if (maskcmp)
 		return maskcmp;
@@ -578,7 +596,8 @@ interface_update_proto_route(struct vlist_tree *tree,
 
 	if (node_old && node_new)
 		keep = !memcmp(&route_old->nexthop, &route_new->nexthop, sizeof(route_old->nexthop)) &&
-			(route_old->table == route_new->table) && !route_old->failed;
+			(route_old->mtu == route_new->mtu) && (route_old->type == route_new->type) &&
+			!route_old->failed;
 
 	if (node_old) {
 		if (!(route_old->flags & DEVADDR_EXTERNAL) && route_old->enabled && !keep)
@@ -619,8 +638,10 @@ interface_update_host_route(struct vlist_tree *tree,
 		free(route_old);
 	}
 
-	if (node_new)
-		system_add_route(dev, route_new);
+	if (node_new) {
+		if (system_add_route(dev, route_new))
+			route_new->failed = true;
+	}
 }
 
 
@@ -661,8 +682,8 @@ interface_set_prefix_address(struct device_prefix_assignment *assignment,
 		}
 
 		assignment->enabled = false;
-	} else if (add && (iface->state == IFS_UP || iface->state == IFS_SETUP)) {
-		system_add_address(l3_downlink, &addr);
+	} else if (add && (iface->state == IFS_UP || iface->state == IFS_SETUP) &&
+			!system_add_address(l3_downlink, &addr)) {
 		if (prefix->iface && !assignment->enabled) {
 			set_ip_source_policy(true, true, IPRULE_PRIORITY_REJECT, &addr.addr,
 					addr.mask, 0, iface, "unreachable");
@@ -1040,7 +1061,7 @@ write_resolv_conf_entries(FILE *f, struct interface_ip_settings *ip, const char
 		if (!str)
 			continue;
 
-		if (s->af == AF_INET6 && IN6_IS_ADDR_LINKLOCAL(&s->addr))
+		if (s->af == AF_INET6 && IN6_IS_ADDR_LINKLOCAL(&s->addr.in6))
 			fprintf(f, "nameserver %s%%%s\n", str, dev);
 		else
 			fprintf(f, "nameserver %s\n", str);
@@ -1137,7 +1158,8 @@ void interface_ip_set_enabled(struct interface_ip_settings *ip, bool enabled)
 			if (!(route->flags & DEVROUTE_METRIC))
 				route->metric = ip->iface->metric;
 
-			system_add_route(dev, route);
+			if (system_add_route(dev, route))
+				route->failed = true;
 		} else
 			system_del_route(dev, route);
 		route->enabled = _enabled;
@@ -1212,7 +1234,6 @@ interface_ip_init(struct interface *iface)
 	__interface_ip_init(&iface->proto_ip, iface);
 	__interface_ip_init(&iface->config_ip, iface);
 	vlist_init(&iface->host_routes, route_cmp, interface_update_host_route);
-
 }
 
 static void