X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=interface-event.c;h=86e8f5488da8626d54a61a9efee24e0366b10433;hp=24af8f57ef67e76001ca819b1085e1bab7070950;hb=HEAD;hpb=7c5d5bb952cff9fe57d0f4805cc2286318868e02

diff --git a/interface-event.c b/interface-event.c
index 24af8f5..86e8f54 100644
--- a/interface-event.c
+++ b/interface-event.c
@@ -30,7 +30,15 @@ static void task_complete(struct uloop_process *proc, int ret);
 static struct uloop_process task = {
 	.cb = task_complete,
 };
-static const char * const eventnames[] = {"ifdown", "ifup", "ifupdate"};
+static const char * const eventnames[] = {
+	[IFEV_DOWN] = "ifdown",
+	[IFEV_UP] = "ifup",
+	[IFEV_UP_FAILED] = "ifup-failed",
+	[IFEV_UPDATE] = "ifupdate",
+	[IFEV_FREE] = "free",
+	[IFEV_RELOAD] = "reload",
+	[IFEV_LINK_UP] = "iflink",
+};
 
 static void
 run_cmd(const char *ifname, const char *device, enum interface_event event,
@@ -117,25 +125,18 @@ interface_queue_event(struct interface *iface, enum interface_event ev)
 
 	netifd_ubus_interface_notify(iface, ev != IFEV_DOWN);
 
+	/* no hotplug.d calls for link up */
+	if (ev == IFEV_LINK_UP)
+		return;
+
 	if (current == iface) {
 		/* an event for iface is being processed */
 		if (!list_empty(&iface->hotplug_list)) {
-			/* an additional event for iface is pending */
-			if ((ev != current_ev || ev == IFEV_UPDATE) &&
-			!(iface->hotplug_ev == IFEV_UP && ev == IFEV_UPDATE)) {
-				/* if incoming event is different from the one
-				 * being handled or if it is an update,
-				 * overwrite pending event, but never
-				 * overwrite an ifup with an ifupdate */
+			/* an additional event for iface is pending   */
+			/* overwrite pending event if it differs from */
+			/* an update                                  */
+			if (ev != IFEV_UPDATE)
 				iface->hotplug_ev = ev;
-			}
-			else if (ev == current_ev && ev != IFEV_UPDATE) {
-				/* if incoming event is not an ifupdate
-				 * and is the same as the one that is
-				 * being handled, remove it from the
-				 * pending list */
-				list_del_init(&iface->hotplug_list);
-			}
 		}
 		else {
 			/* no additional event for iface is pending */
@@ -189,15 +190,18 @@ static void interface_event_cb(struct interface_user *dep, struct interface *ifa
 			       enum interface_event ev)
 {
 	switch (ev) {
+		case IFEV_LINK_UP:
 		case IFEV_UP:
+		case IFEV_UP_FAILED:
 		case IFEV_UPDATE:
 		case IFEV_DOWN:
 			interface_queue_event(iface, ev);
 			break;
 		case IFEV_FREE:
-		case IFEV_RELOAD:
 			interface_dequeue_event(iface);
 			break;
+		default:
+			break;
 	}
 }