X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=bridge.c;h=70ea0f03b0f9a97618ebdfdbb4d553769d57d072;hp=1adabb9f3ceafc2dfe75439bde629a369f5b4461;hb=986c4a1434cc61d2de560690ecc0d532a157d40a;hpb=8c6361136d8c976407b03252b6cfadecb441b37a diff --git a/bridge.c b/bridge.c index 1adabb9..70ea0f0 100644 --- a/bridge.c +++ b/bridge.c @@ -77,6 +77,8 @@ struct bridge_member { bool present; }; +static void bridge_free_member(struct bridge_member *bm); + static int bridge_disable_member(struct bridge_member *bm) { @@ -147,6 +149,8 @@ bridge_member_cb(struct device_user *dev, enum device_event ev) if (bst->n_present == 0) device_set_present(&bst->dev, false); + if (dev->hotplug) + bridge_free_member(bm); break; default: return; @@ -213,19 +217,17 @@ bridge_set_state(struct device *dev, bool up) } static struct bridge_member * -bridge_create_member(struct bridge_state *bst, struct device *dev) +bridge_create_member(struct bridge_state *bst, struct device *dev, bool hotplug) { struct bridge_member *bm; bm = calloc(1, sizeof(*bm)); bm->bst = bst; bm->dev.cb = bridge_member_cb; - device_add_user(&bm->dev, dev); - + bm->dev.hotplug = hotplug; list_add_tail(&bm->list, &bst->members); - if (bst->dev.active) - bridge_enable_member(bm); + device_add_user(&bm->dev, dev); return bm; } @@ -254,7 +256,7 @@ bridge_add_member(struct bridge_state *bst, const char *name) if (!dev) return; - bridge_create_member(bst, dev); + bridge_create_member(bst, dev, false); } static int @@ -262,7 +264,7 @@ bridge_hotplug_add(struct device *dev, struct device *member) { struct bridge_state *bst = container_of(dev, struct bridge_state, dev); - bridge_create_member(bst, member); + bridge_create_member(bst, member, true); return 0; }