device: Fix dotted vlan interface staying down
[project/netifd.git] / device.c
index 2fb68d7..fa3d00f 100644 (file)
--- a/device.c
+++ b/device.c
 #include "config.h"
 
 static struct avl_tree devices;
+static bool default_ps = true;
 
 static const struct blobmsg_policy dev_attrs[__DEV_ATTR_MAX] = {
        [DEV_ATTR_TYPE] = { .name = "type", .type = BLOBMSG_TYPE_STRING },
-       [DEV_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_ARRAY },
        [DEV_ATTR_MTU] = { .name = "mtu", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_MTU6] = { .name = "mtu6", .type = BLOBMSG_TYPE_INT32 },
        [DEV_ATTR_MACADDR] = { .name = "macaddr", .type = BLOBMSG_TYPE_STRING },
        [DEV_ATTR_TXQUEUELEN] = { .name = "txqueuelen", .type = BLOBMSG_TYPE_INT32 },
        [DEV_ATTR_ENABLED] = { .name = "enabled", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_IPV6] = { .name = "ipv6", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_PROMISC] = { .name = "promisc", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_RPFILTER] = { .name = "rpfilter", .type = BLOBMSG_TYPE_STRING },
+       [DEV_ATTR_ACCEPTLOCAL] = { .name = "acceptlocal", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_IGMPVERSION] = { .name = "igmpversion", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_MLDVERSION] = { .name = "mldversion", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_NEIGHREACHABLETIME] = { .name = "neighreachabletime", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_NEIGHGCSTALETIME] = { .name = "neighgcstaletime", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_RPS] = { .name = "rps", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_XPS] = { .name = "xps", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_DADTRANSMITS] = { .name = "dadtransmits", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_MULTICAST_TO_UNICAST] = { .name = "multicast_to_unicast", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_MULTICAST_ROUTER] = { .name = "multicast_router", .type = BLOBMSG_TYPE_INT32 },
+       [DEV_ATTR_MULTICAST] = { .name ="multicast", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_LEARNING] = { .name ="learning", .type = BLOBMSG_TYPE_BOOL },
+       [DEV_ATTR_UNICAST_FLOOD] = { .name ="unicast_flood", .type = BLOBMSG_TYPE_BOOL },
 };
 
 const struct uci_blob_param_list device_attr_list = {
@@ -60,8 +77,15 @@ void device_unlock(void)
 
 static int set_device_state(struct device *dev, bool state)
 {
-       if (state)
+       if (state) {
+               /* Get ifindex for all devices being enabled so a valid  */
+               /* ifindex is in place avoiding possible race conditions */
+               device_set_ifindex(dev, system_if_resolve(dev));
+               if (!dev->ifindex)
+                       return -1;
+
                system_if_up(dev);
+       }
        else
                system_if_down(dev);
 
@@ -134,12 +158,35 @@ device_merge_settings(struct device *dev, struct device_settings *n)
 
        memset(n, 0, sizeof(*n));
        n->mtu = s->flags & DEV_OPT_MTU ? s->mtu : os->mtu;
+       n->mtu6 = s->flags & DEV_OPT_MTU6 ? s->mtu6 : os->mtu6;
        n->txqueuelen = s->flags & DEV_OPT_TXQUEUELEN ?
                s->txqueuelen : os->txqueuelen;
        memcpy(n->macaddr,
                (s->flags & DEV_OPT_MACADDR ? s->macaddr : os->macaddr),
                sizeof(n->macaddr));
-       n->flags = s->flags | os->flags;
+       n->ipv6 = s->flags & DEV_OPT_IPV6 ? s->ipv6 : os->ipv6;
+       n->promisc = s->flags & DEV_OPT_PROMISC ? s->promisc : os->promisc;
+       n->rpfilter = s->flags & DEV_OPT_RPFILTER ? s->rpfilter : os->rpfilter;
+       n->acceptlocal = s->flags & DEV_OPT_ACCEPTLOCAL ? s->acceptlocal : os->acceptlocal;
+       n->igmpversion = s->flags & DEV_OPT_IGMPVERSION ? s->igmpversion : os->igmpversion;
+       n->mldversion = s->flags & DEV_OPT_MLDVERSION ? s->mldversion : os->mldversion;
+       n->neigh4reachabletime = s->flags & DEV_OPT_NEIGHREACHABLETIME ?
+               s->neigh4reachabletime : os->neigh4reachabletime;
+       n->neigh6reachabletime = s->flags & DEV_OPT_NEIGHREACHABLETIME ?
+               s->neigh6reachabletime : os->neigh6reachabletime;
+       n->neigh4gcstaletime = s->flags & DEV_OPT_NEIGHGCSTALETIME ?
+               s->neigh4gcstaletime : os->neigh4gcstaletime;
+       n->neigh6gcstaletime = s->flags & DEV_OPT_NEIGHGCSTALETIME ?
+               s->neigh6gcstaletime : os->neigh6gcstaletime;
+       n->dadtransmits = s->flags & DEV_OPT_DADTRANSMITS ?
+               s->dadtransmits : os->dadtransmits;
+       n->multicast = s->flags & DEV_OPT_MULTICAST ?
+               s->multicast : os->multicast;
+       n->multicast_to_unicast = s->multicast_to_unicast;
+       n->multicast_router = s->multicast_router;
+       n->learning = s->learning;
+       n->unicast_flood = s->unicast_flood;
+       n->flags = s->flags | os->flags | os->valid_flags;
 }
 
 void
@@ -159,6 +206,11 @@ device_init_settings(struct device *dev, struct blob_attr **tb)
                s->flags |= DEV_OPT_MTU;
        }
 
+       if ((cur = tb[DEV_ATTR_MTU6])) {
+               s->mtu6 = blobmsg_get_u32(cur);
+               s->flags |= DEV_OPT_MTU6;
+       }
+
        if ((cur = tb[DEV_ATTR_TXQUEUELEN])) {
                s->txqueuelen = blobmsg_get_u32(cur);
                s->flags |= DEV_OPT_TXQUEUELEN;
@@ -172,6 +224,101 @@ device_init_settings(struct device *dev, struct blob_attr **tb)
                }
        }
 
+       if ((cur = tb[DEV_ATTR_IPV6])) {
+               s->ipv6 = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_IPV6;
+       }
+
+       if ((cur = tb[DEV_ATTR_PROMISC])) {
+               s->promisc = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_PROMISC;
+       }
+
+       if ((cur = tb[DEV_ATTR_RPFILTER])) {
+               if (system_resolve_rpfilter(blobmsg_data(cur), &s->rpfilter))
+                       s->flags |= DEV_OPT_RPFILTER;
+               else
+                       DPRINTF("Failed to resolve rpfilter: %s\n", (char *) blobmsg_data(cur));
+       }
+
+       if ((cur = tb[DEV_ATTR_ACCEPTLOCAL])) {
+               s->acceptlocal = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_ACCEPTLOCAL;
+       }
+
+       if ((cur = tb[DEV_ATTR_IGMPVERSION])) {
+               s->igmpversion = blobmsg_get_u32(cur);
+               if (s->igmpversion >= 1 && s->igmpversion <= 3)
+                       s->flags |= DEV_OPT_IGMPVERSION;
+               else
+                       DPRINTF("Failed to resolve igmpversion: %d\n", blobmsg_get_u32(cur));
+       }
+
+       if ((cur = tb[DEV_ATTR_MLDVERSION])) {
+               s->mldversion = blobmsg_get_u32(cur);
+               if (s->mldversion >= 1 && s->mldversion <= 2)
+                       s->flags |= DEV_OPT_MLDVERSION;
+               else
+                       DPRINTF("Failed to resolve mldversion: %d\n", blobmsg_get_u32(cur));
+       }
+
+       if ((cur = tb[DEV_ATTR_NEIGHREACHABLETIME])) {
+               s->neigh6reachabletime = s->neigh4reachabletime = blobmsg_get_u32(cur);
+               s->flags |= DEV_OPT_NEIGHREACHABLETIME;
+       }
+
+       if ((cur = tb[DEV_ATTR_NEIGHGCSTALETIME])) {
+               s->neigh6gcstaletime = s->neigh4gcstaletime = blobmsg_get_u32(cur);
+               s->flags |= DEV_OPT_NEIGHGCSTALETIME;
+       }
+
+       if ((cur = tb[DEV_ATTR_RPS])) {
+               s->rps = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_RPS;
+       }
+       else
+               s->rps = default_ps;
+
+       if ((cur = tb[DEV_ATTR_XPS])) {
+               s->xps = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_XPS;
+       }
+       else
+               s->xps = default_ps;
+
+       if ((cur = tb[DEV_ATTR_DADTRANSMITS])) {
+               s->dadtransmits = blobmsg_get_u32(cur);
+               s->flags |= DEV_OPT_DADTRANSMITS;
+       }
+
+       if ((cur = tb[DEV_ATTR_MULTICAST_TO_UNICAST])) {
+               s->multicast_to_unicast = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_MULTICAST_TO_UNICAST;
+       }
+
+       if ((cur = tb[DEV_ATTR_MULTICAST_ROUTER])) {
+               s->multicast_router = blobmsg_get_u32(cur);
+               if (s->multicast_router <= 2)
+                       s->flags |= DEV_OPT_MULTICAST_ROUTER;
+               else
+                       DPRINTF("Invalid value: %d - (Use 0: never, 1: learn, 2: always)\n", blobmsg_get_u32(cur));
+       }
+
+       if ((cur = tb[DEV_ATTR_MULTICAST])) {
+               s->multicast = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_MULTICAST;
+       }
+
+       if ((cur = tb[DEV_ATTR_LEARNING])) {
+               s->learning = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_LEARNING;
+       }
+
+       if ((cur = tb[DEV_ATTR_UNICAST_FLOOD])) {
+               s->unicast_flood = blobmsg_get_bool(cur);
+               s->flags |= DEV_OPT_UNICAST_FLOOD;
+       }
+
        device_set_disabled(dev, disabled);
 }
 
@@ -205,18 +352,31 @@ void device_broadcast_event(struct device *dev, enum device_event ev)
 int device_claim(struct device_user *dep)
 {
        struct device *dev = dep->dev;
-       int ret;
+       int ret = 0;
 
        if (dep->claimed)
                return 0;
 
+       if (!dev)
+               return -1;
+
        dep->claimed = true;
        D(DEVICE, "Claim %s %s, new active count: %d\n", dev->type->name, dev->ifname, dev->active + 1);
        if (++dev->active != 1)
                return 0;
 
        device_broadcast_event(dev, DEV_EVENT_SETUP);
-       ret = dev->set_state(dev, true);
+       if (dev->external) {
+               /* Get ifindex for external claimed devices so a valid   */
+               /* ifindex is in place avoiding possible race conditions */
+               device_set_ifindex(dev, system_if_resolve(dev));
+               if (!dev->ifindex)
+                       ret = -1;
+
+               system_if_get_settings(dev, &dev->orig_settings);
+       } else
+               ret = dev->set_state(dev, true);
+
        if (ret == 0)
                device_broadcast_event(dev, DEV_EVENT_UP);
        else {
@@ -244,7 +404,7 @@ void device_release(struct device_user *dep)
                return;
 
        device_broadcast_event(dev, DEV_EVENT_TEARDOWN);
-       if (!dep->hotplug)
+       if (!dev->external)
                dev->set_state(dev, false);
        device_broadcast_event(dev, DEV_EVENT_DOWN);
 }
@@ -252,7 +412,7 @@ void device_release(struct device_user *dep)
 int device_check_state(struct device *dev)
 {
        if (!dev->type->check_state)
-               return 0;
+               return simple_device_type.check_state(dev);
 
        return dev->type->check_state(dev);
 }
@@ -262,14 +422,14 @@ void device_init_virtual(struct device *dev, const struct device_type *type, con
        assert(dev);
        assert(type);
 
-       if (name)
-               strncpy(dev->ifname, name, IFNAMSIZ);
-
-       D(DEVICE, "Initialize device '%s'\n", dev->ifname);
+       D(DEVICE, "Initialize device '%s'\n", name ? name : "");
        INIT_SAFE_LIST(&dev->users);
        INIT_SAFE_LIST(&dev->aliases);
        dev->type = type;
 
+       if (name)
+               device_set_ifname(dev, name);
+
        if (!dev->set_state)
                dev->set_state = set_device_state;
 }
@@ -288,6 +448,8 @@ int device_init(struct device *dev, const struct device_type *type, const char *
 
        system_if_clear_state(dev);
        device_check_state(dev);
+       dev->settings.rps = default_ps;
+       dev->settings.xps = default_ps;
 
        return 0;
 }
@@ -302,14 +464,27 @@ device_create_default(const char *name, bool external)
 
        D(DEVICE, "Create simple device '%s'\n", name);
        dev = calloc(1, sizeof(*dev));
+       if (!dev)
+               return NULL;
+
        dev->external = external;
        dev->set_state = simple_device_set_state;
        device_init(dev, &simple_device_type, name);
        dev->default_config = true;
+       if (external)
+               system_if_apply_settings(dev, &dev->settings, dev->settings.flags);
        return dev;
 }
 
 struct device *
+device_find(const char *name)
+{
+       struct device *dev;
+
+       return avl_find_element(&devices, name, dev, avl);
+}
+
+struct device *
 device_get(const char *name, int create)
 {
        struct device *dev;
@@ -323,6 +498,7 @@ device_get(const char *name, int create)
        dev = avl_find_element(&devices, name, dev, avl);
        if (dev) {
                if (create > 1 && !dev->external) {
+                       system_if_apply_settings(dev, &dev->settings, dev->settings.flags);
                        dev->external = true;
                        device_set_present(dev, true);
                }
@@ -414,6 +590,27 @@ void device_set_ifindex(struct device *dev, int ifindex)
        device_broadcast_event(dev, DEV_EVENT_UPDATE_IFINDEX);
 }
 
+int device_set_ifname(struct device *dev, const char *name)
+{
+       int ret = 0;
+
+       if (!strcmp(dev->ifname, name))
+               return 0;
+
+       if (dev->avl.key)
+               avl_delete(&devices, &dev->avl);
+
+       strncpy(dev->ifname, name, IFNAMSIZ);
+
+       if (dev->avl.key)
+               ret = avl_insert(&devices, &dev->avl);
+
+       if (ret == 0)
+               device_broadcast_event(dev, DEV_EVENT_UPDATE_IFNAME);
+
+       return ret;
+}
+
 static int device_refcount(struct device *dev)
 {
        struct list_head *list;
@@ -428,19 +625,11 @@ static int device_refcount(struct device *dev)
        return count;
 }
 
-void device_add_user(struct device_user *dep, struct device *dev)
+static void
+__device_add_user(struct device_user *dep, struct device *dev)
 {
        struct safe_list *head;
 
-       if (dep->dev == dev)
-               return;
-
-       if (dep->dev)
-               device_remove_user(dep);
-
-       if (!dev)
-               return;
-
        dep->dev = dev;
 
        if (dep->alias)
@@ -461,6 +650,20 @@ void device_add_user(struct device_user *dep, struct device *dev)
        }
 }
 
+void device_add_user(struct device_user *dep, struct device *dev)
+{
+       if (dep->dev == dev)
+               return;
+
+       if (dep->dev)
+               device_remove_user(dep);
+
+       if (!dev)
+               return;
+
+       __device_add_user(dep, dev);
+}
+
 void
 device_free(struct device *dev)
 {
@@ -526,10 +729,17 @@ device_init_pending(void)
 }
 
 static enum dev_change_type
-device_reload_config(struct device *dev, struct blob_attr *attr)
+device_set_config(struct device *dev, const struct device_type *type,
+                 struct blob_attr *attr)
 {
        struct blob_attr *tb[__DEV_ATTR_MAX];
-       const struct uci_blob_param_list *cfg = dev->type->config_params;
+       const struct uci_blob_param_list *cfg = type->config_params;
+
+       if (type != dev->type)
+               return DEV_CONFIG_RECREATE;
+
+       if (dev->type->reload)
+               return dev->type->reload(dev, attr);
 
        if (uci_blob_check_equal(dev->config, attr, cfg))
                return DEV_CONFIG_NO_CHANGE;
@@ -548,37 +758,64 @@ device_reload_config(struct device *dev, struct blob_attr *attr)
 }
 
 enum dev_change_type
-device_set_config(struct device *dev, const struct device_type *type,
-                 struct blob_attr *attr)
+device_apply_config(struct device *dev, const struct device_type *type,
+                   struct blob_attr *config)
 {
-       if (type != dev->type)
-               return DEV_CONFIG_RECREATE;
+       enum dev_change_type change;
 
-       if (dev->type->reload)
-               return dev->type->reload(dev, attr);
+       change = device_set_config(dev, type, config);
+       if (dev->external) {
+               system_if_apply_settings(dev, &dev->settings, dev->settings.flags);
+               change = DEV_CONFIG_APPLIED;
+       }
 
-       return device_reload_config(dev, attr);
+       switch (change) {
+               case DEV_CONFIG_RESTART:
+               case DEV_CONFIG_APPLIED:
+                       D(DEVICE, "Device '%s': config applied\n", dev->ifname);
+                       config = blob_memdup(config);
+                       free(dev->config);
+                       dev->config = config;
+                       if (change == DEV_CONFIG_RESTART && dev->present) {
+                               int ret = 0;
+
+                               device_set_present(dev, false);
+                               if (dev->active && !dev->external) {
+                                       ret = dev->set_state(dev, false);
+                                       if (!ret)
+                                               ret = dev->set_state(dev, true);
+                               }
+                               if (!ret)
+                                       device_set_present(dev, true);
+                       }
+                       break;
+               case DEV_CONFIG_NO_CHANGE:
+                       D(DEVICE, "Device '%s': no configuration change\n", dev->ifname);
+                       break;
+               case DEV_CONFIG_RECREATE:
+                       break;
+       }
+
+       return change;
 }
 
 static void
 device_replace(struct device *dev, struct device *odev)
 {
        struct device_user *dep, *tmp;
-       bool present = odev->present;
 
-       if (present)
+       __devlock++;
+       if (odev->present)
                device_set_present(odev, false);
 
        list_for_each_entry_safe(dep, tmp, &odev->users.list, list.list) {
                device_release(dep);
                safe_list_del(&dep->list);
-               safe_list_add(&dep->list, &dev->users);
-               dep->dev = dev;
+               __device_add_user(dep, dev);
        }
-       device_free(odev);
+       __devlock--;
 
-       if (present)
-               device_set_present(dev, true);
+       device_free(odev);
 }
 
 void
@@ -603,10 +840,48 @@ device_reset_old(void)
                        continue;
 
                ndev = device_create_default(dev->ifname, dev->external);
+               if (!ndev)
+                       continue;
+
                device_replace(ndev, dev);
        }
 }
 
+void
+device_set_default_ps(bool state)
+{
+       struct device *dev;
+
+       if (state == default_ps)
+               return;
+
+       default_ps = state;
+
+       avl_for_each_element(&devices, dev, avl) {
+               struct device_settings *s = &dev->settings;
+               unsigned int apply_mask = 0;
+
+               if (!(s->flags & DEV_OPT_RPS)) {
+                       s->rps = default_ps;
+                       apply_mask |= DEV_OPT_RPS;
+               }
+
+               if (!(s->flags & DEV_OPT_XPS)) {
+                       s->xps = default_ps;
+                       apply_mask |= DEV_OPT_XPS;
+               }
+
+               if (!apply_mask)
+                       continue;
+
+               if (!(dev->external || (dev->present && dev->active)) ||
+                               dev->config_pending)
+                       continue;
+
+               system_if_apply_settings(dev, s, apply_mask);
+       }
+}
+
 struct device *
 device_create(const char *name, const struct device_type *type,
              struct blob_attr *config)
@@ -614,41 +889,25 @@ device_create(const char *name, const struct device_type *type,
        struct device *odev = NULL, *dev;
        enum dev_change_type change;
 
-       config = blob_memdup(config);
-       if (!config)
-               return NULL;
-
        odev = device_get(name, false);
        if (odev) {
                odev->current_config = true;
-               change = device_set_config(odev, type, config);
-               if (odev->external) {
-                       system_if_apply_settings(odev, &odev->settings, odev->settings.flags);
-                       change = DEV_CONFIG_APPLIED;
-               }
+               change = device_apply_config(odev, type, config);
                switch (change) {
-               case DEV_CONFIG_RESTART:
-               case DEV_CONFIG_APPLIED:
-                       D(DEVICE, "Device '%s': config applied\n", odev->ifname);
-                       free(odev->config);
-                       odev->config = config;
-                       if (change == DEV_CONFIG_RESTART && odev->present) {
-                               device_set_present(odev, false);
-                               device_set_present(odev, true);
-                       }
-                       return odev;
-               case DEV_CONFIG_NO_CHANGE:
-                       D(DEVICE, "Device '%s': no configuration change\n", odev->ifname);
-                       free(config);
-                       return odev;
                case DEV_CONFIG_RECREATE:
                        D(DEVICE, "Device '%s': recreate device\n", odev->ifname);
                        device_delete(odev);
                        break;
+               default:
+                       return odev;
                }
        } else
                D(DEVICE, "Create new device '%s' (%s)\n", name, type->name);
 
+       config = blob_memdup(config);
+       if (!config)
+               return NULL;
+
        dev = type->create(name, config);
        if (!dev)
                return NULL;
@@ -658,8 +917,10 @@ device_create(const char *name, const struct device_type *type,
        if (odev)
                device_replace(dev, odev);
 
-       if (!config_init && dev->config_pending)
+       if (!config_init && dev->config_pending) {
                type->config_init(dev);
+               dev->config_pending = false;
+       }
 
        return dev;
 }
@@ -701,10 +962,44 @@ device_dump_status(struct blob_buf *b, struct device *dev)
                device_merge_settings(dev, &st);
                if (st.flags & DEV_OPT_MTU)
                        blobmsg_add_u32(b, "mtu", st.mtu);
+               if (st.flags & DEV_OPT_MTU6)
+                       blobmsg_add_u32(b, "mtu6", st.mtu6);
                if (st.flags & DEV_OPT_MACADDR)
                        blobmsg_add_string(b, "macaddr", format_macaddr(st.macaddr));
                if (st.flags & DEV_OPT_TXQUEUELEN)
                        blobmsg_add_u32(b, "txqueuelen", st.txqueuelen);
+               if (st.flags & DEV_OPT_IPV6)
+                       blobmsg_add_u8(b, "ipv6", st.ipv6);
+               if (st.flags & DEV_OPT_PROMISC)
+                       blobmsg_add_u8(b, "promisc", st.promisc);
+               if (st.flags & DEV_OPT_RPFILTER)
+                       blobmsg_add_u32(b, "rpfilter", st.rpfilter);
+               if (st.flags & DEV_OPT_ACCEPTLOCAL)
+                       blobmsg_add_u8(b, "acceptlocal", st.acceptlocal);
+               if (st.flags & DEV_OPT_IGMPVERSION)
+                       blobmsg_add_u32(b, "igmpversion", st.igmpversion);
+               if (st.flags & DEV_OPT_MLDVERSION)
+                       blobmsg_add_u32(b, "mldversion", st.mldversion);
+               if (st.flags & DEV_OPT_NEIGHREACHABLETIME) {
+                       blobmsg_add_u32(b, "neigh4reachabletime", st.neigh4reachabletime);
+                       blobmsg_add_u32(b, "neigh6reachabletime", st.neigh6reachabletime);
+               }
+               if (st.flags & DEV_OPT_NEIGHGCSTALETIME) {
+                       blobmsg_add_u32(b, "neigh4gcstaletime", st.neigh4gcstaletime);
+                       blobmsg_add_u32(b, "neigh6gcstaletime", st.neigh6gcstaletime);
+               }
+               if (st.flags & DEV_OPT_DADTRANSMITS)
+                       blobmsg_add_u32(b, "dadtransmits", st.dadtransmits);
+               if (st.flags & DEV_OPT_MULTICAST_TO_UNICAST)
+                       blobmsg_add_u8(b, "multicast_to_unicast", st.multicast_to_unicast);
+               if (st.flags & DEV_OPT_MULTICAST_ROUTER)
+                       blobmsg_add_u32(b, "multicast_router", st.multicast_router);
+               if (st.flags & DEV_OPT_MULTICAST)
+                       blobmsg_add_u8(b, "multicast", st.multicast);
+               if (st.flags & DEV_OPT_LEARNING)
+                       blobmsg_add_u8(b, "learning", st.learning);
+               if (st.flags & DEV_OPT_UNICAST_FLOOD)
+                       blobmsg_add_u8(b, "unicast_flood", st.unicast_flood);
        }
 
        s = blobmsg_open_table(b, "statistics");