bridge: add a debug message when a device could not be added

[project/netifd.git] / bridge.c

diff --git a/bridge.c b/bridge.c
index 54526f7..1cafad8 100644 (file)
--- a/bridge.c
+++ b/bridge.c
@@ -65,20 +65,20 @@ struct bridge_state {
        struct bridge_config config;
        struct blob_attr *ifnames;
        bool active;
+       bool force_active;
 
-       struct list_head members;
+       struct vlist_tree members;
        int n_present;
 };
 
 struct bridge_member {
-       struct list_head list;
+       struct vlist_node node;
        struct bridge_state *bst;
        struct device_user dev;
        bool present;
+       char name[];
 };
 
-static void bridge_free_member(struct bridge_member *bm);
-
 static int
 bridge_disable_member(struct bridge_member *bm)
 {
@@ -107,8 +107,10 @@ bridge_enable_member(struct bridge_member *bm)
                goto error;
 
        ret = system_bridge_addif(&bst->dev, bm->dev.dev);
-       if (ret < 0)
+       if (ret < 0) {
+               D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
                goto error;
+       }
 
        return 0;
 
@@ -119,6 +121,24 @@ error:
 }
 
 static void
+bridge_remove_member(struct bridge_member *bm)
+{
+       struct bridge_state *bst = bm->bst;
+
+       if (!bm->present)
+               return;
+
+       bm->present = false;
+       bm->bst->n_present--;
+       if (bst->dev.active)
+               bridge_disable_member(bm);
+
+       bst->force_active = false;
+       if (bst->n_present == 0)
+               device_set_present(&bst->dev, false);
+}
+
+static void
 bridge_member_cb(struct device_user *dev, enum device_event ev)
 {
        struct bridge_member *bm = container_of(dev, struct bridge_member, dev);
@@ -138,19 +158,14 @@ bridge_member_cb(struct device_user *dev, enum device_event ev)
 
                break;
        case DEV_EVENT_REMOVE:
-               if (!bm->present)
+               if (dev->hotplug) {
+                       vlist_delete(&bst->members, &bm->node);
                        return;
+               }
 
-               if (bst->dev.active)
-                       bridge_disable_member(bm);
+               if (bm->present)
+                       bridge_remove_member(bm);
 
-               bm->present = false;
-               bm->bst->n_present--;
-               if (bst->n_present == 0)
-                       device_set_present(&bst->dev, false);
-
-               if (dev->hotplug)
-                       bridge_free_member(bm);
                break;
        default:
                return;
@@ -164,7 +179,7 @@ bridge_set_down(struct bridge_state *bst)
 
        bst->set_state(&bst->dev, false);
 
-       list_for_each_entry(bm, &bst->members, list)
+       vlist_for_each_element(&bst->members, bm, node)
                bridge_disable_member(bm);
 
        system_bridge_delbr(&bst->dev);
@@ -178,17 +193,17 @@ bridge_set_up(struct bridge_state *bst)
        struct bridge_member *bm;
        int ret;
 
-       if (!bst->n_present)
+       if (!bst->force_active && !bst->n_present)
                return -ENOENT;
 
        ret = system_bridge_addbr(&bst->dev, &bst->config);
        if (ret < 0)
                goto out;
 
-       list_for_each_entry(bm, &bst->members, list)
+       vlist_for_each_element(&bst->members, bm, node)
                bridge_enable_member(bm);
 
-       if (!bst->n_present) {
+       if (!bst->force_active && !bst->n_present) {
                /* initialization of all member interfaces failed */
                system_bridge_delbr(&bst->dev);
                device_set_present(&bst->dev, false);
@@ -221,32 +236,47 @@ bridge_create_member(struct bridge_state *bst, struct device *dev, bool hotplug)
 {
        struct bridge_member *bm;
 
-       bm = calloc(1, sizeof(*bm));
+       bm = calloc(1, sizeof(*bm) + strlen(dev->ifname) + 1);
        bm->bst = bst;
        bm->dev.cb = bridge_member_cb;
        bm->dev.hotplug = hotplug;
-       list_add_tail(&bm->list, &bst->members);
-
-       device_add_user(&bm->dev, dev);
+       strcpy(bm->name, dev->ifname);
+       bm->dev.dev = dev;
+       vlist_add(&bst->members, &bm->node, bm->name);
 
        return bm;
 }
 
 static void
-bridge_free_member(struct bridge_member *bm)
+bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
+                    struct vlist_node *node_old)
 {
-       if (bm->present) {
-               bridge_member_cb(&bm->dev, DEV_EVENT_REMOVE);
-               bm->bst->n_present--;
-               if (bm->bst->dev.active)
-                       bridge_disable_member(bm);
+       struct bridge_member *bm;
+       struct device *dev;
+
+       if (node_new) {
+               bm = container_of(node_new, struct bridge_member, node);
+
+               if (node_old) {
+                       free(bm);
+                       return;
+               }
+
+               dev = bm->dev.dev;
+               bm->dev.dev = NULL;
+               device_add_user(&bm->dev, dev);
        }
 
-       list_del(&bm->list);
-       device_remove_user(&bm->dev);
-       free(bm);
+
+       if (node_old) {
+               bm = container_of(node_old, struct bridge_member, node);
+               bridge_remove_member(bm);
+               device_remove_user(&bm->dev);
+               free(bm);
+       }
 }
 
+
 static void
 bridge_add_member(struct bridge_state *bst, const char *name)
 {
@@ -275,18 +305,28 @@ bridge_hotplug_del(struct device *dev, struct device *member)
        struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
        struct bridge_member *bm;
 
-       list_for_each_entry(bm, &bst->members, list) {
-               if (bm->dev.dev != member)
-                       continue;
+       bm = vlist_find(&bst->members, member->ifname, bm, node);
+       if (!bm)
+               return UBUS_STATUS_NOT_FOUND;
 
-               bridge_free_member(bm);
-               return 0;
-       }
+       vlist_delete(&bst->members, &bm->node);
+       return 0;
+}
+
+static int
+bridge_hotplug_prepare(struct device *dev)
+{
+       struct bridge_state *bst;
 
-       return -ENOENT;
+       bst = container_of(dev, struct bridge_state, dev);
+       bst->force_active = true;
+       device_set_present(&bst->dev, true);
+
+       return 0;
 }
 
 static const struct device_hotplug_ops bridge_ops = {
+       .prepare = bridge_hotplug_prepare,
        .add = bridge_hotplug_add,
        .del = bridge_hotplug_del
 };
@@ -295,14 +335,10 @@ static void
 bridge_free(struct device *dev)
 {
        struct bridge_state *bst;
-       struct bridge_member *bm;
 
        device_cleanup(dev);
        bst = container_of(dev, struct bridge_state, dev);
-       while (!list_empty(&bst->members)) {
-               bm = list_first_entry(&bst->members, struct bridge_member, list);
-               bridge_free_member(bm);
-       }
+       vlist_flush_all(&bst->members);
        free(bst);
 }
 
@@ -315,10 +351,12 @@ bridge_dump_info(struct device *dev, struct blob_buf *b)
 
        bst = container_of(dev, struct bridge_state, dev);
 
+       system_if_dump_info(dev, b);
        list = blobmsg_open_array(b, "bridge-members");
-       list_for_each_entry(bm, &bst->members, list) {
+
+       vlist_for_each_element(&bst->members, bm, node)
                blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
-       }
+
        blobmsg_close_array(b, list);
 }
 
@@ -404,7 +442,8 @@ bridge_create(const char *name, struct blob_attr *attr)
 
        dev->hotplug_ops = &bridge_ops;
 
-       INIT_LIST_HEAD(&bst->members);
+       vlist_init(&bst->members, avl_strcmp, bridge_member_update);
+       bst->members.keep_old = true;
 
        return dev;
 }