X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fmdnsd.git;a=blobdiff_plain;f=ubus.c;h=08b808d5167c7821bdd8e48329e1c294408cfc93;hp=1009a3af147aa1dec79631d0e0b1ff9b93079533;hb=444987db98c88dfef6b3965051bf2aba6114aaa2;hpb=4a10aa49f77351da34872b7c15c6debd13e42d2a

diff --git a/ubus.c b/ubus.c
index 1009a3a..08b808d 100644
--- a/ubus.c
+++ b/ubus.c
@@ -20,6 +20,7 @@
 #include <libubox/avl.h>
 #include <libubox/uloop.h>
 
+#include "util.h"
 #include "ubus.h"
 #include "cache.h"
 #include "service.h"
@@ -45,63 +46,21 @@ mdns_scan(struct ubus_context *ctx, struct ubus_object *obj,
 	return 0;
 }
 
-static void
-mdns_add_records(const char *name)
-{
-	struct cache_record *r, *q = avl_find_element(&records, name, r, avl);
-	const char *txt;
-	char buffer[MAX_NAME_LEN];
-
-	if (!q)
-		return;
-
-	do {
-		r = q;
-		switch (r->type) {
-		case TYPE_TXT:
-			if (r->txt && strlen(r->txt)) {
-				txt = r->txt;
-				do {
-					blobmsg_add_string(&b, "txt", txt);
-					txt = &txt[strlen(txt) + 1];
-				} while (*txt);
-			}
-			break;
-
-		case TYPE_SRV:
-			if (r->port)
-				blobmsg_add_u32(&b, "port", r->port);
-			break;
-
-		case TYPE_A:
-			if ((r->rdlength == 4) && inet_ntop(AF_INET, r->rdata, buffer, INET6_ADDRSTRLEN))
-				blobmsg_add_string(&b, "ipv4", buffer);
-			break;
-
-		case TYPE_AAAA:
-			if ((r->rdlength == 16) && inet_ntop(AF_INET6, r->rdata, buffer, INET6_ADDRSTRLEN))
-				blobmsg_add_string(&b, "ipv6", buffer);
-			break;
-		}
-		q = avl_next_element(r, avl);
-	} while (q && !strcmp(r->record, q->record));
-}
-
 static int
 mdns_browse(struct ubus_context *ctx, struct ubus_object *obj,
 		struct ubus_request_data *req, const char *method,
 		struct blob_attr *msg)
 {
 	struct cache_entry *s, *q;
-	char buffer[MAX_NAME_LEN];
+	char *buffer = (char *) mdns_buf;
 	void *c1 = NULL, *c2;
 
-        blob_buf_init(&b, 0);
+	blob_buf_init(&b, 0);
 	avl_for_each_element(&entries, s, avl) {
 		char *local;
 		if (*((char *) s->avl.key) != '_')
 			continue;
-		snprintf(buffer, MAX_NAME_LEN, s->avl.key);
+		snprintf(buffer, MAX_NAME_LEN, "%s", (const char *) s->avl.key);
 		local = strstr(buffer, ".local");
 		if (local)
 			*local = '\0';
@@ -111,14 +70,14 @@ mdns_browse(struct ubus_context *ctx, struct ubus_object *obj,
 		if (!c1) {
 			c1 = blobmsg_open_table(&b, buffer);
 		}
-		snprintf(buffer, MAX_NAME_LEN, s->entry);
+		snprintf(buffer, MAX_NAME_LEN, "%s", (const char *) s->entry);
 		local = strstr(buffer, "._");
 		if (local)
 			*local = '\0';
 		c2 = blobmsg_open_table(&b, buffer);
 		strncat(buffer, ".local", MAX_NAME_LEN);
-		mdns_add_records(buffer);
-		mdns_add_records(s->entry);
+		cache_dump_records(&b, buffer);
+		cache_dump_records(&b, s->entry);
 		blobmsg_close_table(&b, c2);
 		q = avl_next_element(s, avl);
 		if (!q || avl_is_last(&entries, &s->avl) || strcmp(s->avl.key, q->avl.key)) {
@@ -137,22 +96,22 @@ mdns_hosts(struct ubus_context *ctx, struct ubus_object *obj,
 		struct blob_attr *msg)
 {
 	struct cache_entry *s;
-	char buffer[MAX_NAME_LEN];
+	char *buffer = (char *) mdns_buf;
 	void *c;
 
-        blob_buf_init(&b, 0);
+	blob_buf_init(&b, 0);
 	avl_for_each_element(&entries, s, avl) {
 		char *local;
 		if (*((char *) s->avl.key) == '_')
 			continue;
-		snprintf(buffer, MAX_NAME_LEN, s->entry);
+		snprintf(buffer, MAX_NAME_LEN, "%s", (const char *) s->entry);
 		local = strstr(buffer, "._");
 		if (local)
 			*local = '\0';
 		c = blobmsg_open_table(&b, buffer);
 		strncat(buffer, ".local", MAX_NAME_LEN);
-		mdns_add_records(buffer);
-		mdns_add_records(s->entry);
+		cache_dump_records(&b, buffer);
+		cache_dump_records(&b, s->entry);
 		blobmsg_close_table(&b, c);
 	}
 	ubus_send_reply(ctx, req, b.head);