From fbeea4ee33c877ce7d9412d0b98920bbb42466a4 Mon Sep 17 00:00:00 2001 From: Marc Benoit Date: Mon, 9 Apr 2018 20:47:32 -0400 Subject: [PATCH 1/1] luci-mod-admin-full: limit dns cachesize to 10000 The value of cachesize is hardcoded to 10000 in dnsmasq-2.79/src/option.c to 10000 max case 'c': /* --cache-size */ { int size; if (!atoi_check(arg, &size)) ret_err(gen_err); else { /* zero is OK, and means no caching. */ if (size < 0) size = 0; else if (size > 10000) size = 10000; daemon->cachesize = size; } break; } Tested on Netgear R7800 Signed-off-by: Marc Benoit --- modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/dhcp.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/dhcp.lua b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/dhcp.lua index d29848040..fbde431df 100644 --- a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/dhcp.lua +++ b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/dhcp.lua @@ -214,9 +214,9 @@ cq.placeholder = 150 cs = s:taboption("advanced", Value, "cachesize", translate("Size of DNS query cache"), - translate("Maximum number of cached DNS entries")) + translate("Number of cached DNS entries (max is 10000, 0 is no caching)")) cs.optional = true -cs.datatype = "uinteger" +cs.datatype = "range(0,10000)" cs.placeholder = 150 s:taboption("tftp", Flag, "enable_tftp", -- 2.11.0