From e2e2696430363eb22d5e890c8f0ca28d56434d19 Mon Sep 17 00:00:00 2001 From: Hannu Nyman Date: Sun, 20 Mar 2016 13:12:05 +0200 Subject: [PATCH 1/1] luci-base: fix bug in util.lua in 'shellsqescape' Fix a bug introduced by #561 Function 'shellsqescape' calls 'gsub' with the empty result string 'res' instead of the actual parameter 'value'. This leads into error: .../util.lua:160: bad argument #1 to 'gsub' (string expected, got nil) Fix error by passing the correct parameter to the function. After the fix, the unmount button introduced by #561 finally works. Signed-off-by: Hannu Nyman --- modules/luci-base/luasrc/util.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/luci-base/luasrc/util.lua b/modules/luci-base/luasrc/util.lua index 5bf0beb6c..2956aadcf 100644 --- a/modules/luci-base/luasrc/util.lua +++ b/modules/luci-base/luasrc/util.lua @@ -157,7 +157,7 @@ end -- command line parameter). function shellsqescape(value) local res - res, _ = string.gsub(res, "'", "'\\''") + res, _ = string.gsub(value, "'", "'\\''") return res end -- 2.11.0