From: Jonathan Bennett <jbennett@incomsystems.biz>
Date: Mon, 16 Oct 2017 02:33:15 +0000 (-0500)
Subject: Luci-app-fwknopd: add quotation marks to squash error
X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fluci.git;a=commitdiff_plain;h=085fb17a11c3f955962c143ba4e501c825305b04

Luci-app-fwknopd: add quotation marks to squash error

In some cases, the missing quotation marks can cause error messages.  Although harmless, adding the quotation marks for correctness.

Signed-off-by: Jonathan Bennett <JBennett@Incomsystems.biz>
---

diff --git a/applications/luci-app-fwknopd/root/usr/sbin/gen-qr.sh b/applications/luci-app-fwknopd/root/usr/sbin/gen-qr.sh
index abca5d3e5..7825f05d2 100644
--- a/applications/luci-app-fwknopd/root/usr/sbin/gen-qr.sh
+++ b/applications/luci-app-fwknopd/root/usr/sbin/gen-qr.sh
@@ -9,17 +9,17 @@ key=$(uci get fwknopd.@access[$entry_num].KEY)
 hmac_key_base64=$(uci get fwknopd.@access[$entry_num].HMAC_KEY_BASE64)
 hmac_key=$(uci get fwknopd.@access[$entry_num].HMAC_KEY)
 
-if [ $key_base64 != "" ]; then
+if [ "$key_base64" != "" ]; then
 qr="KEY_BASE64:$key_base64"
 fi
-if [ $key != "" ]; then
+if [ "$key" != "" ]; then
 qr="$qr KEY:$key"
 
 fi
-if [ $hmac_key_base64 != "" ]; then
+if [ "$hmac_key_base64" != "" ]; then
 qr="$qr HMAC_KEY_BASE64:$hmac_key_base64"
 fi
-if [ $hmac_key != "" ]; then
+if [ "$hmac_key" != "" ]; then
 qr="$qr HMAC_KEY:$hmac_key"
 fi