luci-app-ddns: patches for #298 #334 #335

[project/luci.git] / applications / luci-app-ddns / luasrc / model / cbi / ddns / hints.lua

diff --git a/applications/luci-app-ddns/luasrc/model/cbi/ddns/hints.lua b/applications/luci-app-ddns/luasrc/model/cbi/ddns/hints.lua
index 15da028..ff7aa7a 100644 (file)
--- a/applications/luci-app-ddns/luasrc/model/cbi/ddns/hints.lua
+++ b/applications/luci-app-ddns/luasrc/model/cbi/ddns/hints.lua
@@ -8,10 +8,11 @@ local DDNS = require "luci.tools.ddns"                -- ddns multiused functions
 
 -- check supported options -- ##################################################
 -- saved to local vars here because doing multiple os calls slow down the system
-has_ssl     = DDNS.check_ssl()         -- HTTPS support
+has_ssl     = DDNS.check_ssl()         -- HTTPS support and --bind-network / --interface
 has_proxy   = DDNS.check_proxy()       -- Proxy support
 has_dnstcp  = DDNS.check_bind_host()   -- DNS TCP support
-need_update = CTRL.update_needed()     -- correct ddns-scripts version
+-- correct ddns-scripts version
+need_update = DDNS.ipkg_ver_compare(DDNS.ipkg_ver_installed("ddns-scripts"), "<<", CTRL.DDNS_MIN)
 
 -- html constants
 font_red = [[<font color="red">]]
@@ -87,6 +88,22 @@ if not has_ssl then
                        translate("In some versions cURL/libcurl in OpenWrt is compiled without proxy support.")
 end
 
+-- No bind_network
+if not has_ssl then
+       local dv = s:option(DummyValue, "_no_bind_network")
+       dv.titleref = DISP.build_url("admin", "system", "packages")
+       dv.rawhtml  = true
+       dv.title = bold_on ..
+               translate("Binding to a specific network not supported") .. bold_off
+       dv.value = translate("Neither GNU Wget with SSL nor cURL installed to select a network to use for communication.") ..
+                       "<br />- " ..
+                       translate("You should install GNU Wget with SSL or cURL package.") ..
+                       "<br />- " ..
+                       translate("GNU Wget will use the IP of given network, cURL will use the physical interface.") ..
+                       "<br />- " ..
+                       translate("In some versions cURL/libcurl in OpenWrt is compiled without proxy support.")
+end
+
 -- cURL without proxy support
 if has_ssl and not has_proxy then
        local dv = s:option(DummyValue, "_no_proxy")