X-Git-Url: http://git.archive.openwrt.org/?p=project%2Flibubox.git;a=blobdiff_plain;f=blob.c;h=03d5e9c27ee73ec52bd30514a0cd6044cb7c6cf1;hp=2da7cac7e492819d00e122bcbf3334d0ebb3973e;hb=6eff829d788b36939325557066f58aafd6a05321;hpb=58aec3c59a53147c7d924c823f7405218fb5f555 diff --git a/blob.c b/blob.c index 2da7cac..03d5e9c 100644 --- a/blob.c +++ b/blob.c @@ -21,12 +21,15 @@ static bool blob_buffer_grow(struct blob_buf *buf, int minlen) { + struct blob_buf *new; int delta = ((minlen / 256) + 1) * 256; - buf->buflen += delta; - buf->buf = realloc(buf->buf, buf->buflen); - if (buf->buf) - memset(buf->buf + buf->buflen - delta, 0, delta); - return !!buf->buf; + new = realloc(buf->buf, buf->buflen + delta); + if (new) { + buf->buf = new; + memset(buf->buf + buf->buflen, 0, delta); + buf->buflen += delta; + } + return !!new; } static void @@ -50,15 +53,16 @@ attr_to_offset(struct blob_buf *buf, struct blob_attr *attr) return (char *)attr - (char *) buf->buf + BLOB_COOKIE; } -void +bool blob_buf_grow(struct blob_buf *buf, int required) { int offset_head = attr_to_offset(buf, buf->head); if (!buf->grow || !buf->grow(buf, required)) - return; + return false; buf->head = offset_to_attr(buf, offset_head); + return true; } static struct blob_attr * @@ -69,7 +73,8 @@ blob_add(struct blob_buf *buf, struct blob_attr *pos, int id, int payload) struct blob_attr *attr; if (required > 0) { - blob_buf_grow(buf, required); + if (!blob_buf_grow(buf, required)) + return NULL; attr = offset_to_attr(buf, offset); } else { attr = pos; @@ -134,7 +139,7 @@ blob_new(struct blob_buf *buf, int id, int payload) } struct blob_attr * -blob_put_raw(struct blob_buf *buf, const void *ptr, int len) +blob_put_raw(struct blob_buf *buf, const void *ptr, unsigned int len) { struct blob_attr *attr; @@ -142,13 +147,15 @@ blob_put_raw(struct blob_buf *buf, const void *ptr, int len) return NULL; attr = blob_add(buf, blob_next(buf->head), 0, len - sizeof(struct blob_attr)); + if (!attr) + return NULL; blob_set_raw_len(buf->head, blob_pad_len(buf->head) + len); memcpy(attr, ptr, len); return attr; } struct blob_attr * -blob_put(struct blob_buf *buf, int id, const void *ptr, int len) +blob_put(struct blob_buf *buf, int id, const void *ptr, unsigned int len) { struct blob_attr *attr; @@ -166,6 +173,8 @@ blob_nest_start(struct blob_buf *buf, int id) { unsigned long offset = attr_to_offset(buf, buf->head); buf->head = blob_new(buf, id, 0); + if (!buf->head) + return NULL; return (void *) offset; } @@ -183,10 +192,11 @@ static const int blob_type_minlen[BLOB_ATTR_LAST] = { [BLOB_ATTR_INT16] = sizeof(uint16_t), [BLOB_ATTR_INT32] = sizeof(uint32_t), [BLOB_ATTR_INT64] = sizeof(uint64_t), + [BLOB_ATTR_DOUBLE] = sizeof(double), }; bool -blob_check_type(const void *ptr, int len, int type) +blob_check_type(const void *ptr, unsigned int len, int type) { const char *data = ptr; @@ -236,7 +246,7 @@ blob_parse(struct blob_attr *attr, struct blob_attr **data, const struct blob_at if (info[id].maxlen && len > info[id].maxlen) continue; - if (info[id].validate && !info[id].validate(&info[id], attr)) + if (info[id].validate && !info[id].validate(&info[id], pos)) continue; }