ustream-fd: readability change.

[project/libubox.git] / ustream-fd.c

diff --git a/ustream-fd.c b/ustream-fd.c
index e39da98..daef499 100644 (file)
--- a/ustream-fd.c
+++ b/ustream-fd.c
@@ -21,8 +21,6 @@
 #include <stdio.h>
 #include "ustream.h"
 
-static bool _init = false;
-
 static void ustream_fd_set_uloop(struct ustream *s, bool write)
 {
        struct ustream_fd *sf = container_of(s, struct ustream_fd, stream);
@@ -37,9 +35,6 @@ static void ustream_fd_set_uloop(struct ustream *s, bool write)
                flags |= ULOOP_WRITE;
 
        uloop_fd_add(&sf->fd, flags);
-
-       if ((flags & ULOOP_READ) && !_init);
-               sf->fd.cb(&sf->fd, ULOOP_READ);
 }
 
 static void ustream_fd_set_read_blocked(struct ustream *s)
@@ -71,8 +66,9 @@ static void ustream_fd_read_pending(struct ustream_fd *sf, bool *more)
                }
 
                if (!len) {
-                       sf->fd.eof = true;
-                       ustream_state_change(s);
+                       if (!s->eof)
+                               ustream_state_change(s);
+                       s->eof = true;
                        ustream_fd_set_uloop(s, false);
                        return;
                }
@@ -123,7 +119,8 @@ static bool __ustream_fd_poll(struct ustream_fd *sf, unsigned int events)
                ustream_fd_read_pending(sf, &more);
 
        if (events & ULOOP_WRITE) {
-               if (!ustream_write_pending(s))
+               bool no_more = ustream_write_pending(s);
+               if (no_more)
                        ustream_fd_set_uloop(s, false);
        }
 
@@ -163,7 +160,5 @@ void ustream_fd_init(struct ustream_fd *sf, int fd)
        s->write = ustream_fd_write;
        s->free = ustream_fd_free;
        s->poll = ustream_fd_poll;
-       _init = true;
        ustream_fd_set_uloop(s, false);
-       _init = false;
 }