lua: add gc/delete support for processes

[project/libubox.git] / lua / uloop.c

diff --git a/lua/uloop.c b/lua/uloop.c
index df57b8a..782b5a5 100644 (file)
--- a/lua/uloop.c
+++ b/lua/uloop.c
@@ -43,6 +43,26 @@ struct lua_uloop_process {
 
 static lua_State *state;
 
+static void *
+ul_create_userdata(lua_State *L, size_t size, const luaL_Reg *reg, lua_CFunction gc)
+{
+       void *ret = lua_newuserdata(L, size);
+
+       memset(ret, 0, size);
+       lua_createtable(L, 0, 2);
+       lua_pushvalue(L, -1);
+       lua_setfield(L, -2, "__index");
+       lua_pushcfunction(L, gc);
+       lua_setfield(L, -2, "__gc");
+       lua_pushvalue(L, -1);
+       lua_setmetatable(L, -3);
+       lua_pushvalue(L, -2);
+       luaI_openlib(L, NULL, reg, 1);
+       lua_pushvalue(L, -2);
+
+       return ret;
+}
+
 static void ul_timer_cb(struct uloop_timeout *t)
 {
        struct lua_uloop_timeout *tout = container_of(t, struct lua_uloop_timeout, t);
@@ -79,8 +99,15 @@ static int ul_timer_free(lua_State *L)
        struct lua_uloop_timeout *tout = lua_touserdata(L, 1);
 
        uloop_timeout_cancel(&tout->t);
+
+       /* obj.__index.__gc = nil , make sure executing only once*/
+       lua_getfield(L, -1, "__index");
+       lua_pushstring(L, "__gc");
+       lua_pushnil(L);
+       lua_settable(L, -3);
+
        lua_getglobal(state, "__uloop_cb");
-       luaL_unref(L, -1, tout->r);
+       luaL_unref(state, -1, tout->r);
 
        return 1;
 }
@@ -113,22 +140,10 @@ static int ul_timer(lua_State *L)
        lua_pushvalue(L, -2);
        ref = luaL_ref(L, -2);
 
-       tout = lua_newuserdata(L, sizeof(*tout));
-       lua_createtable(L, 0, 2);
-       lua_pushvalue(L, -1);
-       lua_setfield(L, -2, "__index");
-       lua_pushcfunction(L, ul_timer_free);
-       lua_setfield(L, -2, "__gc");
-       lua_pushvalue(L, -1);
-       lua_setmetatable(L, -3);
-       lua_pushvalue(L, -2);
-       luaI_openlib(L, NULL, timer_m, 1);
-       lua_pushvalue(L, -2);
-
-       memset(tout, 0, sizeof(*tout));
-
+       tout = ul_create_userdata(L, sizeof(*tout), timer_m, ul_timer_free);
        tout->r = ref;
        tout->t.cb = ul_timer_cb;
+
        if (set)
                uloop_timeout_set(&tout->t, set);
 
@@ -150,7 +165,6 @@ static void ul_ufd_cb(struct uloop_fd *fd, unsigned int events)
 
        /* push events */
        lua_pushinteger(state, events);
-
        lua_call(state, 2, 0);
 }
 
@@ -177,10 +191,20 @@ static int ul_ufd_delete(lua_State *L)
        struct lua_uloop_fd *ufd = lua_touserdata(L, 1);
 
        uloop_fd_delete(&ufd->fd);
+
+       /* obj.__index.__gc = nil , make sure executing only once*/
+       lua_getfield(L, -1, "__index");
+       lua_pushstring(L, "__gc");
+       lua_pushnil(L);
+       lua_settable(L, -3);
+
        lua_getglobal(state, "__uloop_cb");
-       luaL_unref(L, -1, ufd->r);
+       luaL_unref(state, -1, ufd->r);
+       lua_remove(state, -1);
+
        lua_getglobal(state, "__uloop_fds");
-       luaL_unref(L, -1, ufd->fd_r);
+       luaL_unref(state, -1, ufd->fd_r);
+       lua_remove(state, -1);
 
        return 1;
 }
@@ -222,21 +246,7 @@ static int ul_ufd_add(lua_State *L)
        fd_ref = luaL_ref(L, -2);
        lua_pop(L, 1);
 
-       ufd = lua_newuserdata(L, sizeof(*ufd));
-
-       lua_createtable(L, 0, 2);
-       lua_pushvalue(L, -1);
-       lua_setfield(L, -2, "__index");
-       lua_pushcfunction(L, ul_ufd_delete);
-       lua_setfield(L, -2, "__gc");
-       lua_pushvalue(L, -1);
-       lua_setmetatable(L, -3);
-       lua_pushvalue(L, -2);
-       luaI_openlib(L, NULL, ufd_m, 1);
-       lua_pushvalue(L, -2);
-
-       memset(ufd, 0, sizeof(*ufd));
-
+       ufd = ul_create_userdata(L, sizeof(*ufd), ufd_m, ul_ufd_delete);
        ufd->r = ref;
        ufd->fd.fd = fd;
        ufd->fd_r = fd_ref;
@@ -247,6 +257,32 @@ static int ul_ufd_add(lua_State *L)
        return 1;
 }
 
+static int ul_process_free(lua_State *L)
+{
+       struct lua_uloop_process *proc = lua_touserdata(L, 1);
+
+       /* obj.__index.__gc = nil , make sure executing only once*/
+       lua_getfield(L, -1, "__index");
+       lua_pushstring(L, "__gc");
+       lua_pushnil(L);
+       lua_settable(L, -3);
+
+       if (proc->r != LUA_NOREF) {
+               uloop_process_delete(&proc->p);
+
+               lua_getglobal(state, "__uloop_cb");
+               luaL_unref(state, -1, proc->r);
+               lua_remove(state, -1);
+       }
+
+       return 1;
+}
+
+static const luaL_Reg process_m[] = {
+       { "delete", ul_process_free },
+       { NULL, NULL }
+};
+
 static void ul_process_cb(struct uloop_process *p, int ret)
 {
        struct lua_uloop_process *proc = container_of(p, struct lua_uloop_process, p);
@@ -255,6 +291,7 @@ static void ul_process_cb(struct uloop_process *p, int ret)
        lua_rawgeti(state, -1, proc->r);
 
        luaL_unref(state, -2, proc->r);
+       proc->r = LUA_NOREF;
        lua_remove(state, -2);
        lua_pushinteger(state, ret >> 8);
        lua_call(state, 1, 0);
@@ -314,9 +351,7 @@ static int ul_process(lua_State *L)
        lua_pushvalue(L, -2);
        ref = luaL_ref(L, -2);
 
-       proc = lua_newuserdata(L, sizeof(*proc));
-       memset(proc, 0, sizeof(*proc));
-
+       proc = ul_create_userdata(L, sizeof(*proc), process_m, ul_process_free);
        proc->r = ref;
        proc->p.pid = pid;
        proc->p.cb = ul_process_cb;
@@ -341,12 +376,19 @@ static int ul_run(lua_State *L)
        return 1;
 }
 
+static int ul_end(lua_State *L)
+{
+       uloop_end();
+       return 1;
+}
+
 static luaL_reg uloop_func[] = {
        {"init", ul_init},
        {"run", ul_run},
        {"timer", ul_timer},
        {"process", ul_process},
        {"fd_add", ul_ufd_add},
+       {"cancel", ul_end},
        {NULL, NULL},
 };