From 8374bbbf1f5b3ebc9546503b49b595e6536ed1dd Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Fri, 22 Mar 2013 16:27:34 +0100 Subject: [PATCH 1/1] Increase compatibility to old firewall by initializing protocol of rules and redirects to tcp+udp if not specified --- redirects.c | 6 ++++++ rules.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/redirects.c b/redirects.c index 4e4f5b2..7817e9b 100644 --- a/redirects.c +++ b/redirects.c @@ -237,6 +237,12 @@ fw3_load_redirects(struct fw3_state *state, struct uci_package *p) } } + if (list_empty(&redir->proto)) + { + warn_elem(e, "does not specify a protocol, assuming TCP+UDP"); + fw3_parse_protocol(&redir->proto, "tcpudp", true); + } + if (!valid) { fw3_free_redirect(redir); diff --git a/rules.c b/rules.c index e6af62e..1037d2f 100644 --- a/rules.c +++ b/rules.c @@ -150,6 +150,12 @@ fw3_load_rules(struct fw3_state *state, struct uci_package *p) "- assuming an output rule"); } + if (list_empty(&rule->proto)) + { + warn_elem(e, "does not specify a protocol, assuming TCP+UDP"); + fw3_parse_protocol(&rule->proto, "tcpudp", true); + } + if (rule->target == FW3_FLAG_UNSPEC) { warn_elem(e, "has no target specified, defaulting to REJECT"); -- 2.11.0