X-Git-Url: http://git.archive.openwrt.org/?p=project%2Ffirewall3.git;a=blobdiff_plain;f=zones.c;h=505ab208b24b2fb7a0c25a54efe942b0f9c86433;hp=317acc822198300a3eda4999a03b6db28ed8d24e;hb=HEAD;hpb=275a37dbf280bd471ebb2c673267c49a81071bbb diff --git a/zones.c b/zones.c index 317acc8..505ab20 100644 --- a/zones.c +++ b/zones.c @@ -1,7 +1,7 @@ /* * firewall3 - 3rd OpenWrt UCI firewall implementation * - * Copyright (C) 2013 Jo-Philipp Wich + * Copyright (C) 2013 Jo-Philipp Wich * * Permission to use, copy, modify, and/or distribute this software for any * purpose with or without fee is hereby granted, provided that the above @@ -18,113 +18,123 @@ #include "zones.h" #include "ubus.h" +#include "helpers.h" -#define C(f, tbl, tgt, name) \ - { FW3_FAMILY_##f, FW3_TABLE_##tbl, FW3_TARGET_##tgt, name } +#define C(f, tbl, tgt, fmt) \ + { FW3_FAMILY_##f, FW3_TABLE_##tbl, FW3_FLAG_##tgt, fmt } -struct chain { - enum fw3_family family; - enum fw3_table table; - enum fw3_target target; - const char *name; -}; +static const struct fw3_chain_spec zone_chains[] = { + C(ANY, FILTER, UNSPEC, "zone_%s_input"), + C(ANY, FILTER, UNSPEC, "zone_%s_output"), + C(ANY, FILTER, UNSPEC, "zone_%s_forward"), -static const struct chain src_chains[] = { - C(ANY, FILTER, UNSPEC, "zone_%s_input"), - C(ANY, FILTER, UNSPEC, "zone_%s_output"), - C(ANY, FILTER, UNSPEC, "zone_%s_forward"), + C(ANY, FILTER, SRC_ACCEPT, "zone_%s_src_ACCEPT"), + C(ANY, FILTER, SRC_REJECT, "zone_%s_src_REJECT"), + C(ANY, FILTER, SRC_DROP, "zone_%s_src_DROP"), - C(ANY, FILTER, ACCEPT, "zone_%s_src_ACCEPT"), - C(ANY, FILTER, REJECT, "zone_%s_src_REJECT"), - C(ANY, FILTER, DROP, "zone_%s_src_DROP"), -}; + C(ANY, FILTER, ACCEPT, "zone_%s_dest_ACCEPT"), + C(ANY, FILTER, REJECT, "zone_%s_dest_REJECT"), + C(ANY, FILTER, DROP, "zone_%s_dest_DROP"), + + C(V4, NAT, SNAT, "zone_%s_postrouting"), + C(V4, NAT, DNAT, "zone_%s_prerouting"), + + C(ANY, RAW, HELPER, "zone_%s_helper"), + C(ANY, RAW, NOTRACK, "zone_%s_notrack"), -static const struct chain dst_chains[] = { - C(ANY, FILTER, ACCEPT, "zone_%s_dest_ACCEPT"), - C(ANY, FILTER, REJECT, "zone_%s_dest_REJECT"), - C(ANY, FILTER, DROP, "zone_%s_dest_DROP"), + C(ANY, FILTER, CUSTOM_CHAINS, "input_%s_rule"), + C(ANY, FILTER, CUSTOM_CHAINS, "output_%s_rule"), + C(ANY, FILTER, CUSTOM_CHAINS, "forwarding_%s_rule"), - C(V4, NAT, SNAT, "zone_%s_postrouting"), - C(V4, NAT, DNAT, "zone_%s_prerouting"), + C(V4, NAT, CUSTOM_CHAINS, "prerouting_%s_rule"), + C(V4, NAT, CUSTOM_CHAINS, "postrouting_%s_rule"), - C(ANY, RAW, NOTRACK, "zone_%s_notrack"), + { } }; -static struct fw3_option zone_opts[] = { +enum fw3_zone_logmask { + FW3_ZONE_LOG_FILTER = (1 << 0), + FW3_ZONE_LOG_MANGLE = (1 << 1), +}; + +const struct fw3_option fw3_zone_opts[] = { + FW3_OPT("enabled", bool, zone, enabled), + FW3_OPT("name", string, zone, name), FW3_OPT("family", family, zone, family), FW3_LIST("network", device, zone, networks), FW3_LIST("device", device, zone, devices), - FW3_LIST("subnet", address, zone, subnets), + FW3_LIST("subnet", network, zone, subnets), FW3_OPT("input", target, zone, policy_input), FW3_OPT("forward", target, zone, policy_forward), FW3_OPT("output", target, zone, policy_output), FW3_OPT("masq", bool, zone, masq), - FW3_LIST("masq_src", address, zone, masq_src), - FW3_LIST("masq_dest", address, zone, masq_dest), + FW3_OPT("masq_allow_invalid", bool, zone, masq_allow_invalid), + FW3_LIST("masq_src", network, zone, masq_src), + FW3_LIST("masq_dest", network, zone, masq_dest), FW3_OPT("extra", string, zone, extra_src), FW3_OPT("extra_src", string, zone, extra_src), FW3_OPT("extra_dest", string, zone, extra_dest), - FW3_OPT("conntrack", bool, zone, conntrack), FW3_OPT("mtu_fix", bool, zone, mtu_fix), FW3_OPT("custom_chains", bool, zone, custom_chains), - FW3_OPT("log", bool, zone, log), + FW3_OPT("log", int, zone, log), FW3_OPT("log_limit", limit, zone, log_limit), -}; + FW3_OPT("auto_helper", bool, zone, auto_helper), + FW3_LIST("helper", cthelper, zone, cthelpers), -static bool -print_chains(enum fw3_table table, enum fw3_family family, - const char *fmt, const char *name, uint16_t targets, - const struct chain *chains, int n) -{ - bool rv = false; - char cn[128] = { 0 }; - const struct chain *c; + FW3_OPT("__flags_v4", int, zone, flags[0]), + FW3_OPT("__flags_v6", int, zone, flags[1]), - for (c = chains; n > 0; c++, n--) - { - if (!fw3_is_family(c, family)) - continue; + FW3_LIST("__addrs", address, zone, old_addrs), - if (c->table != table) - continue; - - if ((c->target != FW3_TARGET_UNSPEC) && !hasbit(targets, c->target)) - continue; - - snprintf(cn, sizeof(cn), c->name, name); - fw3_pr(fmt, cn); - - rv = true; - } + { } +}; - return rv; -} static void -check_policy(struct uci_element *e, enum fw3_target *pol, enum fw3_target def, +check_policy(struct uci_element *e, enum fw3_flag *pol, enum fw3_flag def, const char *name) { - if (*pol == FW3_TARGET_UNSPEC) + if (*pol == FW3_FLAG_UNSPEC) { warn_elem(e, "has no %s policy specified, using default", name); *pol = def; } - else if (*pol > FW3_TARGET_DROP) + else if (*pol > FW3_FLAG_DROP) { warn_elem(e, "has invalid %s policy, using default", name); *pol = def; } } +static bool +check_masq_addrs(struct list_head *head) +{ + struct fw3_address *addr; + int n_addr = 0, n_failed = 0; + + list_for_each_entry(addr, head, list) + { + if (addr->invert) + continue; + + n_addr++; + + if (!addr->set && addr->resolved) + n_failed++; + } + + return (n_addr == 0 || n_failed < n_addr); +} + static void resolve_networks(struct uci_element *e, struct fw3_zone *zone) { @@ -140,28 +150,72 @@ resolve_networks(struct uci_element *e, struct fw3_zone *zone) continue; } + snprintf(tmp->network, sizeof(tmp->network), "%s", net->name); list_add_tail(&tmp->list, &zone->devices); } } +static void +resolve_cthelpers(struct fw3_state *s, struct uci_element *e, struct fw3_zone *zone) +{ + struct fw3_cthelpermatch *match; + + if (list_empty(&zone->cthelpers)) + { + if (!zone->masq && zone->auto_helper) + { + fw3_setbit(zone->flags[0], FW3_FLAG_HELPER); + fw3_setbit(zone->flags[1], FW3_FLAG_HELPER); + } + + return; + } + + list_for_each_entry(match, &zone->cthelpers, list) + { + if (match->invert) + { + warn_elem(e, "must not use a negated helper match"); + continue; + } + + match->ptr = fw3_lookup_cthelper(s, match->name); + + if (!match->ptr) + { + warn_elem(e, "refers to not existing helper '%s'", match->name); + continue; + } + + if (fw3_is_family(match->ptr, FW3_FAMILY_V4)) + fw3_setbit(zone->flags[0], FW3_FLAG_HELPER); + + if (fw3_is_family(match->ptr, FW3_FAMILY_V6)) + fw3_setbit(zone->flags[1], FW3_FLAG_HELPER); + } +} + struct fw3_zone * fw3_alloc_zone(void) { struct fw3_zone *zone; - zone = malloc(sizeof(*zone)); - + zone = calloc(1, sizeof(*zone)); if (!zone) return NULL; - memset(zone, 0, sizeof(*zone)); - INIT_LIST_HEAD(&zone->networks); INIT_LIST_HEAD(&zone->devices); INIT_LIST_HEAD(&zone->subnets); INIT_LIST_HEAD(&zone->masq_src); INIT_LIST_HEAD(&zone->masq_dest); + INIT_LIST_HEAD(&zone->cthelpers); + + INIT_LIST_HEAD(&zone->old_addrs); + zone->enabled = true; + zone->auto_helper = true; + zone->custom_chains = true; zone->log_limit.rate = 10; return zone; @@ -189,11 +243,24 @@ fw3_load_zones(struct fw3_state *state, struct uci_package *p) if (!zone) continue; - fw3_parse_options(zone, zone_opts, ARRAY_SIZE(zone_opts), s); + if (!fw3_parse_options(zone, fw3_zone_opts, s)) + warn_elem(e, "has invalid options"); + + if (!zone->enabled) + { + fw3_free_zone(zone); + continue; + } if (!zone->extra_dest) zone->extra_dest = zone->extra_src; + if (!defs->custom_chains && zone->custom_chains) + zone->custom_chains = false; + + if (!defs->auto_helper && zone->auto_helper) + zone->auto_helper = false; + if (!zone->name || !*zone->name) { warn_elem(e, "has no name - ignoring"); @@ -201,12 +268,34 @@ fw3_load_zones(struct fw3_state *state, struct uci_package *p) continue; } + if (strlen(zone->name) > FW3_ZONE_MAXNAMELEN) + { + warn_elem(e, "must not have a name longer than %u characters", + FW3_ZONE_MAXNAMELEN); + fw3_free_zone(zone); + continue; + } + + fw3_ubus_zone_devices(zone); + if (list_empty(&zone->networks) && list_empty(&zone->devices) && list_empty(&zone->subnets) && !zone->extra_src) { warn_elem(e, "has no device, network, subnet or extra options"); } + if (!check_masq_addrs(&zone->masq_src)) + { + warn_elem(e, "has unresolved masq_src, disabling masq"); + zone->masq = false; + } + + if (!check_masq_addrs(&zone->masq_dest)) + { + warn_elem(e, "has unresolved masq_dest, disabling masq"); + zone->masq = false; + } + check_policy(e, &zone->policy_input, defs->policy_input, "input"); check_policy(e, &zone->policy_output, defs->policy_output, "output"); check_policy(e, &zone->policy_forward, defs->policy_forward, "forward"); @@ -215,13 +304,24 @@ fw3_load_zones(struct fw3_state *state, struct uci_package *p) if (zone->masq) { - setbit(zone->dst_flags, FW3_TARGET_SNAT); - zone->conntrack = true; + fw3_setbit(zone->flags[0], FW3_FLAG_SNAT); + } + + if (zone->custom_chains) + { + fw3_setbit(zone->flags[0], FW3_FLAG_SNAT); + fw3_setbit(zone->flags[0], FW3_FLAG_DNAT); } - setbit(zone->src_flags, zone->policy_input); - setbit(zone->dst_flags, zone->policy_output); - setbit(zone->dst_flags, zone->policy_forward); + resolve_cthelpers(state, e, zone); + + fw3_setbit(zone->flags[0], fw3_to_src_target(zone->policy_input)); + fw3_setbit(zone->flags[0], zone->policy_forward); + fw3_setbit(zone->flags[0], zone->policy_output); + + fw3_setbit(zone->flags[1], fw3_to_src_target(zone->policy_input)); + fw3_setbit(zone->flags[1], zone->policy_forward); + fw3_setbit(zone->flags[1], zone->policy_output); list_add_tail(&zone->list, &state->zones); } @@ -229,143 +329,257 @@ fw3_load_zones(struct fw3_state *state, struct uci_package *p) static void -print_zone_chain(enum fw3_table table, enum fw3_family family, - struct fw3_zone *zone, struct fw3_state *state) +print_zone_chain(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload, struct fw3_zone *zone) { - bool s, d; - - if (!fw3_is_family(zone, family)) + int i; + struct fw3_ipt_rule *r; + const struct fw3_chain_spec *c; + + const char *flt_chains[] = { + "input", "input", + "output", "output", + "forward", "forwarding", + }; + + const char *nat_chains[] = { + "prerouting", "prerouting", + "postrouting", "postrouting", + }; + + if (!fw3_is_family(zone, handle->family)) return; - setbit(zone->dst_flags, family); + set(zone->flags, handle->family, handle->table); + + if (zone->custom_chains) + set(zone->flags, handle->family, FW3_FLAG_CUSTOM_CHAINS); + + for (c = zone_chains; c->format; c++) + { + /* don't touch user chains on selective stop */ + if (reload && c->flag == FW3_FLAG_CUSTOM_CHAINS) + continue; + + if (!fw3_is_family(c, handle->family)) + continue; - if (!zone->conntrack && !state->defaults.drop_invalid) - setbit(zone->dst_flags, FW3_TARGET_NOTRACK); + if (c->table != handle->table) + continue; - s = print_chains(table, family, ":%s - [0:0]\n", zone->name, - zone->src_flags, src_chains, ARRAY_SIZE(src_chains)); + if (c->flag && + !fw3_hasbit(zone->flags[handle->family == FW3_FAMILY_V6], c->flag)) + continue; - d = print_chains(table, family, ":%s - [0:0]\n", zone->name, - zone->dst_flags, dst_chains, ARRAY_SIZE(dst_chains)); + fw3_ipt_create_chain(handle, c->format, zone->name); + } - if (s || d) + if (zone->custom_chains) { - info(" * Zone '%s'", zone->name); - fw3_set_running(zone, &state->running_zones); + if (handle->table == FW3_TABLE_FILTER) + { + for (i = 0; i < sizeof(flt_chains)/sizeof(flt_chains[0]); i += 2) + { + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_comment(r, "Custom %s %s rule chain", zone->name, flt_chains[i+1]); + fw3_ipt_rule_target(r, "%s_%s_rule", flt_chains[i+1], zone->name); + fw3_ipt_rule_append(r, "zone_%s_%s", zone->name, flt_chains[i]); + } + } + else if (handle->table == FW3_TABLE_NAT) + { + for (i = 0; i < sizeof(nat_chains)/sizeof(nat_chains[0]); i += 2) + { + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_comment(r, "Custom %s %s rule chain", zone->name, nat_chains[i+1]); + fw3_ipt_rule_target(r, "%s_%s_rule", nat_chains[i+1], zone->name); + fw3_ipt_rule_append(r, "zone_%s_%s", zone->name, nat_chains[i]); + } + } } + + set(zone->flags, handle->family, handle->table); } static void -print_interface_rule(enum fw3_table table, enum fw3_family family, - struct fw3_zone *zone, struct fw3_device *dev, - struct fw3_address *sub, bool disable_notrack) +print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload, struct fw3_zone *zone, + struct fw3_device *dev, struct fw3_address *sub) { - enum fw3_target t; + struct fw3_protocol tcp = { .protocol = 6 }; + struct fw3_ipt_rule *r; + enum fw3_flag t; + + char buf[32]; + + int i; + + const char *chains[] = { + "input", "INPUT", + "output", "OUTPUT", + "forward", "FORWARD", + }; #define jump_target(t) \ - ((t == FW3_TARGET_REJECT) ? "reject" : fw3_flag_names[t]) + ((t == FW3_FLAG_REJECT) ? "reject" : fw3_flag_names[t]) - if (table == FW3_TABLE_FILTER) + if (handle->table == FW3_TABLE_FILTER) { - for (t = FW3_TARGET_ACCEPT; t <= FW3_TARGET_DROP; t++) + for (t = FW3_FLAG_ACCEPT; t <= FW3_FLAG_DROP; t++) { - if (hasbit(zone->src_flags, t)) + if (t > FW3_FLAG_ACCEPT && zone->log & FW3_ZONE_LOG_FILTER) { - fw3_pr("-A zone_%s_src_%s", zone->name, fw3_flag_names[t]); - fw3_format_in_out(dev, NULL); - fw3_format_src_dest(sub, NULL); - fw3_format_extra(zone->extra_src); - fw3_pr(" -j %s\n", jump_target(t)); + if (has(zone->flags, handle->family, fw3_to_src_target(t))) + { + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + + snprintf(buf, sizeof(buf) - 1, "%s %s in: ", + fw3_flag_names[t], zone->name); + + fw3_ipt_rule_limit(r, &zone->log_limit); + fw3_ipt_rule_target(r, "LOG"); + fw3_ipt_rule_addarg(r, false, "--log-prefix", buf); + fw3_ipt_rule_replace(r, "zone_%s_src_%s", + zone->name, fw3_flag_names[t]); + } + + if (has(zone->flags, handle->family, t)) + { + r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub); + + snprintf(buf, sizeof(buf) - 1, "%s %s out: ", + fw3_flag_names[t], zone->name); + + fw3_ipt_rule_limit(r, &zone->log_limit); + fw3_ipt_rule_target(r, "LOG"); + fw3_ipt_rule_addarg(r, false, "--log-prefix", buf); + fw3_ipt_rule_replace(r, "zone_%s_dest_%s", + zone->name, fw3_flag_names[t]); + } + } + + if (has(zone->flags, handle->family, fw3_to_src_target(t))) + { + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + fw3_ipt_rule_target(r, jump_target(t)); + fw3_ipt_rule_extra(r, zone->extra_src); + + if (t == FW3_FLAG_ACCEPT && !state->defaults.drop_invalid) + fw3_ipt_rule_extra(r, + "-m conntrack --ctstate NEW,UNTRACKED"); + + fw3_ipt_rule_replace(r, "zone_%s_src_%s", zone->name, + fw3_flag_names[t]); } - if (hasbit(zone->dst_flags, t)) + if (has(zone->flags, handle->family, t)) { - fw3_pr("-A zone_%s_dest_%s", zone->name, fw3_flag_names[t]); - fw3_format_in_out(NULL, dev); - fw3_format_src_dest(NULL, sub); - fw3_format_extra(zone->extra_dest); - fw3_pr(" -j %s\n", jump_target(t)); + if (t == FW3_FLAG_ACCEPT && + zone->masq && !zone->masq_allow_invalid) + { + r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub); + fw3_ipt_rule_extra(r, "-m conntrack --ctstate INVALID"); + fw3_ipt_rule_comment(r, "Prevent NAT leakage"); + fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_DROP]); + fw3_ipt_rule_replace(r, "zone_%s_dest_%s", zone->name, + fw3_flag_names[t]); + } + + r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub); + fw3_ipt_rule_target(r, jump_target(t)); + fw3_ipt_rule_extra(r, zone->extra_dest); + fw3_ipt_rule_replace(r, "zone_%s_dest_%s", zone->name, + fw3_flag_names[t]); } } - fw3_pr("-A delegate_input"); - fw3_format_in_out(dev, NULL); - fw3_format_src_dest(sub, NULL); - fw3_format_extra(zone->extra_src); - fw3_pr(" -j zone_%s_input\n", zone->name); - - fw3_pr("-A delegate_forward"); - fw3_format_in_out(dev, NULL); - fw3_format_src_dest(sub, NULL); - fw3_format_extra(zone->extra_src); - fw3_pr(" -j zone_%s_forward\n", zone->name); - - fw3_pr("-A delegate_output"); - fw3_format_in_out(NULL, dev); - fw3_format_src_dest(NULL, sub); - fw3_format_extra(zone->extra_dest); - fw3_pr(" -j zone_%s_output\n", zone->name); + for (i = 0; i < sizeof(chains)/sizeof(chains[0]); i += 2) + { + if (*chains[i] == 'o') + r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub); + else + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + + fw3_ipt_rule_target(r, "zone_%s_%s", zone->name, chains[i]); + + if (*chains[i] == 'o') + fw3_ipt_rule_extra(r, zone->extra_dest); + else + fw3_ipt_rule_extra(r, zone->extra_src); + + fw3_ipt_rule_replace(r, chains[i + 1]); + } } - else if (table == FW3_TABLE_NAT) + else if (handle->table == FW3_TABLE_NAT) { - if (hasbit(zone->dst_flags, FW3_TARGET_DNAT)) + if (has(zone->flags, handle->family, FW3_FLAG_DNAT)) { - fw3_pr("-A delegate_prerouting"); - fw3_format_in_out(dev, NULL); - fw3_format_src_dest(sub, NULL); - fw3_format_extra(zone->extra_src); - fw3_pr(" -j zone_%s_prerouting\n", zone->name); + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + fw3_ipt_rule_target(r, "zone_%s_prerouting", zone->name); + fw3_ipt_rule_extra(r, zone->extra_src); + fw3_ipt_rule_replace(r, "PREROUTING"); } - if (hasbit(zone->dst_flags, FW3_TARGET_SNAT)) + if (has(zone->flags, handle->family, FW3_FLAG_SNAT)) { - fw3_pr("-A delegate_postrouting"); - fw3_format_in_out(NULL, dev); - fw3_format_src_dest(NULL, sub); - fw3_format_extra(zone->extra_dest); - fw3_pr(" -j zone_%s_postrouting\n", zone->name); + r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub); + fw3_ipt_rule_target(r, "zone_%s_postrouting", zone->name); + fw3_ipt_rule_extra(r, zone->extra_dest); + fw3_ipt_rule_replace(r, "POSTROUTING"); } } - else if (table == FW3_TABLE_MANGLE) + else if (handle->table == FW3_TABLE_MANGLE) { if (zone->mtu_fix) { - if (zone->log) + if (zone->log & FW3_ZONE_LOG_MANGLE) { - fw3_pr("-A mssfix"); - fw3_format_in_out(NULL, dev); - fw3_format_src_dest(NULL, sub); - fw3_pr(" -p tcp --tcp-flags SYN,RST SYN"); - fw3_format_limit(&zone->log_limit); - fw3_format_comment(zone->name, " (mtu_fix logging)"); - fw3_pr(" -j LOG --log-prefix \"MSSFIX(%s): \"\n", zone->name); + snprintf(buf, sizeof(buf) - 1, "MSSFIX %s out: ", zone->name); + + r = fw3_ipt_rule_create(handle, &tcp, NULL, dev, NULL, sub); + fw3_ipt_rule_addarg(r, false, "--tcp-flags", "SYN,RST"); + fw3_ipt_rule_addarg(r, false, "SYN", NULL); + fw3_ipt_rule_limit(r, &zone->log_limit); + fw3_ipt_rule_comment(r, "Zone %s MTU fix logging", zone->name); + fw3_ipt_rule_target(r, "LOG"); + fw3_ipt_rule_addarg(r, false, "--log-prefix", buf); + fw3_ipt_rule_replace(r, "FORWARD"); } - fw3_pr("-A mssfix"); - fw3_format_in_out(NULL, dev); - fw3_format_src_dest(NULL, sub); - fw3_pr(" -p tcp --tcp-flags SYN,RST SYN"); - fw3_format_comment(zone->name, " (mtu_fix)"); - fw3_pr(" -j TCPMSS --clamp-mss-to-pmtu\n"); + r = fw3_ipt_rule_create(handle, &tcp, NULL, dev, NULL, sub); + fw3_ipt_rule_addarg(r, false, "--tcp-flags", "SYN,RST"); + fw3_ipt_rule_addarg(r, false, "SYN", NULL); + fw3_ipt_rule_comment(r, "Zone %s MTU fixing", zone->name); + fw3_ipt_rule_target(r, "TCPMSS"); + fw3_ipt_rule_addarg(r, false, "--clamp-mss-to-pmtu", NULL); + fw3_ipt_rule_replace(r, "FORWARD"); } } - else if (table == FW3_TABLE_RAW) + else if (handle->table == FW3_TABLE_RAW) { - if (!zone->conntrack && !disable_notrack) + if (has(zone->flags, handle->family, FW3_FLAG_HELPER)) + { + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + fw3_ipt_rule_comment(r, "%s CT helper assignment", zone->name); + fw3_ipt_rule_target(r, "zone_%s_helper", zone->name); + fw3_ipt_rule_extra(r, zone->extra_src); + fw3_ipt_rule_replace(r, "PREROUTING"); + } + + if (has(zone->flags, handle->family, FW3_FLAG_NOTRACK)) { - fw3_pr("-A notrack"); - fw3_format_in_out(dev, NULL); - fw3_format_src_dest(sub, NULL); - fw3_format_extra(zone->extra_src); - fw3_format_comment(zone->name, " (notrack)"); - fw3_pr(" -j CT --notrack\n", zone->name); + r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL); + fw3_ipt_rule_comment(r, "%s CT bypass", zone->name); + fw3_ipt_rule_target(r, "zone_%s_notrack", zone->name); + fw3_ipt_rule_extra(r, zone->extra_src); + fw3_ipt_rule_replace(r, "PREROUTING"); } } } static void -print_interface_rules(enum fw3_table table, enum fw3_family family, - struct fw3_zone *zone, bool disable_notrack) +print_interface_rules(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload, struct fw3_zone *zone) { struct fw3_device *dev; struct fw3_address *sub; @@ -373,134 +587,231 @@ print_interface_rules(enum fw3_table table, enum fw3_family family, fw3_foreach(dev, &zone->devices) fw3_foreach(sub, &zone->subnets) { - if (!fw3_is_family(sub, family)) + if (!fw3_is_family(sub, handle->family)) continue; if (!dev && !sub) continue; - print_interface_rule(table, family, zone, dev, sub, disable_notrack); + print_interface_rule(handle, state, reload, zone, dev, sub); + } +} + +static struct fw3_address * +next_addr(struct fw3_address *addr, struct list_head *list, + enum fw3_family family, bool invert) +{ + struct list_head *p; + struct fw3_address *rv; + + for (p = addr ? addr->list.next : list->next; p != list; p = p->next) + { + rv = list_entry(p, struct fw3_address, list); + + if (fw3_is_family(rv, family) && rv->set && rv->invert == invert) + return rv; } + + return NULL; } static void -print_zone_rule(enum fw3_table table, enum fw3_family family, - struct fw3_zone *zone, bool disable_notrack) +print_zone_rule(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload, struct fw3_zone *zone) { + bool first_src, first_dest; struct fw3_address *msrc; struct fw3_address *mdest; + struct fw3_ipt_rule *r; - enum fw3_target t; - - if (!fw3_is_family(zone, family)) + if (!fw3_is_family(zone, handle->family)) return; - switch (table) + info(" * Zone '%s'", zone->name); + + switch (handle->table) { case FW3_TABLE_FILTER: - fw3_pr("-A zone_%s_input -j zone_%s_src_%s\n", - zone->name, zone->name, fw3_flag_names[zone->policy_input]); + if (has(zone->flags, handle->family, FW3_FLAG_DNAT)) + { + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT"); + fw3_ipt_rule_comment(r, "Accept port redirections"); + fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]); + fw3_ipt_rule_append(r, "zone_%s_input", zone->name); + + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT"); + fw3_ipt_rule_comment(r, "Accept port forwards"); + fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]); + fw3_ipt_rule_append(r, "zone_%s_forward", zone->name); + } - fw3_pr("-A zone_%s_forward -j zone_%s_dest_%s\n", - zone->name, zone->name, fw3_flag_names[zone->policy_forward]); + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_target(r, "zone_%s_src_%s", zone->name, + fw3_flag_names[zone->policy_input]); + fw3_ipt_rule_append(r, "zone_%s_input", zone->name); - fw3_pr("-A zone_%s_output -j zone_%s_dest_%s\n", - zone->name, zone->name, fw3_flag_names[zone->policy_output]); + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_target(r, "zone_%s_dest_%s", zone->name, + fw3_flag_names[zone->policy_forward]); + fw3_ipt_rule_append(r, "zone_%s_forward", zone->name); - if (zone->log) - { - for (t = FW3_TARGET_REJECT; t <= FW3_TARGET_DROP; t++) - { - if (hasbit(zone->src_flags, t)) - { - fw3_pr("-A zone_%s_src_%s", zone->name, fw3_flag_names[t]); - fw3_format_limit(&zone->log_limit); - fw3_pr(" -j LOG --log-prefix \"%s(src %s)\"\n", - fw3_flag_names[t], zone->name); - } + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_target(r, "zone_%s_dest_%s", zone->name, + fw3_flag_names[zone->policy_output]); + fw3_ipt_rule_append(r, "zone_%s_output", zone->name); - if (hasbit(zone->dst_flags, t)) - { - fw3_pr("-A zone_%s_dest_%s", zone->name, fw3_flag_names[t]); - fw3_format_limit(&zone->log_limit); - fw3_pr(" -j LOG --log-prefix \"%s(dest %s)\"\n", - fw3_flag_names[t], zone->name); - } - } - } break; case FW3_TABLE_NAT: - if (zone->masq && family == FW3_FAMILY_V4) + if (zone->masq && handle->family == FW3_FAMILY_V4) { - fw3_foreach(msrc, &zone->masq_src) - fw3_foreach(mdest, &zone->masq_dest) + /* for any negated masq_src ip, emit -s addr -j RETURN rules */ + for (msrc = NULL; + (msrc = next_addr(msrc, &zone->masq_src, + handle->family, true)) != NULL; ) + { + msrc->invert = false; + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_src_dest(r, msrc, NULL); + fw3_ipt_rule_target(r, "RETURN"); + fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name); + msrc->invert = true; + } + + /* for any negated masq_dest ip, emit -d addr -j RETURN rules */ + for (mdest = NULL; + (mdest = next_addr(mdest, &zone->masq_dest, + handle->family, true)) != NULL; ) + { + mdest->invert = false; + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_src_dest(r, NULL, mdest); + fw3_ipt_rule_target(r, "RETURN"); + fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name); + mdest->invert = true; + } + + /* emit masquerading entries for non-negated addresses + and ensure that both src and dest loops run at least once, + even if there are no relevant addresses */ + for (first_src = true, msrc = NULL; + (msrc = next_addr(msrc, &zone->masq_src, + handle->family, false)) || first_src; + first_src = false) { - fw3_pr("-A zone_%s_postrouting ", zone->name); - fw3_format_src_dest(msrc, mdest); - fw3_pr("-j MASQUERADE\n"); + for (first_dest = true, mdest = NULL; + (mdest = next_addr(mdest, &zone->masq_dest, + handle->family, false)) || first_dest; + first_dest = false) + { + r = fw3_ipt_rule_new(handle); + fw3_ipt_rule_src_dest(r, msrc, mdest); + fw3_ipt_rule_target(r, "MASQUERADE"); + fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name); + } } } break; case FW3_TABLE_RAW: + fw3_print_cthelpers(handle, state, zone); + break; + case FW3_TABLE_MANGLE: break; } - print_interface_rules(table, family, zone, disable_notrack); + print_interface_rules(handle, state, reload, zone); } void -fw3_print_zone_chains(enum fw3_table table, enum fw3_family family, - struct fw3_state *state) +fw3_print_zone_chains(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload) { struct fw3_zone *zone; list_for_each_entry(zone, &state->zones, list) - print_zone_chain(table, family, zone, state); + print_zone_chain(handle, state, reload, zone); } void -fw3_print_zone_rules(enum fw3_table table, enum fw3_family family, - struct fw3_state *state) +fw3_print_zone_rules(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload) { struct fw3_zone *zone; list_for_each_entry(zone, &state->zones, list) - print_zone_rule(table, family, zone, state->defaults.drop_invalid); + print_zone_rule(handle, state, reload, zone); } void -fw3_flush_zones(enum fw3_table table, enum fw3_family family, - bool pass2, struct fw3_state *state) +fw3_flush_zones(struct fw3_ipt_handle *handle, struct fw3_state *state, + bool reload) { struct fw3_zone *z, *tmp; - int mask = (1 << FW3_FAMILY_V4) | (1 << FW3_FAMILY_V6); + const struct fw3_chain_spec *c; + char chain[32]; - list_for_each_entry_safe(z, tmp, &state->running_zones, running_list) + list_for_each_entry_safe(z, tmp, &state->zones, list) { - if (!hasbit(z->dst_flags, family)) + if (!has(z->flags, handle->family, handle->table)) continue; - print_chains(table, family, pass2 ? "-X %s\n" : "-F %s\n", - z->name, z->src_flags, src_chains, ARRAY_SIZE(src_chains)); + for (c = zone_chains; c->format; c++) + { + /* don't touch user chains on selective stop */ + if (reload && c->flag == FW3_FLAG_CUSTOM_CHAINS) + continue; + + if (!fw3_is_family(c, handle->family)) + continue; + + if (c->table != handle->table) + continue; + + if (c->flag && !has(z->flags, handle->family, c->flag)) + continue; + + snprintf(chain, sizeof(chain), c->format, z->name); + fw3_ipt_flush_chain(handle, chain); + + /* keep certain basic chains that do not depend on any settings to + avoid purging unrelated user rules pointing to them */ + if (reload && !c->flag) + continue; + + fw3_ipt_delete_chain(handle, chain); + } + + del(z->flags, handle->family, handle->table); + } +} - print_chains(table, family, pass2 ? "-X %s\n" : "-F %s\n", - z->name, z->dst_flags, dst_chains, ARRAY_SIZE(dst_chains)); +void +fw3_hotplug_zones(struct fw3_state *state, bool add) +{ + struct fw3_zone *z; + struct fw3_device *d; - if (pass2) + list_for_each_entry(z, &state->zones, list) + { + if (add != fw3_hasbit(z->flags[0], FW3_FLAG_HOTPLUG)) { - delbit(z->dst_flags, family); + list_for_each_entry(d, &z->devices, list) + fw3_hotplug(add, z, d); - if (!(z->dst_flags & mask)) - fw3_set_running(z, NULL); + if (add) + fw3_setbit(z->flags[0], FW3_FLAG_HOTPLUG); + else + fw3_delbit(z->flags[0], FW3_FLAG_HOTPLUG); } } } struct fw3_zone * -fw3_lookup_zone(struct fw3_state *state, const char *name, bool running) +fw3_lookup_zone(struct fw3_state *state, const char *name) { struct fw3_zone *z; @@ -512,24 +823,51 @@ fw3_lookup_zone(struct fw3_state *state, const char *name, bool running) if (strcmp(z->name, name)) continue; - if (!running || z->running_list.next) - return z; - - break; + return z; } return NULL; } -void -fw3_free_zone(struct fw3_zone *zone) +struct list_head * +fw3_resolve_zone_addresses(struct fw3_zone *zone, struct fw3_address *addr) { - fw3_free_list(&zone->networks); - fw3_free_list(&zone->devices); - fw3_free_list(&zone->subnets); + struct fw3_device *net; + struct fw3_address *cur, *tmp; + struct list_head *all; + + all = calloc(1, sizeof(*all)); + if (!all) + return NULL; + + INIT_LIST_HEAD(all); - fw3_free_list(&zone->masq_src); - fw3_free_list(&zone->masq_dest); + if (addr && addr->set) + { + tmp = malloc(sizeof(*tmp)); + + if (tmp) + { + *tmp = *addr; + list_add_tail(&tmp->list, all); + } + } + else + { + list_for_each_entry(net, &zone->networks, list) + fw3_ubus_address(all, net->name); + + list_for_each_entry(cur, &zone->subnets, list) + { + tmp = malloc(sizeof(*tmp)); + + if (!tmp) + continue; + + *tmp = *cur; + list_add_tail(&tmp->list, all); + } + } - free(zone); + return all; }