X-Git-Url: http://git.archive.openwrt.org/?p=project%2Ffirewall3.git;a=blobdiff_plain;f=utils.c;h=9b383a35a414e764cad51a2b8d833deb3bb66b0d;hp=34464ee638c1e04c028a337469cd32b125c3f335;hb=61cc1d220c95168faf24bececc752a5af7ce6431;hpb=d5473f2bf38b9ba35cd455bb7acbdad9b0651de4 diff --git a/utils.c b/utils.c index 34464ee..9b383a3 100644 --- a/utils.c +++ b/utils.c @@ -27,6 +27,9 @@ static int lock_fd = -1; static pid_t pipe_pid = -1; static FILE *pipe_fd = NULL; +bool fw3_pr_debug = false; + + static void warn_elem_section_name(struct uci_section *s, bool find_name) { @@ -250,10 +253,18 @@ __fw3_command_pipe(bool silent, const char *command, ...) void fw3_pr(const char *fmt, ...) { - va_list args; - va_start(args, fmt); - vfprintf(pipe_fd, fmt, args); - va_end(args); + va_list args; + + if (fw3_pr_debug && pipe_fd != stdout) + { + va_start(args, fmt); + vfprintf(stderr, fmt, args); + va_end(args); + } + + va_start(args, fmt); + vfprintf(pipe_fd, fmt, args); + va_end(args); } void @@ -341,11 +352,11 @@ fw3_read_statefile(void *state) { FILE *sf; - int n, type; + int type; char line[128]; const char *p, *name; - uint16_t flags[2]; + uint32_t flags; struct fw3_state *s = state; struct fw3_zone *zone; @@ -363,23 +374,23 @@ fw3_read_statefile(void *state) if (!p) continue; - type = strtoul(p, NULL, 10); + type = strtoul(p, NULL, 16); name = strtok(NULL, " \t\n"); if (!name) continue; - for (n = 0, p = strtok(NULL, " \t\n"); - n < ARRAY_SIZE(flags) && p != NULL; - n++, p = strtok(NULL, " \t\n")) - { - flags[n] = strtoul(p, NULL, 10); - } + p = strtok(NULL, " \t\n"); + + if (!p) + continue; + + flags = strtoul(p, NULL, 16); switch (type) { case FW3_TYPE_DEFAULTS: - s->running_defaults.flags = flags[0]; + s->defaults.running_flags = flags; break; case FW3_TYPE_ZONE: @@ -394,8 +405,7 @@ fw3_read_statefile(void *state) list_add_tail(&zone->list, &s->zones); } - zone->src_flags = flags[0]; - zone->dst_flags = flags[1]; + zone->running_dst_flags = flags; list_add_tail(&zone->running_list, &s->running_zones); break; @@ -411,7 +421,7 @@ fw3_read_statefile(void *state) list_add_tail(&ipset->list, &s->ipsets); } - ipset->flags = flags[0]; + ipset->running_flags = flags; list_add_tail(&ipset->running_list, &s->running_ipsets); break; } @@ -450,17 +460,16 @@ fw3_write_statefile(void *state) return; } - fprintf(sf, "%u - %u\n", FW3_TYPE_DEFAULTS, d->flags); + fprintf(sf, "%x - %x\n", FW3_TYPE_DEFAULTS, d->flags); list_for_each_entry(z, &s->running_zones, running_list) { - fprintf(sf, "%u %s %u %u\n", FW3_TYPE_ZONE, - z->name, z->src_flags, z->dst_flags); + fprintf(sf, "%x %s %x\n", FW3_TYPE_ZONE, z->name, z->dst_flags); } list_for_each_entry(i, &s->running_ipsets, running_list) { - fprintf(sf, "%u %s %u\n", FW3_TYPE_IPSET, i->name, i->flags); + fprintf(sf, "%x %s %x\n", FW3_TYPE_IPSET, i->name, i->flags); } fclose(sf);