rework runtime state tracking
[project/firewall3.git] / main.c
diff --git a/main.c b/main.c
index 65afacd..62f51e1 100644 (file)
--- a/main.c
+++ b/main.c
 static bool print_rules = false;
 static enum fw3_family use_family = FW3_FAMILY_ANY;
 
-static const char *families[] = {
-       "(bug)",
-       "IPv4",
-       "IPv6",
-};
-
-static const char *tables[] = {
-       "filter",
-       "nat",
-       "mangle",
-       "raw",
-};
-
 
 static struct fw3_state *
 build_state(void)
@@ -75,6 +62,9 @@ build_state(void)
                state->disable_ipsets = true;
        }
 
+       INIT_LIST_HEAD(&state->running_zones);
+       INIT_LIST_HEAD(&state->running_ipsets);
+
        fw3_load_defaults(state, p);
        fw3_load_ipsets(state, p);
        fw3_load_zones(state, p);
@@ -82,6 +72,8 @@ build_state(void)
        fw3_load_redirects(state, p);
        fw3_load_forwards(state, p);
 
+       state->statefile = fw3_read_statefile(state);
+
        return state;
 }
 
@@ -102,6 +94,9 @@ free_state(struct fw3_state *state)
        list_for_each_safe(cur, tmp, &state->forwards)
                fw3_free_forward((struct fw3_forward *)cur);
 
+       list_for_each_safe(cur, tmp, &state->ipsets)
+               fw3_free_ipset((struct fw3_ipset *)cur);
+
        uci_free_context(state->uci);
 
        free(state);
@@ -113,44 +108,26 @@ free_state(struct fw3_state *state)
 static bool
 restore_pipe(enum fw3_family family, bool silent)
 {
-       const char *cmd[] = {
-               "(bug)",
-               "iptables-restore",
-               "ip6tables-restore",
-       };
+       const char *cmd;
+
+       cmd = (family == FW3_FAMILY_V4) ? "iptables-restore" : "ip6tables-restore";
 
        if (print_rules)
                return fw3_stdout_pipe();
 
-       if (!fw3_command_pipe(silent, cmd[family], "--lenient", "--noflush"))
+       if (!fw3_command_pipe(silent, cmd, "--lenient", "--noflush"))
        {
-               warn("Unable to execute %s", cmd[family]);
+               warn("Unable to execute %s", cmd);
                return false;
        }
 
        return true;
 }
 
-#define family_flag(f) \
-       (f == FW3_FAMILY_V4 ? FW3_DEFAULT_IPV4_LOADED : FW3_DEFAULT_IPV6_LOADED)
-
 static bool
-family_running(struct list_head *statefile, enum fw3_family family)
+family_running(struct fw3_state *state, enum fw3_family family)
 {
-       struct fw3_statefile_entry *e;
-
-       if (statefile)
-       {
-               list_for_each_entry(e, statefile, list)
-               {
-                       if (e->type != FW3_TYPE_DEFAULTS)
-                               continue;
-
-                       return hasbit(e->flags[0], family_flag(family));
-               }
-       }
-
-       return false;
+       return hasbit(state->running_defaults.flags, family);
 }
 
 static bool
@@ -162,16 +139,16 @@ family_used(enum fw3_family family)
 static bool
 family_loaded(struct fw3_state *state, enum fw3_family family)
 {
-       return hasbit(state->defaults.flags, family_flag(family));
+       return hasbit(state->defaults.flags, family);
 }
 
 static void
 family_set(struct fw3_state *state, enum fw3_family family, bool set)
 {
        if (set)
-               setbit(state->defaults.flags, family_flag(family));
+               setbit(state->defaults.flags, family);
        else
-               delbit(state->defaults.flags, family_flag(family));
+               delbit(state->defaults.flags, family);
 }
 
 static int
@@ -181,9 +158,7 @@ stop(struct fw3_state *state, bool complete, bool restart)
        enum fw3_family family;
        enum fw3_table table;
 
-       struct list_head *statefile = fw3_read_statefile();
-
-       if (!complete && !statefile)
+       if (!complete && !state->statefile)
        {
                if (!restart)
                        warn("The firewall appears to be stopped. "
@@ -194,23 +169,23 @@ stop(struct fw3_state *state, bool complete, bool restart)
 
        for (family = FW3_FAMILY_V4; family <= FW3_FAMILY_V6; family++)
        {
-               if (!complete && !family_running(statefile, family))
+               if (!complete && !family_running(state, family))
                        continue;
 
                if (!family_used(family) || !restore_pipe(family, true))
                        continue;
 
-               info("Removing %s rules ...", families[family]);
+               info("Removing %s rules ...", fw3_flag_names[family]);
 
                for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; table++)
                {
-                       if (!fw3_has_table(family == FW3_FAMILY_V6, tables[table]))
+                       if (!fw3_has_table(family == FW3_FAMILY_V6, fw3_flag_names[table]))
                                continue;
 
                        info(" * %sing %s table",
-                            complete ? "Flush" : "Clear", tables[table]);
+                            complete ? "Flush" : "Clear", fw3_flag_names[table]);
 
-                       fw3_pr("*%s\n", tables[table]);
+                       fw3_pr("*%s\n", fw3_flag_names[table]);
 
                        if (complete)
                        {
@@ -219,12 +194,12 @@ stop(struct fw3_state *state, bool complete, bool restart)
                        else
                        {
                                /* pass 1 */
-                               fw3_flush_rules(table, family, false, statefile);
-                               fw3_flush_zones(table, family, false, statefile);
+                               fw3_flush_rules(table, family, false, state);
+                               fw3_flush_zones(table, family, false, state);
 
                                /* pass 2 */
-                               fw3_flush_rules(table, family, true, statefile);
-                               fw3_flush_zones(table, family, true, statefile);
+                               fw3_flush_rules(table, family, true, state);
+                               fw3_flush_zones(table, family, true, state);
                        }
 
                        fw3_pr("COMMIT\n");
@@ -238,17 +213,12 @@ stop(struct fw3_state *state, bool complete, bool restart)
                rv = 0;
        }
 
-       if (!restart &&
-           !family_loaded(state, FW3_FAMILY_V4) &&
-           !family_loaded(state, FW3_FAMILY_V6) &&
-           fw3_command_pipe(false, "ipset", "-exist", "-"))
+       if (!restart && fw3_command_pipe(false, "ipset", "-exist", "-"))
        {
-               fw3_destroy_ipsets(statefile);
+               fw3_destroy_ipsets(state);
                fw3_command_close();
        }
 
-       fw3_free_statefile(statefile);
-
        if (!rv)
                fw3_write_statefile(state);
 
@@ -262,8 +232,6 @@ start(struct fw3_state *state, bool restart)
        enum fw3_family family;
        enum fw3_table table;
 
-       struct list_head *statefile = fw3_read_statefile();
-
        if (!print_rules && !restart &&
            fw3_command_pipe(false, "ipset", "-exist", "-"))
        {
@@ -276,28 +244,28 @@ start(struct fw3_state *state, bool restart)
                if (!family_used(family))
                        continue;
 
-               if (!family_loaded(state, family) || !restore_pipe(family, false))
-                       continue;
-
-               if (!restart && family_running(statefile, family))
+               if (!print_rules && !restart && family_running(state, family))
                {
                        warn("The %s firewall appears to be started already. "
                             "If it is indeed empty, remove the %s file and retry.",
-                            families[family], FW3_STATEFILE);
+                            fw3_flag_names[family], FW3_STATEFILE);
 
                        continue;
                }
 
-               info("Constructing %s rules ...", families[family]);
+               if (!family_loaded(state, family) || !restore_pipe(family, false))
+                       continue;
+
+               info("Constructing %s rules ...", fw3_flag_names[family]);
 
                for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; table++)
                {
-                       if (!fw3_has_table(family == FW3_FAMILY_V6, tables[table]))
+                       if (!fw3_has_table(family == FW3_FAMILY_V6, fw3_flag_names[table]))
                                continue;
 
-                       info(" * Populating %s table", tables[table]);
+                       info(" * Populating %s table", fw3_flag_names[table]);
 
-                       fw3_pr("*%s\n", tables[table]);
+                       fw3_pr("*%s\n", fw3_flag_names[table]);
                        fw3_print_default_chains(table, family, state);
                        fw3_print_zone_chains(table, family, state);
                        fw3_print_default_head_rules(table, family, state);
@@ -315,9 +283,7 @@ start(struct fw3_state *state, bool restart)
                rv = 0;
        }
 
-       fw3_free_statefile(statefile);
-
-       if (!rv)
+       if (!rv && !print_rules)
                fw3_write_statefile(state);
 
        return rv;
@@ -424,6 +390,9 @@ int main(int argc, char **argv)
 
        if (!strcmp(argv[optind], "print"))
        {
+               if (use_family == FW3_FAMILY_ANY)
+                       use_family = FW3_FAMILY_V4;
+
                freopen("/dev/null", "w", stderr);
 
                state->disable_ipsets = true;