From: Hans Dedecker <dedeckeh@gmail.com>
Date: Mon, 1 Feb 2016 09:56:18 +0000 (+0100)
Subject: tunnel: Fix uninitialized access
X-Git-Url: http://git.archive.openwrt.org/?a=commitdiff_plain;h=18aa062d491988d6fa15092b7ed92cc6f9e44b6d;hp=1eac490bd39bcf8b48795fe0555b4451ba2bf1dd;p=project%2Fnetifd.git

tunnel: Fix uninitialized access

Fix tb_dev uninitialized access by device_init_settings

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
---

diff --git a/tunnel.c b/tunnel.c
index aa670a3..524fd43 100644
--- a/tunnel.c
+++ b/tunnel.c
@@ -49,12 +49,11 @@ tunnel_reload(struct device *dev, struct blob_attr *attr)
 	if (uci_blob_check_equal(dev->config, attr, cfg))
 		return DEV_CONFIG_NO_CHANGE;
 
-	if (attr) {
-		memset(tb_dev, 0, sizeof(tb_dev));
+	memset(tb_dev, 0, sizeof(tb_dev));
 
+	if (attr)
 		blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
 			blob_data(attr), blob_len(attr));
-	}
 
 	device_init_settings(dev, tb_dev);