X-Git-Url: http://git.archive.openwrt.org/?a=blobdiff_plain;f=src%2Fconfig.c;h=a5bcf265107318d94afbf7b68c2afcc2ef1385b6;hb=0fa1231d1296d82d8ee75dbe024c9a4509e784fe;hp=e31740bdd7ee28aeae21f94e07d2d078152123a9;hpb=ab6cef402c4f5982fddf72a8633d2a463e8d9006;p=project%2Fodhcpd.git

diff --git a/src/config.c b/src/config.c
index e31740b..a5bcf26 100644
--- a/src/config.c
+++ b/src/config.c
@@ -254,10 +254,10 @@ err:
 }
 
 
-int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite)
+int config_parse_interface(void *data, size_t len, const char *name, bool overwrite)
 {
 	struct blob_attr *tb[IFACE_ATTR_MAX], *c;
-	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, blob_data(b), blob_len(b));
+	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, data, len);
 
 	if (tb[IFACE_ATTR_INTERFACE])
 		name = blobmsg_get_string(tb[IFACE_ATTR_INTERFACE]);
@@ -270,13 +270,13 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 		iface = calloc(1, sizeof(*iface));
 		strncpy(iface->name, name, sizeof(iface->name) - 1);
 		list_add(&iface->head, &interfaces);
-	} else {
+	} else if (overwrite) {
 		clean_interface(iface);
 	}
 
 	const char *ifname = NULL;
 #ifdef WITH_UBUS
-	if (overwrite)
+	if (overwrite || !iface->ifname[0])
 		ifname = ubus_get_ifname(name);
 #endif
 	if ((c = tb[IFACE_ATTR_IFNAME]))
@@ -284,10 +284,12 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 	else if ((c = tb[IFACE_ATTR_NETWORKID]))
 		ifname = blobmsg_get_string(c);
 
-	if (!ifname)
+	if (!iface->ifname[0] && !ifname)
 		return -1;
 
-	strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+	if (ifname)
+		strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+
 	iface->inuse = true;
 
 	if (overwrite)
@@ -481,7 +483,7 @@ static int set_interface(struct uci_section *s)
 {
 	blob_buf_init(&b, 0);
 	uci_to_blob(&b, s, &interface_attr_list);
-	return config_parse_interface(b.head, s->e.name, true);
+	return config_parse_interface(blob_data(b.head), blob_len(b.head), s->e.name, true);
 }