luci-0.9: merge r4886-r4890

[project/luci.git] / libs / web / luasrc / sauth.lua

diff --git a/libs/web/luasrc/sauth.lua b/libs/web/luasrc/sauth.lua
index fc4942b..e5cb178 100644 (file)
--- a/libs/web/luasrc/sauth.lua
+++ b/libs/web/luasrc/sauth.lua
@@ -12,17 +12,22 @@ You may obtain a copy of the License at
 $Id$
 
 ]]--
+
+--- LuCI session library.
 module("luci.sauth", package.seeall)
 require("luci.fs")
 require("luci.util")
+require("luci.sys")
 require("luci.config")
+local nixio = require "nixio", require "nixio.util"
+local fs = require "nixio.fs"
 
 
 luci.config.sauth = luci.config.sauth or {}
 sessionpath = luci.config.sauth.sessionpath
-sessiontime = tonumber(luci.config.sauth.sessiontime)
-
+sessiontime = tonumber(luci.config.sauth.sessiontime) or 15 * 60
 
+--- Manually clean up expired sessions.
 function clean()
        local now   = os.time()
        local files = luci.fs.dir(sessionpath)
@@ -34,29 +39,72 @@ function clean()
        for i, file in pairs(files) do
                local fname = sessionpath .. "/" .. file
                local stat = luci.fs.stat(fname)
-               if stat and stat.type == "regular" and stat.atime + sessiontime < now then
+               if stat and stat.type == "reg" and stat.mtime + sessiontime < now then
                        luci.fs.unlink(fname)
                end 
        end
 end
 
+--- Prepare session storage by creating the session directory.
 function prepare()
-       luci.fs.mkdir(sessionpath)
-       luci.fs.chmod(sessionpath, "a-rwx,u+rwx")
+       fs.mkdir(sessionpath, 700)
+        
+       if not sane() then
+               error("Security Exception: Session path is not sane!")
+       end
 end
 
+--- Read a session and return its content.
+-- @param id   Session identifier
+-- @return             Session data
 function read(id)
        if not id then
                return
        end
+       if not id:match("^%w+$") then
+               error("Session ID is not sane!")
+       end
        clean()
+       if not sane(sessionpath .. "/" .. id) then
+               return
+       end
+       luci.fs.utime(sessionpath .. "/" .. id)
        return luci.fs.readfile(sessionpath .. "/" .. id)
 end
 
+
+--- Check whether Session environment is sane.
+-- @return Boolean status
+function sane(file)
+       return luci.sys.process.info("uid")
+                       == luci.fs.stat(file or sessionpath, "uid")
+               and luci.fs.stat(file or sessionpath, "modestr")
+                       == (file and "rw-------" or "rwx------")
+end
+
+
+--- Write session data to a session file.
+-- @param id   Session identifier
+-- @param data Session data
 function write(id, data)
-       if not luci.fs.stat(sessionpath) then
+       if not sane() then
                prepare()
        end
-       luci.fs.writefile(sessionpath .. "/" .. id, data)
-       luci.fs.chmod(sessionpath .. "/" .. id, "a-rwx,u+rw")
+       if not id:match("^%w+$") then
+               error("Session ID is not sane!")
+       end
+       
+       local f = nixio.open(sessionpath .. "/" .. id, "w", 600)
+       f:writeall(data)
+       f:close()
+end
+
+
+--- Kills a session
+-- @param id   Session identifier
+function kill(id)
+       if not id:match("^%w+$") then
+               error("Session ID is not sane!")
+       end
+       luci.fs.unlink(sessionpath .. "/" .. id)
 end
\ No newline at end of file